From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KHEGEFzNS2WbhAEAWB0awg (envelope-from ) for ; Wed, 08 Nov 2023 13:03:08 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=gWXPLmW4; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 328A31E0C1; Wed, 8 Nov 2023 13:03:08 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DA8D41E00F for ; Wed, 8 Nov 2023 13:03:05 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4B4BD3858434 for ; Wed, 8 Nov 2023 18:03:05 +0000 (GMT) Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 7ACFC3858D3C for ; Wed, 8 Nov 2023 18:02:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7ACFC3858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7ACFC3858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699466574; cv=none; b=Ifrgl2btwiYxMiudsbM52jaqV+JVSkDOjh/ubnXgG91zJWoNbRPeQgBmK9Yn9wizuCHl7KPSz0yqrEi8kh0G68NUvrEPM1Kyxa+cWxG00pL+GBOvJUOm/e2YmZJu+vyWOxuc8jcH1yyqdGGBMeB35fwuk1nd8fpahy5QpY0wojU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699466574; c=relaxed/simple; bh=bEQ58Cb4gIe8fecmOkCEy65URLoz3+82kWEIH7PAGWo=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:Mime-Version; b=sDmRfaWy97r+UAUe6NpVK/bs0dyRC61YhYug1ADaGB/4ekrg72kQa04qSVyllG9LV3XnJPC+D3yqI6hWs4oBcwEV0Yjcaib63WoT7OiS9je1KnPXCyT3kfJuFfga06WfEUcYe4YrcVyhbIGkdLbltlo8pRYmk76tr3TZm4qN7lY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353724.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3A8I0gY2026386; Wed, 8 Nov 2023 18:02:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=FatUJYedE1sgox5NZ8Qe3FC1FzORO6gQDv3gl1yxLY4=; b=gWXPLmW4M4yG5YB7HR/Zdd1PEfB+YiIRrUnYqV5SjGXqsuTMYcB1U92CSlEi9tCDXnZ4 h7wqvSf8DY0JqkQ0VUqOsziBuCQvY2HU4uKa2F04TLrjiL9/ELLY8CgFGzjYImniXSQ6 NDm9PBMR9dVmrpnaeRFBMo7motdsP9ERWuTBIg/pSUiSfVEq3thIbGIxXinT+aYnhska dUZUDNbY+j4b9gaHFuAhfMdf2zXrITwEfEjc3NUhvX7xaxGP0I3Y8RxUG6DXjg4Xt0dB KN80vIBEXtMb3bNW+qzMz0zUYfynGV/l8rOh0BofCvl0DtChmVEx7+juSfL1rIQST/wD uw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3u8f7v01v0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Nov 2023 18:02:41 +0000 Received: from m0353724.ppops.net (m0353724.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3A8I2fIK032258; Wed, 8 Nov 2023 18:02:41 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3u8f7v01uk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Nov 2023 18:02:41 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3A8GcH9F028302; Wed, 8 Nov 2023 18:02:40 GMT Received: from smtprelay06.wdc07v.mail.ibm.com ([172.16.1.73]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3u7w22ek9n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 08 Nov 2023 18:02:40 +0000 Received: from smtpav06.dal12v.mail.ibm.com (smtpav06.dal12v.mail.ibm.com [10.241.53.105]) by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3A8I2dGG18350760 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 8 Nov 2023 18:02:39 GMT Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7AA055805D; Wed, 8 Nov 2023 18:02:39 +0000 (GMT) Received: from smtpav06.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A9EB958043; Wed, 8 Nov 2023 18:02:38 +0000 (GMT) Received: from wecm-9-67-110-146.wecm.ibm.com (unknown [9.67.110.146]) by smtpav06.dal12v.mail.ibm.com (Postfix) with ESMTP; Wed, 8 Nov 2023 18:02:38 +0000 (GMT) Message-ID: <290c84968ebe8a82359e28cf49b50dc79a21845c.camel@linux.ibm.com> Subject: Re: [PATCH ver 2] Fix the gdb.ada/inline-section-gc.exp test From: Carl Love To: Luis Machado , gdb-patches@sourceware.org, Tom Tromey Cc: Guinevere Larsen , Ulrich Weigand Date: Wed, 08 Nov 2023 10:02:37 -0800 In-Reply-To: <54a336be-249d-40e9-b4e0-68602734ce26@arm.com> References: <54a336be-249d-40e9-b4e0-68602734ce26@arm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-22.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: mwgWjFqTxl31otdq38roVq_KxqvWGnSC X-Proofpoint-GUID: FkO6M6q_lWgcfS3E8aXJX75wKFeNfiww X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-08_06,2023-11-08_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 mlxscore=0 phishscore=0 malwarescore=0 adultscore=0 spamscore=0 mlxlogscore=551 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311080148 X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Luis, Tom: On Wed, 2023-11-08 at 16:57 +0000, Luis Machado wrote: > Hi Carl, > > This fixes the FAIL's I had been seeing on aarch64-linux. Thanks! > > Some nits... > > > > file callee.adb or in > > +# file caller.adb where the callee function was inlined. Either > > way, only > > +# on breakpoint should be reported and it's address should not be > > at 0x0. > s/on breakpoint/one breakpoint? > > s/and it's/and its? Fixed both issues. On Wed, 2023-11-08 at 09:54 -0700, Tom Tromey wrote:> > > > > > "Carl" > > I think it looks good, but I have one nit. > > Carl> +set bp_location1 [gdb_get_line_number "BREAK" > ${testdir}/callee.adb] > Carl> +set bp_location2 [expr $bp_location1 - 1] > > It would be better to just stick some comment on the relevant line in > caller.adb and then use gdb_get_line_number to fetch it. OK, that works. I added a comment to set the line number on. The comment has to be placed on the line in caller where the BREAK line ends up after callee is inlined into caller, which is not really obvious at first glance. I worked hard to make it clear in the comment and the commit log. Hopefully it is clear to the reader. Will post version 3. Thanks for the feedback and help with the patch. Carl