Re: [PATCH v3 4/4] gdb/doc: document '+' argument for 'list' command

Bruno Larsen via Gdb-patches
2023-06-21T11:21:22Z

On 21/06/2023 13:13, Eli Zaretskii wrote:
>> From: Bruno Larsen <blarsen@redhat.com>
>> Cc: Bruno Larsen <blarsen@redhat.com>,
>> Eli Zaretskii <eliz@gnu.org>
>> Date: Wed, 21 Jun 2023 12:45:45 +0200
>>
>> The command 'list' has accepted the argument '+' for many years already,
>> but this option wasn't documented either in the texinfo docs or in the
>> help text for the command. This commit documents it.
>>
>> Reviewed-By: Eli Zaretskii <eliz@gnu.org>
>> ---
>> gdb/cli/cli-cmds.c | 1 +
>> gdb/doc/gdb.texinfo | 4 ++++
>> 2 files changed, 5 insertions(+)
>>
>> diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c
>> index a966142eaea..b7cbe673985 100644
>> --- a/gdb/cli/cli-cmds.c
>> +++ b/gdb/cli/cli-cmds.c
>> @@ -2822,6 +2822,7 @@ and send its output to SHELL_COMMAND."));
>> List specified function or line.\n\
>> With no argument, lists ten more lines after or around previous listing.\n\
>> \"list .\" lists ten lines arond where the inferior is stopped.\n\
>> +\"list +\" lists the ten lines following a previous ten-line listing.\n\
>> \"list -\" lists the ten lines before a previous ten-line listing.\n\
>> One argument specifies a line, and ten lines are listed around that line.\n\
>> Two arguments with comma between specify starting and ending lines to list.\n\
> This part is OK.
>
>> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
>> index e4e374d138c..f9c3c90e16a 100644
>> --- a/gdb/doc/gdb.texinfo
>> +++ b/gdb/doc/gdb.texinfo
>> @@ -9149,6 +9149,10 @@ Stack}), this prints lines centered around that line. If no
>> @code{list} command has been used and no solitary line was printed,
>> it prints the lines around the function @code{main}.
>>
>> +@item list +
>> +Same as using with no arguments, but errors out if the line is
>> +past the end of the file.
> But here it looks like some copy/pasta error?
>
No, this is the main distinguishing feature between "list" and "list +",
the latter will error out if it is past the end of the file, while the
former won't.

--
Cheers,
Bruno