From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30221 invoked by alias); 15 Aug 2019 14:37:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30205 invoked by uid 89); 15 Aug 2019 14:37:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.7 required=5.0 tests=AWL,BAYES_00,KAM_SHORT,SPF_PASS autolearn=ham version=3.3.1 spammy=marchi X-HELO: esa2.mentor.iphmx.com Received: from esa2.mentor.iphmx.com (HELO esa2.mentor.iphmx.com) (68.232.141.98) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Aug 2019 14:37:13 +0000 IronPort-SDR: 2/Z8Sq30U/jWD3N7pySzMoRGE2rWMY3kUFGGYkG3Yg5iwwCZFGunvwXtfLbxz8aWSpJxrcbxt+ HGvIgDdk9hDPo8zoZFrjr4ALWHCY89BG91eVVHsQVdMRIzKsbsAB36DanKJbg5Wg44DTfva7pP ksh2K45zskK+I+BIV370OVUkmY8EqB5e9m2AkwNvpcS85flRJMi6BVQB0CKnlR5+IGoprmzvsf gwJPAQr5xYqQvXWO8Z3m+A8bKdrBXhXFBLe+EjqoMN52Dfa7bYavRc8YtCqyVSZJBTlWZazoxF L4k= Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 15 Aug 2019 06:37:11 -0800 IronPort-SDR: JTxS+z+0RWWXPbyjGlbnCWxqq7Tbxl8ZKcBspSe+uMn1mmAAQNx72SQg7vYqJQ9Tiqoy4TTsSk XlkP9LRHyW0Odxkz9koDYIgOtbz68TM0+HEDdDMLKDYQl1BgO+WRC+efRSG6BUmQfF/OJQuycc jD1MKTnouXm/tGPAAxdMunMvVF7r0gttlAc4COEVyYjAVHdkTc1v+RbGbftl/EO3dk9zQ70BY7 5ddaWJZ94P/EHRNi5k3dX/3ReGxgRncNG0SJ6bhCZm8Wkn+A8Bh0fRpsNNbN16HvgW+4/RhyE+ J+g= Subject: Re: [patch, testsuite] Disable dw2-dir-file-name.exp on remote and/or Windows host To: Simon Marchi , "gdb-patches@sourceware.org" References: <9bb4446e-8a94-496d-ab8c-6d1197ac0728@codesourcery.com> <18b00c50-2cc0-b327-a06b-25df81b2f70b@simark.ca> From: Sandra Loosemore Message-ID: <28ebe7e6-7001-96f2-6926-a52edbff8148@codesourcery.com> Date: Thu, 15 Aug 2019 14:37:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <18b00c50-2cc0-b327-a06b-25df81b2f70b@simark.ca> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Return-Path: sandra@codesourcery.com X-SW-Source: 2019-08/txt/msg00322.txt.bz2 On 8/14/19 9:12 PM, Simon Marchi wrote: > On 2019-08-13 6:29 p.m., Sandra Loosemore wrote: >> This is yet another testsuite fix to clean up results on remote Windows >> host. >> >> For this testcase, I did consider trying to fix it rather than just >> disabling it for remote host, but it looked like it was going to be an >> awful lot of work and trial-and-error (it has almost no comments to >> explain what it is trying to test, or how it is getting there). I think >> it is at least an incremental improvement to document that it isn't >> expected to work as-is on remote host. And disabling it does get rid of >> 33 completely bogus FAILs. :-P >> >> OK? >> >> -Sandra >> > >> +# This test has hard-wired assumptions that host and build filenames are >> +# the same, and assumes POSIX pathname syntax. >> +if { [is_remote host] || [ishost *-*-mingw*] } { >> + return 0 >> +} >> + > > Should we use "untested" or "unsupported" before returning, to have at least a status > in the logs? The definition of "unsupported" seems appropriate for this case: > > Declares that a test case depends on some facility that does not exist in the > testing environment. > > From: https://www.gnu.org/software/dejagnu/manual/unsupported-procedure.html > > Simon > I did consider that, but the existing previous bit in that file is just # This test can only be run on targets which support DWARF-2 and use gas. if {![dwarf2_support]} { return 0 } (which also appears in almost all the other gdb.dwarf2/*.exp files) so I thought it would be locally consistent to just return quietly. Is the policy to use "untested" for host issues but not target properties, maybe? I'll do whatever conforms to recommended practice here, of course. -Sandra