Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Ronald Hecht <ronald.hecht@gmx.de>
To: gdb-patches@sourceware.org
Subject: [PATCH] gdb: z80: Guard against missing symtab in skip_prologue
Date: Wed, 3 Jun 2026 14:11:48 +0200	[thread overview]
Message-ID: <289d2478-6150-4499-a367-426ab9c88a40@gmx.de> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 352 bytes --]

|Hi, this is the patch from PR tdep/34198. It fixes an internal 
segmentation fault in z80_skip_prologue when setting "break main" on 
some Z80 binaries. "break *main" works, which points at the prologue/SAL 
path. Regression-tested manually with the reproducer from the PR. 
Thanks, Ronald https://sourceware.org/bugzilla/show_bug.cgi?id=34198 |

[-- Attachment #1.2: Type: text/html, Size: 838 bytes --]

[-- Attachment #2: 0001-gdb-z80-Guard-against-missing-symtab-in-skip_prologu.patch --]
[-- Type: text/x-patch, Size: 1346 bytes --]

From 14a45c8bd64db9c6c41c75bd9a7de2c95935e9f2 Mon Sep 17 00:00:00 2001
From: Ronald Hecht <r.hecht@astech.de>
Date: Wed, 3 Jun 2026 14:05:07 +0200
Subject: [PATCH] gdb: z80: Guard against missing symtab in skip_prologue

Signed-off-by: Ronald Hecht <r.hecht@astech.de>
---
 gdb/z80-tdep.c | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/gdb/z80-tdep.c b/gdb/z80-tdep.c
index f7e207d0..f2e9b09e 100644
--- a/gdb/z80-tdep.c
+++ b/gdb/z80-tdep.c
@@ -495,12 +495,17 @@ z80_skip_prologue (struct gdbarch *gdbarch, CORE_ADDR pc)
   if (prologue_end != 0)
     {
       struct symtab_and_line prologue_sal = find_sal_for_pc (func_addr, 0);
-      struct compunit_symtab *compunit = prologue_sal.symtab->compunit ();
-      const char *debug_format = compunit->debugformat ();
-
-      if (debug_format != NULL &&
-	  !strncasecmp ("dwarf", debug_format, strlen("dwarf")))
-	return std::max (pc, prologue_end);
+      if (prologue_sal.symtab != nullptr)
+	{
+	  struct compunit_symtab *compunit = prologue_sal.symtab->compunit ();
+	  if (compunit != nullptr)
+	    {
+	      const char *debug_format = compunit->debugformat ();
+	      if (debug_format != nullptr
+		  && !strncasecmp ("dwarf", debug_format, strlen ("dwarf")))
+		return std::max (pc, prologue_end);
+	    }
+	}
     }
 
   return pc;
-- 
2.43.0


             reply	other threads:[~2026-06-03 12:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-03 12:11 Ronald Hecht [this message]
2026-06-03 15:32 ` [PP?] " Simon Marchi
2026-06-04  6:58   ` Ronald Hecht
2026-06-04 19:49     ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=289d2478-6150-4499-a367-426ab9c88a40@gmx.de \
    --to=ronald.hecht@gmx.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox