From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-136370-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 26148 invoked by alias); 20 Jan 2017 16:59:50 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 26098 invoked by uid 89); 20 Jan 2017 16:59:46 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 20 Jan 2017 16:59:46 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id CD4413A7683;	Fri, 20 Jan 2017 16:59:45 +0000 (UTC)
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v0KGxi42020993;	Fri, 20 Jan 2017 11:59:45 -0500
Subject: Re: [PATCH] Make gdb.python/python.exp more robust
To: Luis Machado <lgustavo@codesourcery.com>, gdb-patches@sourceware.org
References: <1484923030-16656-1-git-send-email-lgustavo@codesourcery.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <2899cd10-7498-6b56-c53b-f2eb1f87e5fa@redhat.com>
Date: Fri, 20 Jan 2017 16:59:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <1484923030-16656-1-git-send-email-lgustavo@codesourcery.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2017-01/txt/msg00426.txt.bz2

On 01/20/2017 02:37 PM, Luis Machado wrote:

>  }
>  gdb_test "python print (symtab\[1\]\[0\].symtab)" ".*${python_1_c}" "test decode_line func1 filename"
> -gdb_test "python print (symtab\[1\]\[0\].line)" "19" "test decode_line func1 line number"
> +
> +# Fetch the line GDB thinks func1 starts at.  This may change depending
> +# on the architecture and on how GDB handles the prologue of the function.
> +gdb_test_multiple "info line func1" "info line func1" {
> +    -re "Line ($decimal) of .* starts at address $hex <func1> and ends at $hex <func1\\+$decimal>\.\[\r\n\]+$gdb_prompt $" {
> +	# Fetch the line number.
> +	set func1_lineno $expect_out(1,string)
> +    }
> +}

Do:

  set func1_lineno "noline"

before gdb_test_multiple, so that in case the above FAILs, this:

> +
> +gdb_test "python print (symtab\[1\]\[0\].line)" "$func1_lineno" "test decode_line func1 line number"

FAILs too, instead of ERRORing out with a TCL error, due to
undefined $func1_lineno.

OK with that change.

Thanks,
Pedro Alves