From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41800 invoked by alias); 20 Nov 2016 16:36:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41787 invoked by uid 89); 20 Nov 2016 16:36:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=edited, packaged, Hx-languages-length:2903 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 20 Nov 2016 16:36:11 +0000 Received: by simark.ca (Postfix, from userid 33) id 2E1D61E80F; Sun, 20 Nov 2016 11:36:09 -0500 (EST) To: Ambrogino Modigliani Subject: Re: [PATCH 02/20] Fix spelling mistakes in comments in configure scripts X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sun, 20 Nov 2016 16:36:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org, pedro_alves@portugalmail.pt In-Reply-To: <1479654381-20698-3-git-send-email-ambrogino.modigliani@mail.com> References: <1479654381-20698-1-git-send-email-ambrogino.modigliani@mail.com> <1479654381-20698-3-git-send-email-ambrogino.modigliani@mail.com> Message-ID: <287b26d00ecff632374d7c291e29367a@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.2 X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00555.txt.bz2 Hi Ambrogino, On 2016-11-20 10:06, Ambrogino Modigliani wrote: > All changes are limited to comments, and no run-time behavior is > affected. > > bfd/ChangeLog: > > * bfd/configure: Fix spelling in comments. > * bfd/configure.ac: Fix spelling in comments. > > binutils/ChangeLog: > > * binutils/configure: Fix spelling in comments. > > gdb/ChangeLog: > > * gdb/configure: Fix spelling in comments. > * gdb/configure.ac: Fix spelling in comments. > > gas/ChangeLog: > > * gas/configure: Fix spelling in comments. > > gold/ChangeLog: > > * gold/configure: Fix spelling in comments. > > gprof/ChangeLog: > > * gprof/configure: Fix spelling in comments. > > ld/ChangeLog: > > * ld/configure: Fix spelling in comments. > > libiberty/ChangeLog: > > * libiberty/configure: Fix spelling in comments. > * libiberty/configure.ac: Fix spelling in comments. > > opcodes/ChangeLog: > > * opcodes/configure: Fix spelling in comments. > > sim/mips/ChangeLog: > > * sim/mips/configure: Fix spelling in comments. > * sim/mips/configure.ac: Fix spelling in comments. > --- > bfd/configure | 4 ++-- > bfd/configure.ac | 2 +- > binutils/configure | 2 +- > gas/configure | 2 +- > gdb/configure | 2 +- > gdb/configure.ac | 2 +- > gold/configure | 2 +- > gprof/configure | 2 +- > ld/configure | 2 +- > libiberty/configure | 10 +++++----- > libiberty/configure.ac | 10 +++++----- > opcodes/configure | 2 +- > sim/mips/configure | 4 ++-- > sim/mips/configure.ac | 4 ++-- > 14 files changed, 25 insertions(+), 25 deletions(-) > > diff --git a/bfd/configure b/bfd/configure > index 68db12f..ab239fe 100755 > --- a/bfd/configure > +++ b/bfd/configure > @@ -12291,7 +12291,7 @@ fi > rm -f conftest* > > > -# Verify CC_FOR_BUILD to be compatible with waring flags > +# Verify CC_FOR_BUILD to be compatible with warning flags This line of code (which appears multiple times) actually comes from bfd/warning.m4, which you fix in a later patch. Since "configure" files are generated from "configure.ac" files (and indirectly from other input files such as bfd/warning.m4), they shouldn't be edited directly. Usually, you edit "configure.ac", and run autoconf (version 2.64) to re-generate "configure": $ ... edit configure.ac ... $ autoconf-2.64 $ git add configure configure.ac Your ChangeLog entries can then look like: * configure.ac: Fix spelling in comments. * configure: Re-generate. I suggest that you only manually edit "configure.ac" files in this patch, and include the relevant changes in "configure" files (by running autoconf-2.64). Then, in your patch about m4 files, you can include the changes to "configure" files caused by that patch (found by re-running autoconf-2.64 at that point). autoconf-2.64 is packaged by many distributions (such as Debian's package autoconf2.64), but otherwise it's easy to build from source. Thanks, Simon