Re: [PATCH] Also install data-directory into the build directory as computed by relocate_gdb_directory

Khoo Yit Phang
2012-09-27T14:57:13Z

Hi,

On Sep 27, 2012, at 5:17 AM, Joel Brobecker wrote:

> It took me a long time to understand why you had to do things the way
> you do. I would have prefered a patch that just needs to call make with
> a new value for "prefix" set to "$(top_build_dir)/..", rather . But it
> would not work if configured with --with-gdb-datadir.
>
> There is an issue, I think, with your patch, unfortunately: I think
> it requires GNU Make, as you are using variable substitution which
> I do not think is available with all flavors of make.
>
> There are only so many options I can see:
> 1. Conditionalize this feature to having GNU Make. Not sure how to do
> that, though;
> 2. Compute the in-tree directory locations during the configure
> step.

I could rewrite it to use sed instead, which is already used in install-python and other places. Or, we could just assume that --with-gdb-datadir or --bindir are not used during configuration and install with "prefix" set to "$(top_build_dir)/..".

Yit
September 27, 2012