Re: [PATCH 2/2] Try to initialize data-directory by first searching for "data-directory" in the same directory as the gdb binary

Khoo Yit Phang
2012-09-24T15:08:26Z

Hi,

On Sep 24, 2012, at 10:59 AM, Joel Brobecker wrote:

>> How about this solution, instead of patching the gdb binary, I can
>> install a shell script into the build directory that contains:
>
> In addition to Eli's comments, a shell script isn't debuggable.
>
> I know we are walking on thin ice with this data-directory issue,
> but I think it's worth our trouble in this case. The side-effect
> of your _gdb patch is something that's really important to me;
> that's why I am pushing a little harder than usual.
>
> As far as I could tell, Jan and yourself were discussing two patches
> that should work. You like neither of them, but short of having
> a solution that either of you likes, why not just commit one of them?
> As long as we take the build data-directory as a fallback over a non-
> existant standard (configured/possibly relocated) data-directory,
> I don't see a problem.

I'd just like to point out any issues that may arise in the future and offer other solutions; but I'm willing to commit either patch. Which one would you prefer?

Yit
September 24, 2012