From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id 23CED3939C35 for ; Tue, 23 Jun 2020 11:41:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 23CED3939C35 Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-277-f8yqdIsFMr-25HfqTpq2sw-1; Tue, 23 Jun 2020 07:41:29 -0400 X-MC-Unique: f8yqdIsFMr-25HfqTpq2sw-1 Received: by mail-wr1-f72.google.com with SMTP id f5so14995253wrv.22 for ; Tue, 23 Jun 2020 04:41:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=tQ5/QJrh7KlYxcC3VVwHOe643HVxQMEgfWGNrXZRZ3k=; b=nQ1NZeCttpMv3vGH+7Q6C5xUyznmoQArh6tYpKHMucBe3828DJD0bBTBXqySiKGOc5 POe+36vDvZJ7mVBIvvc9aCnfgpM1kbHw62DhtkiSh8bsErOVh8wOXtRxxQkIeluIx/1+ P6E05M7M/94S0piP4mkTBZYHXVgtKf0mbIy8T1Cl7jLryeC0lrzWJCp6y4MDXh7jJe0F aCW8edWYszl60ki4CWFVtmWxJ/YlnxseLcsvnnvzuih8BY8PrMRGn5heH6XN4BlmPqtt bHSHxn1koHBpBkmuruIEXWRV2U3HTwgBo8bxFvE4LVkdbp9+fQnShuf6wCaNMdoLgceA pehw== X-Gm-Message-State: AOAM530Zct6GJp85CmnDA3pB0NQfdPTOLvclhvWXQo5MNkMqOTWWOGhi GZZBCQIyil10zz32LWtDS2w+uXITn8kNRBtLbutmKV4EKjD8fHxn0G0JtvAQ7qlfN6urN7i7RYq 4/h4xZEY70AjWhd/lvezjkQ== X-Received: by 2002:a05:6000:1283:: with SMTP id f3mr6871684wrx.106.1592912488117; Tue, 23 Jun 2020 04:41:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxvkjZDlHi4YzzuNA+Fb7GuzH4iAOCaCW2nyheVNDXXUICYpU/laZmGmeK1DaDG3bWIV5cj3A== X-Received: by 2002:a05:6000:1283:: with SMTP id f3mr6871672wrx.106.1592912487929; Tue, 23 Jun 2020 04:41:27 -0700 (PDT) Received: from ?IPv6:2001:8a0:f922:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f922:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id p9sm3255256wma.48.2020.06.23.04.41.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2020 04:41:27 -0700 (PDT) Subject: Re: [OB PATCH] Avoid testcase build failures with -Wunused-value To: Gary Benson , gdb-patches@sourceware.org References: <1592911602-4914-1-git-send-email-gbenson@redhat.com> From: Pedro Alves Message-ID: <27d9d693-8afb-d07f-6d14-d867d42babdd@redhat.com> Date: Tue, 23 Jun 2020 12:41:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <1592911602-4914-1-git-send-email-gbenson@redhat.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Jun 2020 11:41:33 -0000 On 6/23/20 12:26 PM, Gary Benson via Gdb-patches wrote: > --- a/gdb/testsuite/gdb.cp/namespace.cc > +++ b/gdb/testsuite/gdb.cp/namespace.cc > @@ -150,22 +150,22 @@ namespace C > // plan to have GDB try to print out, just to make sure that the > // compiler and I agree which ones should be legal! It's easy > // to screw up when testing the boundaries of namespace stuff. > - c; > + int unused1 = c; It looks like such a fix will only work until the compiler decides to enable -Wunused-variable by default too: testsuite/gdb.cp/namespace.cc:153:11: warning: unused variable 'unused' [-Wunused-variable] int unused = c; ^ Try compiling the testcase with -Wall, with both g++ and clang++: $ clang++ testsuite/gdb.cp/namespace.cc -Wall I think we should fix this with the more usual cast-to-void way: (void) c; etc.