From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id nLPfFeRSgWcJlQkAWB0awg (envelope-from ) for ; Fri, 10 Jan 2025 12:03:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1736528612; bh=odJTXpRMWMnEhu9cVbucCwZGlogLQUCyzgfNkCb4RWo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=e9u3Pad9hmbOkQ+YUcDjAiLE9dRc6QhL1jQbS6/IFOtOo+FFuIb1IoIoI2TrQQ5nW 0bSU7/6zmtkGlgilbGTxo26LWPP2/AIs6l92YxHXVXnn4spSRFCzijcOynH5xxAps/ CbDMOmKPOMUg6gVeSBeEkkrHOXu5hmxdZQgQR1B0= Received: by simark.ca (Postfix, from userid 112) id 4B5051E0C0; Fri, 10 Jan 2025 12:03:32 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=JmHqo2LB; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Hqi6wbyo; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B5CD71E05C for ; Fri, 10 Jan 2025 12:03:31 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 56AC2385C6D5 for ; Fri, 10 Jan 2025 17:03:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 56AC2385C6D5 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=JmHqo2LB; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=Hqi6wbyo Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 5827A385AC23 for ; Fri, 10 Jan 2025 17:02:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5827A385AC23 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5827A385AC23 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736528567; cv=none; b=Ot6rBxFuwWZY9PdxYBlIXbx/quS0pq8HSj/ZVCQzD11+dqv7eTiX6WkU6Vr8u6vyW/Tfps17YRnzcOTPWHIAnSyd8ScGXZDB4anBSMieDZi8+Ckt4ELfSPaRtl55fItK7hLehV/kEhzCB0z9qvevpgpQK8dNSNSvgY0/4HmPwJU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736528567; c=relaxed/simple; bh=odJTXpRMWMnEhu9cVbucCwZGlogLQUCyzgfNkCb4RWo=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=cZdsiVYOZlUlc5KPVD7qH+y/J3R2tLZRRJAcdhlWqOAvIzjOn4xcXwDELQt2aG2pZM/Uq2txwK6EonrsNfpEkzFOpdohtn1P/HXCgKxYs6f0YwWMaPQHuzlmObqBlUe6BvsON9RRhxDJtREWPkqRZZb5APUBleiWgPv4TA+GU3Q= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5827A385AC23 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1736528566; bh=odJTXpRMWMnEhu9cVbucCwZGlogLQUCyzgfNkCb4RWo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=JmHqo2LBibazPG7amBRwTIQqQ1/h/+AW6wM3rkRIjpjhJuy3HrSCNNF8r1wmyDgMO vceFIaSFcp1+qLX4f0H4c8Uhmb1mbkBOF4iQM7KJqIIg214KYwzalROnELDX/lxlO5 rVUK9837a2gm2uahpaXGIROXaoMbLwUnX02lPVdk= Received: by simark.ca (Postfix, from userid 112) id 939201E0F7; Fri, 10 Jan 2025 12:02:46 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1736528564; bh=odJTXpRMWMnEhu9cVbucCwZGlogLQUCyzgfNkCb4RWo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Hqi6wbyoGXj5uzgSF6XLv9wCGvv1NA4A7PQ1jmX4E0bJPJs9mRObvSkeYtJ7rUoR+ I0w+v7/eXkvYKTd7gDtJoeBhppwubW/BzriQLVy+DVfIYhtOBYuZpeimrWb9hKLJ5K cylt2lJPISXxpAkS5VS7HGs4LDhcIUFbbxhHLThA= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id A31A81E05C; Fri, 10 Jan 2025 12:02:44 -0500 (EST) Message-ID: <27c5451c-bc77-480d-bd04-8c70e852c24e@simark.ca> Date: Fri, 10 Jan 2025 12:02:44 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] GDB: frame: Make VALUEP argument optional in frame_register_unwind To: Thiago Jung Bauermann , gdb-patches@sourceware.org Cc: "Aktemur, Tankut Baris" , "Maciej W. Rozycki" References: <20250110164430.3376697-1-thiago.bauermann@linaro.org> <20250110164430.3376697-2-thiago.bauermann@linaro.org> Content-Language: en-US From: Simon Marchi In-Reply-To: <20250110164430.3376697-2-thiago.bauermann@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2025-01-10 11:43, Thiago Jung Bauermann wrote: > It already accepts a nullptr value and a couple of places were always > calling it that way, so make it possible to omit the argument entirely. > --- > gdb/frame.c | 4 ++-- > gdb/frame.h | 4 ++-- > gdb/stack.c | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/gdb/frame.c b/gdb/frame.c > index a6900b280724..ba4a07179f64 100644 > --- a/gdb/frame.c > +++ b/gdb/frame.c > @@ -1447,7 +1447,7 @@ put_frame_register (const frame_info_ptr &next_frame, int regnum, > gdb_assert (buf.size () == size); > > frame_register_unwind (next_frame, regnum, &optim, &unavail, &lval, &addr, > - &realnum, nullptr); > + &realnum); > if (optim) > error (_("Attempt to assign to a register that was not saved.")); > switch (lval) > @@ -2159,7 +2159,7 @@ frame_register_unwind_location (const frame_info_ptr &initial_this_frame, > int unavailable; > > frame_register_unwind (this_frame, regnum, optimizedp, &unavailable, > - lvalp, addrp, realnump, NULL); > + lvalp, addrp, realnump); > > if (*optimizedp) > break; > diff --git a/gdb/frame.h b/gdb/frame.h > index 9b41dd958fa4..b265c9bc5bb3 100644 > --- a/gdb/frame.h > +++ b/gdb/frame.h > @@ -685,14 +685,14 @@ const char *unwind_stop_reason_to_string (enum unwind_stop_reason); > const char *frame_stop_reason_string (const frame_info_ptr &); > > /* Unwind the stack frame so that the value of REGNUM, in the previous > - (up, older) frame is returned. If VALUEP is NULL, don't > + (up, older) frame is returned. If VALUEP is nullptr, don't > fetch/compute the value. Instead just return the location of the > value. */ > extern void frame_register_unwind (const frame_info_ptr &frame, int regnum, > int *optimizedp, int *unavailablep, > enum lval_type *lvalp, > CORE_ADDR *addrp, int *realnump, > - gdb_byte *valuep); > + gdb_byte *valuep = nullptr); > > /* Fetch a register from this, or unwind a register from the next > frame. Note that the get_frame methods are wrappers to > diff --git a/gdb/stack.c b/gdb/stack.c > index 73165c801343..2d6712ab16ba 100644 > --- a/gdb/stack.c > +++ b/gdb/stack.c > @@ -1750,7 +1750,7 @@ info_frame_command_core (const frame_info_ptr &fi, bool selected_frame_p) > /* Find out the location of the saved register without > fetching the corresponding value. */ > frame_register_unwind (fi, i, &optimized, &unavailable, > - &lval, &addr, &realnum, NULL); > + &lval, &addr, &realnum); > /* For moment, only display registers that were saved on the > stack. */ > if (!optimized && !unavailable && lval == lval_memory) Approved-By: Simon Marchi Simon