From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id 1829E385703A
 for <gdb-patches@sourceware.org>; Thu, 27 Aug 2020 02:03:35 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1829E385703A
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 93C591E009;
 Wed, 26 Aug 2020 22:03:34 -0400 (EDT)
Subject: Re: [PATCH] breakpoint.c: Fix advance/until and multiple locations
To: =?UTF-8?B?57SA6YeN56aV?= <demonic@csie.io>, gdb-patches@sourceware.org
References: <CA+YVB3TT=nrUthDkzPE66Bc0_FySVNEvTQ9P+sfT-FrqD_yeew@mail.gmail.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <27c4a444-3b72-3b00-ec23-5e6e9082d5e7@simark.ca>
Date: Wed, 26 Aug 2020 22:03:34 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <CA+YVB3TT=nrUthDkzPE66Bc0_FySVNEvTQ9P+sfT-FrqD_yeew@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: fr
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00, BODY_8BITS,
 KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Aug 2020 02:03:36 -0000

On 2020-08-26 11:06 a.m., 紀重禕 wrote:
> Fix bug 26524 <https://sourceware.org/bugzilla/show_bug.cgi?id=26524> ,
> iterate the sals variable to insert a breakpoint for each <location>
> 
> -- 
> Best regards,
> Chung-Yi Chi
> 

Hi,

I'm not sure the approach is right, since you end up creating multiple until_break_fsm
objects (one for each sal) and overwriting them.

Pedro Alves posted some patches fixing the same problem here:

  https://sourceware.org/pipermail/gdb-patches/2020-August/171427.html

which look good to me.  Could you please take a look at those?

Simon