From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-159232-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 43265 invoked by alias); 2 Oct 2019 15:51:05 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 43257 invoked by uid 89); 2 Oct 2019 15:51:05 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=
X-HELO: us-smtp-delivery-1.mimecast.com
Received: from us-smtp-1.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (207.211.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 02 Oct 2019 15:51:04 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;	s=mimecast20190719; t=1570031463;	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:	 content-transfer-encoding:content-transfer-encoding:	 in-reply-to:in-reply-to:references:references;	bh=3BOM7WGodvpVVp7vlBN52SJQC1vWhUtlYA46xXvAEd8=;	b=VpaGGOIdTGUuxcwv4ZBx7Hlz5J0uXNwYjpVgai9NwZ86twyiYPCFaNil4n0SG443vH2bxe	wqXPINHlcmBFWeoCgd6vCaHxoPDGu5tB2OZmHNIYFNg8k7R7rdlrXqW2uc4wkCNP8HuuyM	fdTdCP73N3Bo7lpxNfX5PADHzCFkS0w=
Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-119-Z4oVVXfsPWeRn3HtaPp_ng-1; Wed, 02 Oct 2019 11:51:00 -0400
Received: by mail-wm1-f71.google.com with SMTP id k9so3219904wmb.0        for <gdb-patches@sourceware.org>; Wed, 02 Oct 2019 08:51:00 -0700 (PDT)
Return-Path: <palves@redhat.com>
Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b])        by smtp.gmail.com with ESMTPSA id c10sm31491585wrf.58.2019.10.02.08.50.58        (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);        Wed, 02 Oct 2019 08:50:58 -0700 (PDT)
Subject: Re: [PATCHv5 3/3] gdb: Remove a use of VEC from dwarf2read.{c,h}
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches <gdb-patches@sourceware.org>
References: <cover.1569929785.git.andrew.burgess@embecosm.com> <8686aa422a9296daf14b844071a05fd443aea850.1569929786.git.andrew.burgess@embecosm.com>
Cc: Simon Marchi <simark@simark.ca>, Tom Tromey <tom@tromey.com>, markus.t.metzger@intel.com
From: Pedro Alves <palves@redhat.com>
Message-ID: <276f2a6f-f2bf-b0ac-fe74-8ea8dba36297@redhat.com>
Date: Wed, 02 Oct 2019 15:51:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <8686aa422a9296daf14b844071a05fd443aea850.1569929786.git.andrew.burgess@embecosm.com>
X-Mimecast-Spam-Score: 0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-SW-Source: 2019-10/txt/msg00064.txt.bz2

Hi,

On 10/1/19 12:42 PM, Andrew Burgess wrote:
> -  VEC (sig_type_ptr) *tus;
> +  std::vector <signatured_type *> *tus;

I skimmed this quickly and noticed that throughout the series
you're putting a space in "vector <", which is not the prevailing
style.

(I've really not looked at the patches in any detail beyond that.)

Thanks,
Pedro Alves