From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id TINxMoWUQ2QW7zIAWB0awg (envelope-from ) for ; Sat, 22 Apr 2023 04:02:13 -0400 Received: by simark.ca (Postfix, from userid 112) id C2D911E221; Sat, 22 Apr 2023 04:02:13 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=xAsrhcfl; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 714291E0D5 for ; Sat, 22 Apr 2023 04:02:13 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5D230385772A for ; Sat, 22 Apr 2023 08:02:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5D230385772A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1682150531; bh=iRGiIklDxALU3T6CzsWPtSYyOAxuShpXz/w5wG5+e+Y=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=xAsrhcfl/F1tHkQzszHmYjKqFlmIGHg/KvrWapUPguqgFAuoA93GazIjsQ0DhfBM0 hxpSuA4dkG2+Q0+if5BigRZ7hHlTySd0Xb9oAqLztUGc2hANoKvadXZLkqlizfrx3b X4FmAxqPbXrnGIGroBwyusdJCxq1A6u5n2ICkydY= Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 05BFD3858C83 for ; Sat, 22 Apr 2023 08:01:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 05BFD3858C83 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B9FE721983; Sat, 22 Apr 2023 08:01:47 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9E7E113499; Sat, 22 Apr 2023 08:01:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id QoGUJWuUQ2SZKgAAMHmgww (envelope-from ); Sat, 22 Apr 2023 08:01:47 +0000 Message-ID: <276f25d7-ab32-268f-0875-70cab6180e8d@suse.de> Date: Sat, 22 Apr 2023 10:01:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v3] gdb: Fix false match issue in skip_prologue_using_linetable Content-Language: en-US To: Kevin Buettner , Tom de Vries via Gdb-patches Cc: WANG Rui References: <20230418120939.29102-1-tdevries@suse.de> <1a4148e1-1376-3bc6-e398-4c611922c58f@suse.de> <20230421110346.7ca9b163@f37-zws-nv> In-Reply-To: <20230421110346.7ca9b163@f37-zws-nv> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 4/21/23 20:03, Kevin Buettner wrote: > Hi Tom, > > On Tue, 18 Apr 2023 14:15:06 +0200 > Tom de Vries via Gdb-patches wrote: > >> On 4/18/23 14:09, Tom de Vries via Gdb-patches wrote: >>> Co-Authored-By: WANG Rui (fix, tiny change [1]) >>> Co-Authored-By: Tom de Vries (test-case) >>> >>> [1] https://www.gnu.org/prep/maintain/html_node/Legally-Significant.html >> >> I'm not used to deal with these matters, so I'd appreciate some >> review/approval on this. Is my copyright status assessment correct, and >> did I write it up correctly? > > I refreshed my memory via the link you provided above. Based on what > is written there, I conclude that Wang Rui's change is not legally > signficant for copyright purposes. > > Also, I've looked over the Rui's patch as well as your test case, and > it looks good to me. So... > > Approved-by: Kevin Buettner > Hi Kevin, Thanks for review. Committed and also backported to gdb-13-branch, because it was a 12 -> 13 regression. Thanks, - Tom