From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2167 invoked by alias); 26 Jul 2012 12:47:36 -0000 Received: (qmail 2159 invoked by uid 22791); 26 Jul 2012 12:47:35 -0000 X-SWARE-Spam-Status: No, hits=-4.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Jul 2012 12:47:22 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1SuNTN-0002qt-Ju from Yao_Qi@mentor.com ; Thu, 26 Jul 2012 05:47:21 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Thu, 26 Jul 2012 05:47:21 -0700 Received: from qiyao.dyndns.org (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.1.289.1; Thu, 26 Jul 2012 05:47:20 -0700 From: Yao Qi To: CC: Tom Tromey , Subject: Re: [PATCH 3/6] attach to command_option-changed observer. Date: Thu, 26 Jul 2012 12:47:00 -0000 Message-ID: <2744162.LCmhzUq8J1@qiyao.dyndns.org> User-Agent: KMail/4.8.3 (Linux/3.3.7-1.fc16.i686; KDE/4.8.3; i686; ; ) In-Reply-To: <87pq7knayf.fsf@fleche.redhat.com> References: <1343146252-22558-1-git-send-email-yao@codesourcery.com> <1343146252-22558-4-git-send-email-yao@codesourcery.com> <87pq7knayf.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00611.txt.bz2 On Tuesday, July 24, 2012 02:47:04 PM Tom Tromey wrote: > Yao> + fprintf_unfiltered (mi->event_channel, > Yao> + "option-changed,option=3D\"%s\",value=3D\"%s\"", > Yao> + option, value); >=20 > This has a quoting bug. VALUE can contain characters requiring special > quoting for MI. >=20 > I once wrote a patch to change the event channel to use ui-out: >=20 > http://sourceware.org/ml/gdb-patches/2011-01/msg00518.html >=20 > That would be one way to deal with the problem, but there are probably > other ways as well. (I didn't commit that patch because Volodya had a > different approach to emitting the notifications that I was interested > in... but I still think it is a decent idea.) Hi, Tom, What is the different approach? I don't see any discussion in that thread. What should we do here? Shall we keep using ui-file (as what I wrote in th= is=20 patch) or migrate to ui-out with your patch applied? --=20 Yao (=E9=BD=90=E5=B0=A7)