From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9275 invoked by alias); 14 Feb 2017 21:25:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9222 invoked by uid 89); 14 Feb 2017 21:25:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=4.4 required=5.0 tests=AWL,BAYES_50,BODY_8BITS,GARBLED_BODY autolearn=no version=3.3.2 spammy=8:=d0=ba, 8:=d0=be, 8:=d0=b8, 8:=d0=bb?= X-HELO: server28.host.bg Received: from server28.host.bg (HELO server28.host.bg) (87.120.40.98) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 14 Feb 2017 21:25:27 +0000 Received: from [95.87.234.74] (port=36384 helo=tpdeb.localnet) by server28.host.bg with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.88) (envelope-from ) id 1cdkbD-002q0D-4p; Tue, 14 Feb 2017 23:25:23 +0200 From: Dimitar Dimitrov To: Mike Frysinger Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 1/2] PRU Simulator port Date: Tue, 14 Feb 2017 21:25:00 -0000 Message-ID: <2742027.O7fFqzyZ6y@tpdeb> User-Agent: KMail/5.2.3 (Linux/4.9.0-1-amd64; KDE/5.28.0; x86_64; ; ) In-Reply-To: <20170213053609.GF28432@vapier> References: <20161227212556.4214-1-dimitar@dinux.eu> <20170213053609.GF28432@vapier> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Get-Message-Sender-Via: server28.host.bg: authenticated_id: dimitar@dinux.eu X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00397.txt.bz2 Hi Mike, Thank you for the review. On =D0=BF=D0=BE=D0=BD=D0=B5=D0=B4=D0=B5=D0=BB=D0=BD=D0=B8=D0=BA, 13 =D1=84= =D0=B5=D0=B2=D1=80=D1=83=D0=B0=D1=80=D0=B8 2017 =D0=B3. 0:36:09 EET Mike Fr= ysinger wrote: > On 27 Dec 2016 23:25, Dimitar Dimitrov wrote: > > The corresponding libgloss changes have not yet been mainlined. > > The PRU patches are available here: > > https://github.com/dinuxbg/gnupru/tree/for-next/patches/newlib-cygwin >=20 > have you sent them to the mailing list ? i don't see them ... > https://sourceware.org/ml/newlib/ I have not sent the newlib patches yet. My understanding is that I should f= irst=20 mainline binutils and simulator, then GCC, and finally newlib. ... > > --- /dev/null > > +++ b/sim/pru/pru.h > >=20 > > +/* (void)0 is a guard against using RD as a left-hand side value. */ > > +#define RD (void)0; rd_is_modified =3D 1; _RDVAL >=20 > the standard way to handle (void)0 is with a do{...}while(0) loop I'll do it. >=20 > looks like you want to make a helper call macro anyways. something like > #define FOO(x) do { ...; _RDVAL =3D x; } while (0) My intention was to keep pru.isa simple and clear, resembling an ISA=20 specification. Compare RD =3D RS1 & OP2 to STORE_RD (RS1 & OP2) >=20 > also, RD depends on _RDVAL which only exists inside a single func. > this should be moved to interp.c i think for the one user. I'll do it. >=20 Regards, Dimitar