From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id VzKtAeFxeWFZFgAAWB0awg (envelope-from ) for ; Wed, 27 Oct 2021 11:36:01 -0400 Received: by simark.ca (Postfix, from userid 112) id F0BB61F0C1; Wed, 27 Oct 2021 11:36:00 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5E3A61E813 for ; Wed, 27 Oct 2021 11:36:00 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4371E3857C78 for ; Wed, 27 Oct 2021 15:35:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4371E3857C78 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1635348959; bh=kqTt7y6zs/4nbn5AxA5j7YKB8gLKnqQf1nyULzBbEtI=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=TAtAHFsuiCBq/kYLu0zkzMLgsL59+E0QSxzJONwOzns/Z8yFycOMlJdsxtLgFVQZf dfay8ZnCmXDOMO3hgbebXgjLjsy3uiMbHIP2zAOr6jDNt5xb2CwcJ3b5PCqFNyFLuS 45F4ypU7zZaBvwGEgq6Y+ER0ynPUniuiX5+5foH8= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 450FF3858419 for ; Wed, 27 Oct 2021 15:35:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 450FF3858419 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-358-7qiQwdYWM0Gi-uUqJPzoIQ-1; Wed, 27 Oct 2021 11:35:37 -0400 X-MC-Unique: 7qiQwdYWM0Gi-uUqJPzoIQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 90846802B52; Wed, 27 Oct 2021 15:35:36 +0000 (UTC) Received: from [10.3.114.141] (ovpn-114-141.phx2.redhat.com [10.3.114.141]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 565BA196F4; Wed, 27 Oct 2021 15:35:36 +0000 (UTC) Message-ID: <2730eb91-ede7-ea88-e9c9-709a69961e8e@redhat.com> Date: Wed, 27 Oct 2021 08:35:35 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH][gdb/testsuite] Fix port detection in gdb.debuginfod/fetch_src_and_symbols.exp To: Tom de Vries , gdb-patches@sourceware.org References: <20211027102405.GA6737@delia.home> In-Reply-To: <20211027102405.GA6737@delia.home> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Keith Seitz via Gdb-patches Reply-To: Keith Seitz Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 10/27/21 03:24, Tom de Vries wrote: > Hi, > > On OBS I ran into this failure with test-case > gdb.debuginfod/fetch_src_and_symbols.exp: > ... > Failed to listen for connections: Address already in use^M > [Thu Oct 21 11:48:49 2021] (559/559): started http server on IPv6 port=8000^M > ... > FAIL: gdb.debuginfod/fetch_src_and_symbols.exp: local_url: find port timeout > ... > > The test-case is trying to start debuginfod on a port to see if it's > available, and it handles either this message: > "started http server on IPv4 IPv6 port=$port" > meaning success, or: > "failed to bind to port" > meaning failure, in which case the debuginfod instance is killed, and we try > the next port. > > The test-case only uses the v4 address 127.0.0.1, so fix this by: > - accepting "started http server on IPv4 port=$port" > - rejecting "started http server on IPv6 port=$port" > > Tested on x86_64-linux. > > Any comments? When IPv6 is detected, the test case could set a variable to use ::1 instead of 127.0.0.1, but that would merely test the debuginfod client more than GDB itself, so I'd say this LGTM. Thank you for addressing this! Keith