From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37686 invoked by alias); 19 May 2016 13:07:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 37670 invoked by uid 89); 19 May 2016 13:07:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1569 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 19 May 2016 13:07:51 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1717C15567; Thu, 19 May 2016 13:07:50 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u4JD7mxo025118; Thu, 19 May 2016 09:07:49 -0400 Subject: Re: [PATCH] Fix invalid implicit conversions from void * To: Andreas Schwab , gdb-patches@sourceware.org References: From: Pedro Alves Message-ID: <27288423-ea78-4bd7-6eb2-68911a275690@redhat.com> Date: Thu, 19 May 2016 13:07:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-05/txt/msg00322.txt.bz2 On 05/19/2016 01:54 PM, Andreas Schwab wrote: > Tested on ia64-suse-linux. Thanks. > > * ia64-libunwind-tdep.c (libunwind_descr): Add cast from void *. > (libunwind_frame_set_descr): Likewise. > (libunwind_frame_cache): Likewise. > (libunwind_frame_dealloc_cache): Likewise. > (libunwind_frame_sniffer): Likewise. > (libunwind_search_unwind_table): Likewise. > (libunwind_sigtramp_frame_sniffer): Likewise. > (libunwind_get_reg_special): Likewise. > (libunwind_load): Likewise. > * ia64-linux-nat.c (ia64_linux_fetch_register): Likewise. > (ia64_linux_store_register): Likewise. > (ia64_linux_xfer_partial): Likewise. > * ia64-tdep.c (ia64_access_reg): Likewise. > (ia64_access_fpreg): Likewise. > (ia64_access_rse_reg): Likewise. > (ia64_access_rse_fpreg): Likewise. This is OK. Though ... > /* Initialize pointers to the dynamic library functions we will use. */ > > - unw_get_reg_p = dlsym (handle, get_reg_name); > + unw_get_reg_p = ((int (*) (unw_cursor_t *, unw_regnum_t, unw_word_t *)) > + dlsym (handle, get_reg_name)); ... I think would be nicer to use typedefs for these. Something like, at the top: -static int (*unw_get_reg_p) (unw_cursor_t *, unw_regnum_t, unw_word_t *); +typedef int (unw_get_reg_p_ftype) (unw_cursor_t *, unw_regnum_t, unw_word_t *); +static unw_get_reg_p_ftype *unw_get_reg_p; etc. and then: unw_get_reg_p = (unw_get_reg_p_ftype *) dlsym (handle, get_reg_name); It's what we've done in other similar cases, like linux-thread-db.c, for example. Thanks, Pedro Alves