Re: [PATCH 0/4] OpenRISC binutils updates and new relocs

Nick Clifton
2018-09-17T15:07:51Z

Hi Stafford,

> Does anyone have concerns with these patches? Mostly they are for openrisc
> parts only.

Sorry for the long silence - I have been very busy of late.

The patch series looks basically fine to me, so I have no concerns there.
There are a few minor formatting glitches, but nothing serious.

I do not see any need to add extra document for the new relocs, unless you
have created new assembler pseudo-ops to generate them. (I did not see any
code to add such operators, but I may have missed something).

I do have one question though. Is there a need to be able to distinguish
between binaries that use the new l.adrp instruction and those that don't.
For example if a library is built using the new instruction but then it is
linked into an executable which is supposed to run on silicon which does
not support the new instruction, should the linker issue an error ? If so,
how does it detect this situation ?

Cheers
Nick