From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4nfLD9zziGOOER8AWB0awg (envelope-from ) for ; Thu, 01 Dec 2022 13:35:08 -0500 Received: by simark.ca (Postfix, from userid 112) id 332D51E124; Thu, 1 Dec 2022 13:35:08 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=Qid3WQYP; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DA3911E0D3 for ; Thu, 1 Dec 2022 13:35:07 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 14534385842C for ; Thu, 1 Dec 2022 18:35:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 14534385842C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1669919707; bh=FfAI+QNqzNHY3cqRztuHctsCMHfWn9LhG1XZLCC5p3U=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=Qid3WQYPPSZSgiz3KtLiUMwy8lPuFpu6EmbhEf/F8VPNmQvNdr+WsX5mMpSn6Gt2H BSpJnw8kqYERSGIT3svUwQCwjm1AOMpcf01e9S+sgwxWgro6KkoHES43v/1MthAPFM nUU2GX7KokUUSUue34mGDOXnua0usd6YUHYTCbMA= Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 110D03858D32 for ; Thu, 1 Dec 2022 18:34:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 110D03858D32 Received: from [172.16.0.64] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 6775C1E0D3; Thu, 1 Dec 2022 13:34:47 -0500 (EST) Message-ID: <2715d293-122f-10ff-e631-38b9c9a70562@simark.ca> Date: Thu, 1 Dec 2022 13:34:46 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH] Remove call to registers_changed from windows-nat.c Content-Language: fr To: Tom Tromey , gdb-patches@sourceware.org References: <20221201182857.2591740-1-tromey@adacore.com> In-Reply-To: <20221201182857.2591740-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 12/1/22 13:28, Tom Tromey via Gdb-patches wrote: > I noticed that windows_nat_target::interrupt calls registers_changed. > However, I don't think there's any reason to do this, because this > will happen automatically when the inferior stop is processed. > --- > gdb/windows-nat.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c > index 17422e15f80..4b0760c5804 100644 > --- a/gdb/windows-nat.c > +++ b/gdb/windows-nat.c > @@ -2881,7 +2881,6 @@ windows_nat_target::interrupt () > DEBUG_EVENTS ("GenerateConsoleCtrlEvent (CTRLC_EVENT, 0)"); > CHECK (GenerateConsoleCtrlEvent (CTRL_C_EVENT, > windows_process.current_event.dwProcessId)); > - registers_changed (); /* refresh register state */ > } > > /* Helper for windows_xfer_partial that handles memory transfers. > -- > 2.34.3 > Makes sense to me, Approved-By: Simon Marchi Simon