From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id p2mdIcMc72VtjQIAWB0awg (envelope-from ) for ; Mon, 11 Mar 2024 11:01:23 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=GV+ysnOx; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 77C611E0D2; Mon, 11 Mar 2024 11:01:23 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 616BC1E0AC for ; Mon, 11 Mar 2024 11:01:21 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D9D9B385828D for ; Mon, 11 Mar 2024 15:01:20 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 994F13858CD1 for ; Mon, 11 Mar 2024 15:00:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 994F13858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 994F13858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710169259; cv=none; b=hhwiqRZIPjlnnYU/hE0KGYfuZNJ6ifuxkeqpdKptIwPqnS+KXIen8YYsXUvGaVS/PfIKqF1Xq/Ct1F9EZrS631iXMzR5LjoCDdZd4I1SkjGODTBAqb+nfBhfOfyNr6b3IVeW9n7o4pssW0/Rdl4dSclrAuRW9bYOsKHkB8g7jxE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710169259; c=relaxed/simple; bh=ApckGFvVTDDdeAm00uuX0SHJFqGzpmo5LdPS7/gK+ko=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=gQhcJo/+Dmt1JTZJcK27Kbq8zPk+bn3Q0aU0I6xV9wUVYbb0davSsjwvj7scnZAjww7SmHOKxU/h7Lz4AIt/XV6LwTvVMCimG9FB26/X3noU6DmoMTHsqvvChlKndyj4nOkjiZQENFUE15dDgFGGFSdiuoNvHensMvfVBqipJt8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710169257; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p+MW+OtROL5ZGmMIPJ5SbP4DGdr9lrPJMPY07d/zW+M=; b=GV+ysnOxLljREP4YC9vHkVkcRjQoAaNenG2YjxrGHK7Rg+Dl9bQcT5yrHv2Us0TZg64kQN DEOo4sx2Lgj7M1Ua9M+wrLfq+p8BS3B3BzFamrRWWpxddgItjAe5CzpK/WB+bW9ANbUHKN 5gIdTcIzhwHRGLT2W2pSxDWuVBHTt5w= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-587-cOIDk-U0OH2xtypvh3BR6w-1; Mon, 11 Mar 2024 11:00:55 -0400 X-MC-Unique: cOIDk-U0OH2xtypvh3BR6w-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-a456c9d0717so211700066b.3 for ; Mon, 11 Mar 2024 08:00:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710169252; x=1710774052; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=p+MW+OtROL5ZGmMIPJ5SbP4DGdr9lrPJMPY07d/zW+M=; b=HmfuuOzverIDk2i8/O7pRIjt/tNuSUvMiWZbdgo9aI6+Nl6NfYrWhhvJkMgCsRpgWA 1gcNob83XVx5AN+ARMeHBtvOypH+nZR5YIrzQ985DL5orzk6TsZw3n807T8+vXuJWram fWIpDmcayKowZcctfBstni/iojHy9/x1G7OFfCqE4ceQR7k5qbUVp9aJnMFh3m6ed2sD y6pcI8ksXr6gFQ0iOh2RD4wXWDFPxnDX0cyVIy5QhWOaNs7hkc7Ih1BafHuDAwcMg8IQ 7EbDFwDMQQmqbb5ES6H+EXQkP8YdP/s3au6yUY80NIzjWd3YosmUdH9ZPtOZo+298u5C 8xLg== X-Forwarded-Encrypted: i=1; AJvYcCU4k3SfiPmpUaB26jhVF0riEFlHe60FJrFj5mkTJaOJMeK51l1+J2dlb16gdKvq/seUseqd1kT+9tZQKr0qqRDlU+TdrLHPxvkhyg== X-Gm-Message-State: AOJu0YxYFYYIC0uwrb1esk0193ukuDZXZXelRLBvO1rIN+WjZcby/p9Y V1e9c/9DSOMDJCZzYhxMJdu+ysBEMGAyLxxh8KZzs9zL0xs/iNc0DWVzVI/Wx6xUkXOme69qC/V +olZTzLvrrj3cadxEYN+qo7kIkuhytDmr2hwUhOWx5y0oAFEjZKvIzlUZJtNs9UySqd0= X-Received: by 2002:a17:907:daa:b0:a46:35c9:f239 with SMTP id go42-20020a1709070daa00b00a4635c9f239mr519097ejc.72.1710169252695; Mon, 11 Mar 2024 08:00:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFITqlVnqVK8xif8DT8RdvH14sky4CPQxY3QVa3cJKPrP/ixmr1YqAB4uX8N2b59zBDJDE9pg== X-Received: by 2002:a17:907:daa:b0:a46:35c9:f239 with SMTP id go42-20020a1709070daa00b00a4635c9f239mr519061ejc.72.1710169251990; Mon, 11 Mar 2024 08:00:51 -0700 (PDT) Received: from [192.168.0.129] (ip-94-112-227-180.bb.vodafone.cz. [94.112.227.180]) by smtp.gmail.com with ESMTPSA id lt9-20020a170906fa8900b00a45c4d3ee11sm2920693ejb.123.2024.03.11.08.00.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Mar 2024 08:00:51 -0700 (PDT) Message-ID: <2702cb98-2bc0-40fb-a871-a10aa1aeb0f7@redhat.com> Date: Mon, 11 Mar 2024 16:00:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/4] Modernize frame unwinders and add disable feature To: Luis Machado , gdb-patches@sourceware.org References: <20240306125135.766567-1-blarsen@redhat.com> <47e1bce0-1f4f-4ac4-b101-a2496a51cbe8@arm.com> From: Guinevere Larsen In-Reply-To: <47e1bce0-1f4f-4ac4-b101-a2496a51cbe8@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, WEIRD_PORT autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 11/03/2024 15:56, Luis Machado wrote: > Hi, > > On 3/6/24 12:51, Guinevere Larsen wrote: >> This patch series started with me trying to make it easier to test GDB's >> ability to unwind using CFI data, to improve a previous patch I sent to >> the list. However, once I finished these changes, I realized there was >> an unrelated bug I should fix before proposing the CFI test. Since these >> changes are significant enough already, and I think would be interesting >> on their own, I figured I shoudl submit this patch series as is right >> now while I figure out the other bug. >> >> The first patch is just a minor change, storing frame unwinders in a >> vector instead of through an unwinder table accessible using the >> registry system. This isn't required (like I originally thought it was), >> but it does make the whole system more readable in my opinion. >> >> Patch 3 has the real meat of the modernization, making GDB use >> polymorphism to handle frame unwinders. This is slightly slower than >> using function pointers, but much more readable in my opinion. >> >> As for the unwinder classes, they were chosen somewhat arbitrarily, >> mostly based on where I found an unwinder and its name. I almost expect >> some unwinders to be mis-categorized, but that should be easy to fix. >> >> The changes up to patch 3 have been tested with a try-branch, no >> regressions as far as I could see. >> >> Guinevere Larsen (4): >> gdb: make gdbarch store a vector of frame unwinders >> gdb: add "unwinder class" to frame unwinders >> gdb: Migrate frame unwinders to use C++ classes >> GDB: introduce ability to disable frame unwinders > I haven't gone through the series in detail, but I thought I'd give it a try on one of the > aarch64 machines I have access to. I didn't look particularly healthy: > > > # of unexpected core files 47 > # of expected passes 116521 > # of unexpected failures 581 > # of expected failures 77 > # of known failures 116 > # of untested testcases 128 > # of unresolved testcases 1102 > # of unsupported tests 458 > # of duplicate test names 10 > > I see a number of internal errors going on. Mostly like these: > > ../../../repos/binutils-gdb/gdbsupport/errors.cc:58 > 0xaaaad27e7877 check_ptrace_stopped_lwp_gone > ../../../repos/binutils-gdb/gdb/linux-nat.c:1634 > 0xaaaad27e7877 check_ptrace_stopped_lwp_gone > ../../../repos/binutils-gdb/gdb/linux-nat.c:1630 > 0xaaaad2ae0fa3 linux_resume_one_lwp > Oh no! Linaro CI had showed something was wrong, but I wasn't able to grab an aarch64 machine to test yet. I'll check it out when I can, thanks for narrowing it down for me -- Cheers, Guinevere Larsen She/Her/Hers