From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id r9AjCfLZdWok1RAAWB0awg (envelope-from ) for ; Fri, 07 Aug 2026 09:13:22 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=AdEydk8T; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 115011E09B; Fri, 07 Aug 2026 09:13:22 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 470E91E09B for ; Fri, 07 Aug 2026 09:13:20 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 974964BB591A for ; Fri, 7 Aug 2026 13:13:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 974964BB591A Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=AdEydk8T Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id CC0D44BB58A6 for ; Fri, 7 Aug 2026 12:54:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CC0D44BB58A6 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CC0D44BB58A6 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786107297; cv=none; b=OP3rvDi5G12Mp9BodcQpW/B+gsQoN9PwcLCMNmHjRjcWEbVAJLMmOPutybt83eG5jP1olqh3X5IULfcujGv3syKecIrk1wcJgsXU6YyVlwNi8aqe0Akl05YhCCoHLlEXyEr0utavm85Wx4bKNCkBckoeQX8J1IQ6wE4iuWhbO3A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786107297; c=relaxed/simple; bh=6i3xEmtroHTcQypRZ+wJWwikjFtQtw98AU4qKM2xVm8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=U1RNuFHdq3hBPJiGtjxfiWFDLpGunHJ0B3g3n4MjE3yqwWQwWPsBKhuxGznaWsXKC/wjnnipUtulqARsfGt9QGacSYEdUEsozHz6l+T2/s5DQfa+p3yJVe3CTb/3JmFU3r4o8PCWk5koXiy/8f+yh8Rh8XVK0wPzDZRT1eYFs4Q= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=AdEydk8T DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CC0D44BB58A6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786107297; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4tV4X+0YO1rqqX2NPpK25bqYo9nQI+gS+d9GlLZzOKw=; b=AdEydk8TRDmkCSEp12w1fDZrj67jqp/JSkpommKx1wQ+j+q/MalCSaDE4t29oiXxRFSX1j T3Hvjh7Mj5p52jpqQ8mF06Tm0AyKuQ6PMcSg6TIGBRsiSKGRDREhacZ84uEHAV61W7zook OXzQ0KFNv73MZkpMLUYOAl1bIdPa9J0= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-622-CifjcSYJM9aD1eLuFuCvJw-1; Fri, 07 Aug 2026 08:54:51 -0400 X-MC-Unique: CifjcSYJM9aD1eLuFuCvJw-1 X-Mimecast-MFC-AGG-ID: CifjcSYJM9aD1eLuFuCvJw_1786107291 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-52ce64c41efso56139901cf.3 for ; Fri, 07 Aug 2026 05:54:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786107291; x=1786712091; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4tV4X+0YO1rqqX2NPpK25bqYo9nQI+gS+d9GlLZzOKw=; b=MrVRRj36mrGADUQ7UkSb/rSzsOJn/P6mabqaVcyrumUEjWYB/ixURndEncB6rM0avN YWoRdP6PMVqHZOriamHV4siCbvN2cTy/nDl7avuaGDZpIciLyyoVZDBSMAMGbFN6Fp3c JXIm8hmmFldpa5ENcJ5M9TYlNwYs/jefiS8/SZSmHRpPRLS7f3M4frhvIkCzXuztds+U GhuikYNZ2mqQEGuKYaHjCsKY5vweCChHvtQ9rsyCZVS7c0g7pxwxMFERumwwaIITbvfO n5kJ+05KDUwqgPlV+BAcmX5jwKDA0R7DyIweS7+CHoTv0/uhXqM0x/jInYc57Zyi4aR/ 8E4w== X-Forwarded-Encrypted: i=1; AHgh+Rrc8NZ1cRViTctubGG236RsjXrRt8DupXQ8a4iZAIp4Lc/nNkbo4PoIbMUgicqTwRwwgkmnQ6cDZo8s7w==@sourceware.org X-Gm-Message-State: AOJu0Yxswq68V/u8uypdAfXEQ8l56KVkEEgZD3Ky02Whjt3hrHyMvPn4 KrOznbFmtyDTT1A5OjofkXpV7uMJkLET6g+4829bo4C8WZ8AU4R33DddmRlnw4lYVeF1eYuKoka E6/ZIkjNyM/ZuNZvBWXwC4Qb9IEdSf35bJW/brk2hHZz8B056aIb430k6GrMeF88= X-Gm-Gg: AR+sD13GBxezm8eZX8GUOs70mC7MV4tmEXro2ay7mLkVEUre3goplRHQcygqQQ7dNQ6 vzvztIxxHdlmr3Px/SnQKvMg7hIkWFJcmUvxcLTS9MzEChyhK4M/wg7baP4u5JAFZ9M5NVW8iFb PIkKY/nxdQ5XB1V4yBDFxIdZC/VphzDUIaFY9b5fPilLVBD5rhtYK+zvgmuvVGPkgVXfT29yvol s2WkdmYf+l9QMOL96h/ZB0qyfsrD6t9hW7IFxFlOwgngwRsHVCBpaOGKITAm1MV57yVNJ5A3IrE Moz32unLubflGj7arH57TlIyGtY1FnowI2jtCMsVZAHxBxrpDBQDpMQBsHLD/+FfSL71Yjegq9e zZCuNJwnjAA== X-Received: by 2002:a05:622a:4890:b0:519:f884:b587 with SMTP id d75a77b69052e-52ce6113a49mr243116621cf.27.1786107290690; Fri, 07 Aug 2026 05:54:50 -0700 (PDT) X-Received: by 2002:a05:622a:4890:b0:519:f884:b587 with SMTP id d75a77b69052e-52ce6113a49mr243116131cf.27.1786107290158; Fri, 07 Aug 2026 05:54:50 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:993e::75d? ([2804:14d:8084:993e::75d]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-52d165a09d0sm11169911cf.17.2026.08.07.05.54.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Aug 2026 05:54:49 -0700 (PDT) Message-ID: <26fa5df9-54b3-4b80-aed0-16eba3621a3c@redhat.com> Date: Fri, 7 Aug 2026 09:54:46 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] Drop use of bfd_boolean from findcmd.c To: Tom Tromey , gdb-patches@sourceware.org References: <20260307-no-bfd-boolean-v1-0-186424bf8238@tromey.com> <20260307-no-bfd-boolean-v1-3-186424bf8238@tromey.com> From: Guinevere Larsen In-Reply-To: <20260307-no-bfd-boolean-v1-3-186424bf8238@tromey.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: QYGKGM36b5yBhl6GSboBTPJgYEp7bdFlOAs8amqMzv4_1786107291 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/7/26 3:20 PM, Tom Tromey wrote: > This changes findcmd.c to remove the use of bfd_boolean. Instead, the > byte order is used directly. put_bits is also rewritten in terms of > store_unsigned_integer. > --- > gdb/findcmd.c | 33 +++++++++++++-------------------- > 1 file changed, 13 insertions(+), 20 deletions(-) > > diff --git a/gdb/findcmd.c b/gdb/findcmd.c > index c4ee0ec97e4..b52c44d48d0 100644 > --- a/gdb/findcmd.c > +++ b/gdb/findcmd.c > @@ -24,27 +24,20 @@ > #include "cli/cli-utils.h" > #include > #include "gdbsupport/byte-vector.h" > +#include "extract-store-integer.h" > > -/* Copied from bfd_put_bits. */ > +/* Append DATA to BUF, writing only the specified number of bits, > + using the given endian-ness. */ I think that this comment should probably specify that it should be an integer number of bytes, because I thought you could have like 9 bits and was wondering how the code managed that (I misread the diff thinking the assert was removed). > > static void > -put_bits (uint64_t data, gdb::byte_vector &buf, int bits, bfd_boolean big_p) > +put_bits (uint64_t data, gdb::byte_vector &buf, int bits, > + bfd_endian byte_order) > { > - int i; > - int bytes; > - > gdb_assert (bits % 8 == 0); > - > - bytes = bits / 8; > + int bytes = bits / 8; > size_t last = buf.size (); > buf.resize (last + bytes); > - for (i = 0; i < bytes; i++) > - { > - int index = big_p ? bytes - i - 1 : i; > - > - buf[last + index] = data & 0xff; > - data >>= 8; > - } > + store_unsigned_integer (&buf[last], bytes, byte_order, data); > } > > /* Subroutine of find_command to simplify it. > @@ -53,7 +46,7 @@ put_bits (uint64_t data, gdb::byte_vector &buf, int bits, bfd_boolean big_p) > static gdb::byte_vector > parse_find_args (const char *args, ULONGEST *max_countp, > CORE_ADDR *start_addrp, ULONGEST *search_space_lenp, > - bfd_boolean big_p) > + bfd_endian byte_order) > { > /* Default to using the specified type. */ > char size = '\0'; > @@ -171,13 +164,13 @@ parse_find_args (const char *args, ULONGEST *max_countp, > pattern_buf.push_back (x); > break; > case 'h': > - put_bits (x, pattern_buf, 16, big_p); > + put_bits (x, pattern_buf, 16, byte_order); > break; > case 'w': > - put_bits (x, pattern_buf, 32, big_p); > + put_bits (x, pattern_buf, 32, byte_order); > break; > case 'g': > - put_bits (x, pattern_buf, 64, big_p); > + put_bits (x, pattern_buf, 64, byte_order); > break; > } > } > @@ -210,7 +203,7 @@ static void > find_command (const char *args, int from_tty) > { > struct gdbarch *gdbarch = get_current_arch (); > - bfd_boolean big_p = gdbarch_byte_order (gdbarch) == BFD_ENDIAN_BIG; > + bfd_endian byte_order = gdbarch_byte_order (gdbarch); > /* Command line parameters. > These are initialized to avoid uninitialized warnings from -Wall. */ > ULONGEST max_count = 0; > @@ -223,7 +216,7 @@ find_command (const char *args, int from_tty) > gdb::byte_vector pattern_buf = parse_find_args (args, &max_count, > &start_addr, > &search_space_len, > - big_p); > + byte_order); > > /* Perform the search. */ > > -- Cheers, Guinevere Larsen it/its she/her (deprecated)