From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id 96DF43851C18
 for <gdb-patches@sourceware.org>; Wed, 13 May 2020 14:39:46 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 96DF43851C18
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [10.0.0.193] (unknown [192.222.164.54])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 732D61E5F9;
 Wed, 13 May 2020 10:39:45 -0400 (EDT)
Subject: Re: [PATCH v4 1/9] gdb: Move construct_inferior_arguments to
 gdbsupport
To: Michael Weghorn <m.weghorn@posteo.de>, gdb-patches@sourceware.org
References: <20200429111638.1327262-1-m.weghorn@posteo.de>
 <20200513094758.523845-1-m.weghorn@posteo.de>
From: Simon Marchi <simark@simark.ca>
Message-ID: <26f19ec4-5dad-263a-48b5-0398d5f3b63c@simark.ca>
Date: Wed, 13 May 2020 10:39:44 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200513094758.523845-1-m.weghorn@posteo.de>
Content-Type: text/plain; charset=utf-8
Content-Language: tl
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 13 May 2020 14:39:47 -0000

On 2020-05-13 5:47 a.m., Michael Weghorn via Gdb-patches wrote:
> This moves the function construct_inferior_arguments from
> gdb/inferior.h and gdb/infcmd.c to gdbsupport/common-inferior.{h,cc}.
> While at it, also move the function's comment to the header file
> to align with current standards.
> 
> The intention is to use it from gdbserver in a follow-up commit.

Hi Michael,

The series LGTM.  I think all we need now is to wait for your copyright assignment to
be completed?

Simon