From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-162273-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 54436 invoked by alias); 15 Dec 2019 02:34:34 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 54428 invoked by uid 89); 15 Dec 2019 02:34:34 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-5.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=
X-HELO: simark.ca
Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 15 Dec 2019 02:34:33 +0000
Received: from [10.0.0.11] (unknown [192.222.164.54])	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)	 key-exchange X25519 server-signature RSA-PSS (2048 bits))	(No client certificate requested)	by simark.ca (Postfix) with ESMTPSA id 76BB51E05A;	Sat, 14 Dec 2019 21:34:31 -0500 (EST)
Subject: Re: [PATCH v2 (w/ ChangeLog)] Fix disabling of solib probes when LD_AUDITing
To: George Barrett <bob@bob131.so>
Cc: gdb-patches@sourceware.org
References: <1ehh33uyr5gra7_h9krnpznz2jqsjw_4593wafg.zlb1mgays0ef@mail.bob131.so> <d0710295-6990-a09d-ab1a-a4b7c7b8f271@simark.ca> <vnl1us&q633xj/qr5dhob5hfdv65h5n-0uh055zf8h9qq36rx_rh@mail.bob131.so>
From: Simon Marchi <simark@simark.ca>
Message-ID: <26aea033-693f-c3d6-30c7-b87b1dbc9672@simark.ca>
Date: Sun, 15 Dec 2019 02:34:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0
MIME-Version: 1.0
In-Reply-To: <vnl1us&q633xj/qr5dhob5hfdv65h5n-0uh055zf8h9qq36rx_rh@mail.bob131.so>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2019-12/txt/msg00681.txt.bz2

On 2019-12-14 9:33 p.m., George Barrett wrote:
> On Sat, Dec 14, 2019 at 09:30:43PM -0500, Simon Marchi wrote:
>> Catch the exception by reference:
>>
>>   catch (const gdb_exception_error &)
>>
>> I can push your patch with this fixed, if you agree (and others think the
>> patch is fine too).
> 
> Yes, that's fine by me.
> 
> Thanks
> 

Ok, I'd like to leave a bit of time for others to comment, so please
ping in a week or so if there hasn't been any other activity, I'll merge
it then.

Simon