From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28220 invoked by alias); 6 Mar 2019 21:14:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28173 invoked by uid 89); 6 Mar 2019 21:14:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=0.8 required=5.0 tests=BAYES_00,DNS_FROM_AHBL_RHSBL,RCVD_IN_DNSWL_NONE,TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.1 spammy=HX-Spam-Relays-External:2001 X-HELO: mail-wm1-f65.google.com Received: from mail-wm1-f65.google.com (HELO mail-wm1-f65.google.com) (209.85.128.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Mar 2019 21:14:12 +0000 Received: by mail-wm1-f65.google.com with SMTP id f65so7289504wma.2 for ; Wed, 06 Mar 2019 13:14:12 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:4c97:6d52:2cea:997b? ([2001:8a0:f913:f700:4c97:6d52:2cea:997b]) by smtp.gmail.com with ESMTPSA id p1sm4645018wrx.50.2019.03.06.13.14.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Mar 2019 13:14:09 -0800 (PST) Subject: Re: [PATCH v2 10/22] Remove last cleanups from stabsread.c To: Tom Tromey , gdb-patches@sourceware.org References: <20190227201849.32210-1-tom@tromey.com> <20190227201849.32210-11-tom@tromey.com> From: Pedro Alves Message-ID: <264d12c8-b73b-07b7-3c6a-406fb49651f9@redhat.com> Date: Wed, 06 Mar 2019 21:14:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190227201849.32210-11-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-03/txt/msg00125.txt.bz2 On 02/27/2019 08:18 PM, Tom Tromey wrote: > This removes the last cleanups from stabsread.c. Similar code in > dwarf2read.c was C++-ified, but considering that stabs are deprecated, > it seemed simpler to just change these allocations to use an obstack > and leave the data structures in place. > > This patch renames field_info to stabs_field_info -- adding a > constructor here provoked a bug due to the resulting ODR violation. > > gdb/ChangeLog > 2019-02-27 Tom Tromey > > * stabsread.c (struct stabs_field_info): Rename from field_info. > : Add initializers. > : New member. > (read_member_functions, read_struct_fields, read_baseclasses): > Allocate on obstack. Don't use cleanups. > (read_one_struct_field, read_member_functions, read_struct_fields) > (read_baseclasses, read_tilde_fields, attach_fn_fields_to_type) > (attach_fields_to_type, read_cpp_abbrev, read_member_functions) > (read_struct_type): Update. LGTM. Thanks, Pedro Alves