From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55014 invoked by alias); 5 Oct 2017 17:08:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54999 invoked by uid 89); 5 Oct 2017 17:08:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=afternoon, Hx-languages-length:1056 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Oct 2017 17:08:11 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 840E8C059B77; Thu, 5 Oct 2017 17:08:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 840E8C059B77 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id CEBAC600C8; Thu, 5 Oct 2017 17:08:09 +0000 (UTC) Subject: Re: [PATCH 3/3] Fix "Remote 'g' packet reply is too long" problems with multiple inferiors To: Ulrich Weigand References: <20171005165012.0528CD835F0@oc3748833570.ibm.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <262f59c2-3507-efa1-1196-a06449b9338c@redhat.com> Date: Thu, 05 Oct 2017 17:08:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20171005165012.0528CD835F0@oc3748833570.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-10/txt/msg00117.txt.bz2 On 10/05/2017 05:50 PM, Ulrich Weigand wrote: > Pedro Alves wrote: > >> * target.c (default_thread_architecture): Use the sepecified >> inferior's architecture, instead of the current inferior's >> architecture (via target_gdbarch). > > This causes a number of ICEs in the test suite for me, at the point when > default_thread_architecture is called from linux_child_follow_fork here: > > if (!gdbarch_software_single_step_p (target_thread_architecture > (child_lp->ptid))) > > Note that at this point there is no inferior for the child, and I think > there will never be one since the child is to be detached immediately. > > Given that this is a fork, I guess a simple fix would be to check > for the parent's thread architecture here instead. Indeed, sorry about that. I noticed this too this afternoon, and wrote a fix just like you suggest and was just waiting for a test run to complete. Results look good, so I'll push it in in a bit. Thanks, Pedro Alves