From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76785 invoked by alias); 11 Nov 2016 03:24:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76762 invoked by uid 89); 11 Nov 2016 03:24:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 11 Nov 2016 03:24:35 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C57A8C00C91C; Fri, 11 Nov 2016 03:24:34 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAB3OXL0028325; Thu, 10 Nov 2016 22:24:34 -0500 Subject: Re: [RFA 16/20] Use gdbpy_enter in gdbpy_get_matching_xmethod_workers To: Tom Tromey References: <1478816387-27064-1-git-send-email-tom@tromey.com> <1478816387-27064-17-git-send-email-tom@tromey.com> <8356ffb0-722d-c6fb-c063-e18c24b3ccab@redhat.com> <877f8ak8ne.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <262f178f-1b4e-df0d-a06c-db320fcf8c34@redhat.com> Date: Fri, 11 Nov 2016 03:24:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <877f8ak8ne.fsf@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00283.txt.bz2 On 11/11/2016 03:17 AM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > >>> - Py_DECREF (temp); >>> - Py_DECREF (pspace_matchers); > > Pedro> I'm a little confused here. Don't we still need to account for > Pedro> these two Py_DECREFs? > > The patch reads a little messily. The new code is: > > gdbpy_reference pspace_matchers (pspy_get_xmethods (py_progspace, NULL)); > > gdbpy_reference temp (PySequence_Concat (py_xmethod_matcher_list.get (), > pspace_matchers.get ())); > if (temp == NULL) > { > gdbpy_print_stack (); > return EXT_LANG_RC_ERROR; > } > > py_xmethod_matcher_list = temp; > > So the decrefs are accounted for by the destructors; and that assignment > at the end encodes an incref via the copy constructor. Moving here > would have been a valid choice as well, like: Ah, I see. > > py_xmethod_matcher_list = std::move (temp); > > ... though I deleted the move constructor since it wasn't used in the > earlier series and Jan pointed out that it had a bug. As per my comment on the other patch, I think that's a mistake though. Thanks, Pedro Alves