From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32599 invoked by alias); 18 Jul 2018 14:02:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32586 invoked by uid 89); 18 Jul 2018 14:02:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:ip*15.20.973.16 X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Jul 2018 14:02:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1531922515; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=xWbHJsTTAseWeoLH0o41LXMGjYl1JFfoQMWVZwQ/TTQ=; b=EyT/KT7arX2xSWoJhE7zUetJQOwyhGcdHDQWUUy1rQ4hY4ZT5lBmi91e83SFptkO EnZbQsyxCMUoUPwklekBklfpRv3sj+bD4UAoYEDwB724RDkBNlt+/Ui9KIgVi1sc ezB16LNjUjJpa49NtBU7gSFOZIfrPVXIdJppGrRosMw=; Received: from ESESSMB502.ericsson.se (Unknown_Domain [153.88.183.120]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id A2.28.22978.3584F4B5; Wed, 18 Jul 2018 16:01:55 +0200 (CEST) Received: from ESESSMB501.ericsson.se (153.88.183.162) by ESESSMB502.ericsson.se (153.88.183.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 18 Jul 2018 16:01:53 +0200 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Wed, 18 Jul 2018 16:01:53 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ez1PZKoyflCJ+CkEkQXHqb4cv8FuSSfraPCWqXV3UwA=; b=mePUsbbD7BFjw7bYC8/4u/tqK/qR0aVWltemVaLEc0WWcK6XFhLOXWDG6LTeIPUpU1ghAh6GgtE/o9Qp67rupqc0o2yRTwzJrB1aINBLY9qpAVlfQxFeUsFBlKxf2MZBqSditu74HpC+ZFfeO54NqTSLWpPKjwDoCY9eibb8LOk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [10.0.0.110] (192.222.164.54) by SN6PR15MB2397.namprd15.prod.outlook.com (2603:10b6:805:24::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.16; Wed, 18 Jul 2018 14:01:49 +0000 Subject: Re: [RFA 09/15] Introduce class psymtab_storage To: Tom Tromey , References: <20180510222357.27332-1-tom@tromey.com> <20180510222357.27332-10-tom@tromey.com> From: Simon Marchi Message-ID: <261cfcfe-ae3d-1aad-7671-736be1a34e7b@ericsson.com> Date: Wed, 18 Jul 2018 14:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180510222357.27332-10-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-Path: simon.marchi@ericsson.com Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00543.txt.bz2 On 2018-05-10 06:23 PM, Tom Tromey wrote: > This introduces a new psymtab_storage class, which holds all > psymbol-related objects that are independent of the objfile. (This > latter contraint explains why psymbol_map was not moved; though this > could still be done with some work.) > > This patch does not yet change where psymtab allocation is done -- > that comes later. This just wraps everything in a single object to > make further transformations simpler. > > Note that a shared_ptr is used to link from the objfile to the > psymtab_storage object. The end goal here is to allow a given symbol > reader to simply attach to the psymtab_storage object to the BFD, then > reuse it in later invocations; shared_ptr makes this simple to reason > about. This patch LGTM. Simon