From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 57314 invoked by alias); 10 Sep 2018 12:52:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57302 invoked by uid 89); 10 Sep 2018 12:52:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Sep 2018 12:52:41 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w8ACqYq7011780 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 10 Sep 2018 08:52:39 -0400 Received: by simark.ca (Postfix, from userid 112) id BFE811E76F; Mon, 10 Sep 2018 08:52:34 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 821821E16B; Mon, 10 Sep 2018 08:52:32 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 10 Sep 2018 12:52:00 -0000 From: Simon Marchi To: Xavier Roirand Cc: gdb-patches@sourceware.org, brobecker@adacore.com, tom@tromey.com Subject: Re: [RFA 5/5 v3] Darwin: fix SIGTRAP when debugging In-Reply-To: <1536582779-12182-1-git-send-email-roirand@adacore.com> References: <1536582779-12182-1-git-send-email-roirand@adacore.com> Message-ID: <26053bf8ea4ba887967ecc4747f94c2b@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00259.txt.bz2 On 2018-09-10 13:32, Xavier Roirand wrote: > Debugging a program under Darwin does not work: > > (gdb) start > Temporary breakpoint 1 at 0x100000fb4: file /tmp/helloworld.c, line 1. > Starting program: /private/tmp/helloworld > [New Thread 0x2903 of process 60326] > During startup program terminated with signal SIGTRAP, Trace/breakpoint > trap. > > Field signaled from darwin_thread_info is not initialized thus signal > sent to the debuggee is considered as not sent by GDB whereas it > should. > > This patch fixes this problem and also updates (change type and/or > initialize) other fields in the same structure at the same time. > > gdb/ChangeLog: > > * darwin-nat.h (struct darwin_thread_info) inf_port, msg_state>: Initialize. > (struct darwin_thread_info) : Change > type and initialize. > (struct darwin_thread_info) : Initialize. > > Change-Id: I0fe2a6985df9d0dfcc8a2a258a3ef70cfa19b403 > --- > gdb/darwin-nat.h | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/gdb/darwin-nat.h b/gdb/darwin-nat.h > index 5965df08ab6..89a7c06f6a1 100644 > --- a/gdb/darwin-nat.h > +++ b/gdb/darwin-nat.h > @@ -114,25 +114,25 @@ enum darwin_msg_state > struct darwin_thread_info : public private_thread_info > { > /* The thread port from a GDB point of view. */ > - thread_t gdb_port; > + thread_t gdb_port = 0; > > /* The thread port from the inferior point of view. Not to be used > inside > gdb except for get_ada_task_ptid. */ > - thread_t inf_port; > + thread_t inf_port = 0; > > /* Current message state. > If the kernel has sent a message it expects a reply and the > inferior > can't be killed before. */ > - enum darwin_msg_state msg_state; > + enum darwin_msg_state msg_state = DARWIN_RUNNING; > > /* True if this thread is single-stepped. */ > - unsigned char single_step; > + bool single_step = false; > > /* True if a signal was manually sent to the thread. */ > - unsigned char signaled; > + bool signaled = false; > > /* The last exception received. */ > - struct darwin_exception_msg event; > + struct darwin_exception_msg event {}; > }; > typedef struct darwin_thread_info darwin_thread_t; LGTM. You do have push access I believe, is that right? Simon