From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92956 invoked by alias); 19 Mar 2019 15:45:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92880 invoked by uid 89); 19 Mar 2019 15:45:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=-23.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=6258, That=e2, UD:gdb.exp, gdbexp?= X-HELO: EUR02-HE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr10075.outbound.protection.outlook.com (HELO EUR02-HE1-obe.outbound.protection.outlook.com) (40.107.1.75) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Mar 2019 15:45:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tASbAHrJpE9A2BZrsy5FpvxtoFns5xgYJQvRS20fuIQ=; b=IS9/jE25d4SU+i1KdL5gy3nbwG8UJ/uR9jrFsQU2tmZnsmYxdvx5JqQrWNnrUOXnNWC/d7HSzIE6j9XS1B3GD5oOp9h0JlUXSaK1GMCGqtO9s0OhX2u9a56YPsxT76bEV9WcSkR87ua1peq1wNqSnH4ysXtPL7zqGdgoAUhAkWg= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.227.22) by DB6PR0802MB2454.eurprd08.prod.outlook.com (10.172.250.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1709.14; Tue, 19 Mar 2019 15:45:36 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::e974:35a7:c83c:e5b7]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::e974:35a7:c83c:e5b7%3]) with mapi id 15.20.1709.015; Tue, 19 Mar 2019 15:45:36 +0000 From: Alan Hayward To: Simon Marchi CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH] Testsuite: Ensure pie is disabled on some tests Date: Tue, 19 Mar 2019 15:45:00 -0000 Message-ID: <260313A3-D685-4306-8DE1-080D51BAE0BE@arm.com> References: <20190306102006.99150-1-alan.hayward@arm.com> <696945e9-4942-5285-0bb4-0bf899606f0a@simark.ca> In-Reply-To: <696945e9-4942-5285-0bb4-0bf899606f0a@simark.ca> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00406.txt.bz2 DQoNCj4gT24gMTkgTWFyIDIwMTksIGF0IDEzOjQ3LCBTaW1vbiBNYXJjaGkg PHNpbWFya0BzaW1hcmsuY2E+IHdyb3RlOg0KPiANCj4gT24gMjAxOS0wMy0w NiA1OjIwIGEubS4sIEFsYW4gSGF5d2FyZCB3cm90ZToNCj4+IFJlY2VudCB2 ZXJzaW9ucyBvZiBVYnVudHUgYW5kIERlYmlhbiBkZWZhdWx0IEdDQyB0byBl bmFibGUgcGllLg0KPj4gSW4gZHVtcC5leHAsIHBpZSB3aWxsIGNhdXNlcyBh ZGRyZXNzZXMgdG8gYmUgb3V0IG9mIHJhbmdlIGZvciBJSEVYLg0KPj4gSW4g YnJlYWstaW50ZXJwLmV4cCwgcGllIGlzIGV4cGxpY2l0bHkgc2V0IGZvciBz b21lIHRlc3RzIGFuZCBhc3N1bWVkDQo+PiB0byBiZSBkaXNhYmxlZCBmb3Ig dGhlIHJlbWFpbmRlci4NCj4+IEVuc3VyZSBwaWUgaXMgZGlzYWJsZWQgZm9y IHRoZXNlIHRlc3RzIHdoZW4gcmVxdWlyZWQuDQo+PiBnZGIvdGVzdHN1aXRl L0NoYW5nZUxvZzoNCj4+IDIwMTktMDMtMDYgIEFsYW4gSGF5d2FyZCAgPGFs YW4uaGF5d2FyZEBhcm0uY29tPg0KPj4gCSogZ2RiLmJhc2UvYnJlYWstaW50 ZXJwLmV4cDogRW5zdXJlIHBpZSBpcyBkaXNhYmxlZC4NCj4+IAkqIGdkYi5i YXNlL2R1bXAuZXhwOiBMaWtld2lzZS4NCj4gDQo+IEhpIEFsYW4sDQo+IA0K PiBUaGUgIm5vcGllIiBmbGFnIHRvIGdkYl9jb21waWxlIGhhcyBiZWVuIGlu dHJvZHVjZWQgcmVjZW50bHkgZm9yIHRoaXMsIGNvdWxkIHlvdSB1c2UgdGhh dCBpbnN0ZWFkPyAgU2VlIGNvbW1pdCA2ZThiMWFiMmZkNGMgKCJGaXggdmFy aW91cyB0ZXN0cyB0byB1c2UgLW5vLXBpZSBsaW5rZXIgZmxhZyB3aGVuIG5l ZWRlZOKAnSkuDQoNCkFoYSEgVGhhdOKAmXMgZXhhY3RseSB3aGF0IEkgbmVl ZGVkLg0KDQpJbiBteSBtaW5kLCB3ZSBzaG91bGQgaGF2ZSBhIOKAnHBpZeKA nSBmbGFnIHRvby4gSeKAmWxsIGFkZCB0aGlzIGluIHRvby4NCg0KPiANCj4+ IC0tLQ0KPj4gIGdkYi90ZXN0c3VpdGUvZ2RiLmJhc2UvYnJlYWstaW50ZXJw LmV4cCB8IDQgKysrKw0KPj4gIGdkYi90ZXN0c3VpdGUvZ2RiLmJhc2UvZHVt cC5leHAgICAgICAgICB8IDQgKysrKw0KPj4gIDIgZmlsZXMgY2hhbmdlZCwg OCBpbnNlcnRpb25zKCspDQo+PiBkaWZmIC0tZ2l0IGEvZ2RiL3Rlc3RzdWl0 ZS9nZGIuYmFzZS9icmVhay1pbnRlcnAuZXhwIGIvZ2RiL3Rlc3RzdWl0ZS9n ZGIuYmFzZS9icmVhay1pbnRlcnAuZXhwDQo+PiBpbmRleCBmODVlOGE2NTBh Li40MDljMzFlNTY4IDEwMDY0NA0KPj4gLS0tIGEvZ2RiL3Rlc3RzdWl0ZS9n ZGIuYmFzZS9icmVhay1pbnRlcnAuZXhwDQo+PiArKysgYi9nZGIvdGVzdHN1 aXRlL2dkYi5iYXNlL2JyZWFrLWludGVycC5leHANCj4+IEBAIC02MjcsNiAr NjI3LDEwIEBAIGZvcmVhY2ggbGRwcmVsaW5rIHtOTyBZRVN9IHsNCj4+ICAJ CQkgICAgaWYgeyRiaW5waWUgIT0gIk5PIn0gew0KPj4gIAkJCQlsYXBwZW5k IG9wdHMge2FkZGl0aW9uYWxfZmxhZ3M9LWZQSUV9DQo+PiAgCQkJCWxhcHBl bmQgb3B0cyB7bGRmbGFncz0tcGllfQ0KPj4gKwkJCSAgICB9IGVsc2Ugew0K Pj4gKwkJCQkjIFJlY2VudCBEZWJpYW4vVWJ1bnR1IGRlZmF1bHRzIFBJRSBl bmFibGVkLiBFbnN1cmUgaXQgaXMgZGlzYWJsZWQuDQo+PiArCQkJCWxhcHBl bmQgb3B0cyB7YWRkaXRpb25hbF9mbGFncz0tbm8tcGllfQ0KPj4gKwkJCQls YXBwZW5kIG9wdHMge2xkZmxhZ3M9LW5vLXBpZX0NCj4+ICAJCQkgICAgfQ0K PiANCj4gSSBiZWxpZXZlIGl0IHdvbid0IGJlIG5lY2Vzc2FyeSBoZXJlIHRv IGNoYW5nZSBDRkxBR1MgKHdoaWNoIGFkZGl0aW9uYWxfZmxhZ3MgZG9lcyks IG9ubHkgbGRmbGFncywgdG8gbWFrZSB0aGUgZmluYWwgZXhlY3V0YWJsZSBh IG5vbi1QSUUuICBBbnl3YXksIHlvdSdsbCBwcm9iYWJseSBlbmQgdXAgdXNp bmcgdGhlICJub3BpZSIgZ2RiX2NvbXBpbGUgZmxhZy4NCg0KDQpBZ3JlZWQu DQoNCg0KPiANCj4+ICAgIAkJCSAgICBzZXQgZGlyICR7ZXhlY30uZA0KPj4g ZGlmZiAtLWdpdCBhL2dkYi90ZXN0c3VpdGUvZ2RiLmJhc2UvZHVtcC5leHAg Yi9nZGIvdGVzdHN1aXRlL2dkYi5iYXNlL2R1bXAuZXhwDQo+PiBpbmRleCA0 NGIwOTg4YjgwLi5iMmQ3ZWY5MzhhIDEwMDY0NA0KPj4gLS0tIGEvZ2RiL3Rl c3RzdWl0ZS9nZGIuYmFzZS9kdW1wLmV4cA0KPj4gKysrIGIvZ2RiL3Rlc3Rz dWl0ZS9nZGIuYmFzZS9kdW1wLmV4cA0KPj4gQEAgLTM2LDYgKzM2LDEwIEBA IGlmIHtbaXN0YXJnZXQgInNwdSotKi0qIl19IHRoZW4gew0KPj4gICAgICBz ZXQgaXM2NGJpdG9ubHkgInllcyINCj4+ICB9DQo+PiAgKyMgRW5zdXJlIC1w aWUgaXMgZGlzYWJsZWQgYXMgdGhpcyBicmVha3MgSUhFWCB0ZXN0cy4NCj4g DQo+IENhbiB5b3UganVzdCBwcmVjaXNlIGhvdyBpdCBicmVha3MgdGhlIElI RVggdGVzdHMsIGFzIHlvdSBkaWQgaW4gdGhlIGNvbW1pdCBtZXNzYWdlIChp dCBjYXVzZXMgdGhlIGFkZHJlc3NlcyB0byBiZSBvdXQgb2YgcmFuZ2UgZm9y IHRoYXQgZm9ybWF0KT8NCg0KRG9uZS4NCg0KDQo+IA0KPiBUaGlzIHBhdGNo IGlzIG9rIHdpdGggdGhvc2UgZml4ZWQsIHRoYW5rcyENCj4gDQoNClVwZGF0 ZWQuIEkgd291bGQgaGF2ZSBwdXNoZWQgdGhpcyBuZXcgdmVyc2lvbiAtIGJ1 dCAtIEnigJltIGEgbGl0dGxlIHVuc3VyZSBhYm91dCBhZGRpbmcgdGhlIGFk ZGl0aW9uYWwgYm9hcmQgZmxhZ3MuDQoNClBpZSBvcHRpb24gYWRkcyBib3Ro IGZsYWcgYW5kIGxkZmxhZyB2ZXJzaW9ucyB0byBtYWtlIHN1cmUgaXQgZ2V0 cyB0aGUgY2FzZXMgd2hlcmUgd2XigJlyZSBqdXN0IGNvbXBpbGluZyB0byBv YmplY3RzLg0KDQoNClRoaXMgdmVyc2lvbiBvaz8NCg0KDQogICAgMjAxOS0w My0xOSAgQWxhbiBIYXl3YXJkICA8YWxhbi5oYXl3YXJkQGFybS5jb20+DQoN CiAgICAgICAgICAgICogUkVBRE1FOiBBZGQgcGllIG9wdGlvbnMuDQogICAg ICAgICAgICAqIGdkYi5iYXNlL2JyZWFrLWludGVycC5leHA6IEVuc3VyZSBw aWUgaXMgZGlzYWJsZWQuDQogICAgICAgICAgICAqIGdkYi5iYXNlL2R1bXAu ZXhwOiBMaWtld2lzZS4NCiAgICAgICAgICAgICogbGliL2dkYi5leHAgKGdk Yl9jb21waWxlKTogQWRkIHBpZSBvcHRpb24uDQoNCmRpZmYgLS1naXQgYS9n ZGIvdGVzdHN1aXRlL1JFQURNRSBiL2dkYi90ZXN0c3VpdGUvUkVBRE1FDQpp bmRleCBiNWU3NWI5YTc5Li4yNTM4MWNkZjA0IDEwMDY0NA0KLS0tIGEvZ2Ri L3Rlc3RzdWl0ZS9SRUFETUUNCisrKyBiL2dkYi90ZXN0c3VpdGUvUkVBRE1F DQpAQCAtNDgyLDYgKzQ4MiwxNiBAQCBnZGIsbm9fdGhyZWFkX25hbWVzDQoN CiAgIFRoZSB0YXJnZXQgZG9lc24ndCBzdXBwb3J0IHRocmVhZCBuYW1lcy4N Cg0KK2dkYixwaWVfZmxhZw0KKw0KKyAgVGhlIGZsYWcgcmVxdWlyZWQgdG8g Zm9yY2UgdGhlIGNvbXBpbGVyIHRvIHByb2R1Y2UgcG9zaXRpb24taW5kZXBl bmRlbnQNCisgIGV4ZWN1dGFibGVzLg0KKw0KK2dkYixsZHBpZV9mbGFnDQor DQorICBUaGUgZmxhZyByZXF1aXJlZCB0byBmb3JjZSB0aGUgbGlua2VyIHRv IHByb2R1Y2UgcG9zaXRpb24taW5kZXBlbmRlbnQNCisgIGV4ZWN1dGFibGVz Lg0KKw0KIGdkYixub3BpZV9mbGFnDQoNCiAgIFRoZSBmbGFnIHJlcXVpcmVk IHRvIGZvcmNlIHRoZSBjb21waWxlciB0byBwcm9kdWNlIG5vbi1wb3NpdGlv bi1pbmRlcGVuZGVudA0KZGlmZiAtLWdpdCBhL2dkYi90ZXN0c3VpdGUvZ2Ri LmJhc2UvYnJlYWstaW50ZXJwLmV4cCBiL2dkYi90ZXN0c3VpdGUvZ2RiLmJh c2UvYnJlYWstaW50ZXJwLmV4cA0KaW5kZXggZjg1ZThhNjUwYS4uOGJiODUz YzA0MSAxMDA2NDQNCi0tLSBhL2dkYi90ZXN0c3VpdGUvZ2RiLmJhc2UvYnJl YWstaW50ZXJwLmV4cA0KKysrIGIvZ2RiL3Rlc3RzdWl0ZS9nZGIuYmFzZS9i cmVhay1pbnRlcnAuZXhwDQpAQCAtNjI1LDggKzYyNSwxMCBAQCBmb3JlYWNo IGxkcHJlbGluayB7Tk8gWUVTfSB7DQogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIGxhcHBlbmQgb3B0cyB7ZGVidWd9DQogICAgICAgICAgICAg ICAgICAgICAgICAgICAgfQ0KICAgICAgICAgICAgICAgICAgICAgICAgICAg IGlmIHskYmlucGllICE9ICJOTyJ9IHsNCi0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgbGFwcGVuZCBvcHRzIHthZGRpdGlvbmFsX2ZsYWdzPS1m UElFfQ0KLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsYXBwZW5k IG9wdHMge2xkZmxhZ3M9LXBpZX0NCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgbGFwcGVuZCBvcHRzIHtwaWV9DQorICAgICAgICAgICAgICAg ICAgICAgICAgICAgfSBlbHNlIHsNCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIyBSZWNlbnQgRGViaWFuL1VidW50dSBkZWZhdWx0cyB0byBQ SUUgZW5hYmxlZC4gRW5zdXJlIGl0IGlzIGRpc2FibGVkLg0KKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBsYXBwZW5kIG9wdHMge25vcGllfQ0K ICAgICAgICAgICAgICAgICAgICAgICAgICAgIH0NCg0KICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHNldCBkaXIgJHtleGVjfS5kDQpkaWZmIC0tZ2l0 IGEvZ2RiL3Rlc3RzdWl0ZS9nZGIuYmFzZS9kdW1wLmV4cCBiL2dkYi90ZXN0 c3VpdGUvZ2RiLmJhc2UvZHVtcC5leHANCmluZGV4IDQ0YjA5ODhiODAuLjU2 ZGNhZmQ0Y2IgMTAwNjQ0DQotLS0gYS9nZGIvdGVzdHN1aXRlL2dkYi5iYXNl L2R1bXAuZXhwDQorKysgYi9nZGIvdGVzdHN1aXRlL2dkYi5iYXNlL2R1bXAu ZXhwDQpAQCAtMzYsNiArMzYsMTAgQEAgaWYge1tpc3RhcmdldCAic3B1Ki0q LSoiXX0gdGhlbiB7DQogICAgIHNldCBpczY0Yml0b25seSAieWVzIg0KIH0N Cg0KKyMgUmVjZW50IERlYmlhbi9VYnVudHUgZGVmYXVsdHMgdG8gUElFIGVu YWJsZWQuIEVuc3VyZSBpdCBpcyBkaXNhYmxlZCBhcyB0aGlzDQorIyBjYXVz ZXMgYWRkcmVzc2VzIHRvIGJlIG91dCBvZiByYW5nZSBmb3IgSUhFWC4NCits YXBwZW5kIG9wdGlvbnMge25vcGllfQ0KKw0KIGlmICB7IFtnZGJfY29tcGls ZSAiJHtzcmNkaXJ9LyR7c3ViZGlyfS8ke3NyY2ZpbGV9IiAiJHtiaW5maWxl fSIgZXhlY3V0YWJsZSAke29wdGlvbnN9XSAhPSAiIiB9IHsNCiAgICAgIHVu dGVzdGVkICJmYWlsZWQgdG8gY29tcGlsZSINCiAgICAgIHJldHVybiAtMQ0K ZGlmZiAtLWdpdCBhL2dkYi90ZXN0c3VpdGUvbGliL2dkYi5leHAgYi9nZGIv dGVzdHN1aXRlL2xpYi9nZGIuZXhwDQppbmRleCBmMTNmOTA5YzM0Li4yNTk4 NjVmNWZkIDEwMDY0NA0KLS0tIGEvZ2RiL3Rlc3RzdWl0ZS9saWIvZ2RiLmV4 cA0KKysrIGIvZ2RiL3Rlc3RzdWl0ZS9saWIvZ2RiLmV4cA0KQEAgLTM0NjEs NiArMzQ2MSw3IEBAIHNldCBnZGJfc2F2ZWRfc2V0X3VuYnVmZmVyZWRfbW9k ZV9vYmogIiINCiAjICAgICBkeW5hbWljYWxseSBsb2FkIGxpYnJhcmllcyBh dCBydW50aW1lLiAgRm9yIGV4YW1wbGUsIG9uIExpbnV4LCB0aGlzIGFkZHMN CiAjICAgICAtbGRsIHNvIHRoYXQgdGhlIHRlc3QgY2FuIHVzZSBkbG9wZW4u DQogIyAgIC0gbm93YXJuaW5nczogIEluaGliaXQgYWxsIGNvbXBpbGVyIHdh cm5pbmdzLg0KKyMgICAtIHBpZTogRm9yY2UgY3JlYXRpb24gb2YgUElFIGV4 ZWN1dGFibGVzLg0KICMgICAtIG5vcGllOiBQcmV2ZW50IGNyZWF0aW9uIG9m IFBJRSBleGVjdXRhYmxlcy4NCiAjDQogIyBBbmQgaGVyZSBhcmUgc29tZSBv ZiB0aGUgbm90IHRvbyBvYnNjdXJlIG9wdGlvbnMgdW5kZXJzdG9vZCBieSBE ZWphR251IHRoYXQNCkBAIC0zNTk5LDggKzM2MDAsMjcgQEAgcHJvYyBnZGJf Y29tcGlsZSB7c291cmNlIGRlc3QgdHlwZSBvcHRpb25zfSB7DQogICAgICAg IHNldCBvcHRpb25zIFtscmVwbGFjZSAkb3B0aW9ucyAkbm93YXJuaW5ncyAk bm93YXJuaW5ncyAkZmxhZ10NCiAgICAgfQ0KDQotICAgICMgUmVwbGFjZSB0 aGUgIm5vcGllIiBvcHRpb24gd2l0aCB0aGUgYXBwcm9wcmlhdGUgYWRkaXRp b25hbF9mbGFncw0KLSAgICAjIHRvIGRpc2FibGUgUElFIGV4ZWN1dGFibGVz Lg0KKyAgICAjIFJlcGxhY2UgdGhlICJwaWUiIG9wdGlvbiB3aXRoIHRoZSBh cHByb3ByaWF0ZSBmbGFncyB0byBlbmFibGUgUElFDQorICAgICMgZXhlY3V0 YWJsZXMuDQorICAgIHNldCBwaWUgW2xzZWFyY2ggLWV4YWN0ICRvcHRpb25z IHBpZV0NCisgICAgaWYgeyRwaWUgIT0gLTF9IHsNCisgICAgICAgaWYgW3Rh cmdldF9pbmZvIGV4aXN0cyBnZGIscGllX2ZsYWddIHsNCisgICAgICAgICAg IHNldCBmbGFnICJhZGRpdGlvbmFsX2ZsYWdzPVt0YXJnZXRfaW5mbyBnZGIs cGllX2ZsYWddIg0KKyAgICAgICB9IGVsc2Ugew0KKyAgICAgICAgICAgc2V0 IGZsYWcgImFkZGl0aW9uYWxfZmxhZ3M9LWZwaWUiDQorICAgICAgIH0NCisg ICAgICAgc2V0IG9wdGlvbnMgW2xyZXBsYWNlICRvcHRpb25zICRwaWUgJHBp ZSAkZmxhZ10NCisNCisgICAgICAgaWYgW3RhcmdldF9pbmZvIGV4aXN0cyBn ZGIsbGRwaWVfZmxhZ10gew0KKyAgICAgICAgICAgc2V0IGZsYWcgImxkZmxh Z3M9W3RhcmdldF9pbmZvIGdkYixsZHBpZV9mbGFnXSINCisgICAgICAgfSBl bHNlIHsNCisgICAgICAgICAgIHNldCBmbGFnICJsZGZsYWdzPS1waWUiDQor ICAgICAgIH0NCisgICAgICAgbGFwcGVuZCBvcHRpb25zICIkZmxhZyINCisg ICAgfQ0KKw0KKyAgICAjIFJlcGxhY2UgdGhlICJub3BpZSIgb3B0aW9uIHdp dGggdGhlIGFwcHJvcHJpYXRlIGZsYWdzIHRvIGRpc2FibGUgUElFDQorICAg ICMgZXhlY3V0YWJsZXMuDQogICAgIHNldCBub3BpZSBbbHNlYXJjaCAtZXhh Y3QgJG9wdGlvbnMgbm9waWVdDQogICAgIGlmIHskbm9waWUgIT0gLTF9IHsN CiAgICAgICAgaWYgW3RhcmdldF9pbmZvIGV4aXN0cyBnZGIsbm9waWVfZmxh Z10gew0KDQoNCg0KDQoNCg0KDQo= >From gdb-patches-return-154719-listarch-gdb-patches=sources.redhat.com@sourceware.org Tue Mar 19 16:04:54 2019 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 7116 invoked by alias); 19 Mar 2019 16:04:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 7092 invoked by uid 89); 19 Mar 2019 16:04:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.47.79) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Mar 2019 16:04:51 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway22.websitewelcome.com (Postfix) with ESMTP id C1ECC2291BA for ; Tue, 19 Mar 2019 11:04:49 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 6HEPh02Q3dnCe6HEPhsNTX; Tue, 19 Mar 2019 11:04:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rBpkEmbZ19Jy0jxtFJWBnsWmDIs4hTqloYDlwG3+7f4=; b=DROmHt8253j/N4ORLrW1W2nZeg qCfUFCCR1f4OfxDJE5qOn1/gI1DqIzK6IlzUrdHOGiQy0zMmX7zJqoTPyPodGKS8riG1X5htA0vzB Ov8lF1iLEY6lODEdE1CAEDf9Y; Received: from 174-29-37-56.hlrn.qwest.net ([174.29.37.56]:48014 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1h6HEP-0034Dy-GR; Tue, 19 Mar 2019 11:04:49 -0500 From: Tom Tromey To: Eli Zaretskii Cc: Tom Tromey , palves@redhat.com, gdb-patches@sourceware.org Subject: Re: [PATCH] Readline: Cleanup some warnings References: <20190130085716.75179-1-alan.hayward@arm.com> <20190131075907.GA313@adacore.com> <3463805B-A8BF-4C20-ACE3-C21AE3F7DB62@arm.com> <20190201080533.GA31043@adacore.com> <877eejvfoq.fsf@tromey.com> <1549047248.2630.7.camel@skynet.be> <310315f8-62ab-2eff-042f-9f2ae9de07da@redhat.com> <87wokxtnlt.fsf@tromey.com> <83h8c1wdr5.fsf@gnu.org> Date: Tue, 19 Mar 2019 16:04:00 -0000 In-Reply-To: <83h8c1wdr5.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 17 Mar 2019 20:35:10 +0200") Message-ID: <87imwex333.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-03/txt/msg00407.txt.bz2 Content-length: 2565 >>>>> "Eli" == Eli Zaretskii writes: >> From: Tom Tromey >> Cc: "gdb-patches\@sourceware.org" >> Date: Sun, 17 Mar 2019 11:30:38 -0600 >> >> I still don't really know what to do about the readline-related hack in >> the mingw gdb_select. I'd like to remove it, but I can't test it and I >> don't know whether it's still needed. Eli> Can someone point me to the PR that led to that hack? I'd like to see Eli> what happens in that use case and why is this code needed to solve it. Eli> (I tried "git annotate", but that didn't tell me anything interesting Eli> about the history of that snippet. Apologies if I missed something.) All I know is what annotate says. The commit message is appended. Here's the gdb-patches thread about it: https://sourceware.org/ml/gdb-patches/2008-02/msg00423.html Tom commit b803fb0f0f7a90ca764d08f93104bc262d63ad40 Author: Daniel Jacobowitz Date: Wed Mar 5 17:21:10 2008 +0000 * Makefile.in (mingw-hdep.o, posix-hdep.o, remote-fileio.o): Update. * event-loop.c (call_async_signal_handler): New. * event-loop.h (call_async_signal_handler) (gdb_call_async_signal_handler): Declare. (mark_async_signal_handler): Add comments. * event-top.c (handle_sigint): Use gdb_call_async_signal_handler. * mingw-hdep.c (sigint_event, sigint_handler): New. (gdb_select): Use them. Wait for the readline signal handler to finish. (gdb_call_async_signal_handler, _initialize_mingw_hdep): New functions. * posix-hdep.c (gdb_call_async_signal_handler): New function. * remote-fileio.c (sigint_fileio_token, async_remote_fileio_interrupt): New. (remote_fileio_ctrl_c_signal_handler): Use gdb_call_async_signal_handler. (initialize_remote_fileio): Initialize sigint_fileio_token. * remote.c (initialize_sigint_signal_handler, handle_remote_sigint): Do not initialize tokens here. (handle_remote_sigint_twice): Likewise. Reinstall handle_remote_sigint. (async_remote_interrupt_twice): Just call interrupt_query. (cleanup_sigint_signal_handler): Do not delete tokens. (remote_interrupt, remote_interrupt_twice): Use gdb_call_async_signal_handler. (interrupt_query): Reinstall the default signal handler. (_initialize_remote): Initialize tokens here.