From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13041 invoked by alias); 14 Aug 2009 23:12:26 -0000 Received: (qmail 12989 invoked by uid 22791); 14 Aug 2009 23:12:26 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 14 Aug 2009 23:12:19 +0000 Received: from spaceape10.eur.corp.google.com (spaceape10.eur.corp.google.com [172.28.16.144]) by smtp-out.google.com with ESMTP id n7ENCGO9022114 for ; Fri, 14 Aug 2009 16:12:17 -0700 Received: from gxk28 (gxk28.prod.google.com [10.202.11.28]) by spaceape10.eur.corp.google.com with ESMTP id n7ENCDGh013398 for ; Fri, 14 Aug 2009 16:12:14 -0700 Received: by gxk28 with SMTP id 28so2355190gxk.23 for ; Fri, 14 Aug 2009 16:12:13 -0700 (PDT) MIME-Version: 1.0 Received: by 10.150.238.11 with SMTP id l11mr3046824ybh.63.1250291533548; Fri, 14 Aug 2009 16:12:13 -0700 (PDT) In-Reply-To: References: <9a9942200907221615o570e749fh5cb186c1600f159c@mail.gmail.com> <200907301501.17812.thiago.bauermann@gmail.com> <200907311201.28986.thiago.bauermann@gmail.com> <9a9942200907311117r2f5363f8ufde734ce2bbf721a@mail.gmail.com> Date: Fri, 14 Aug 2009 23:37:00 -0000 Message-ID: <25eb677d0908141612v78fb10eet8fef3b29a7856dc7@mail.gmail.com> Subject: Re: [unladen-swallow] Re: [RFA] Add interface for registering JITed code From: Reid Kleckner To: tromey@redhat.com Cc: Reid Kleckner , unladen-swallow@googlegroups.com, gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00210.txt.bz2 On Fri, Aug 14, 2009 at 12:27 PM, Tom Tromey wrote: > > >>>>>> "Reid" =3D=3D Reid Kleckner writes: > > Reid> Here's an updated patch. =A0What else needs to be dealt with? > > Nothing. =A0I think this is ok. > > I read it a few more times and nothing popped out at me. Is it OK if Doug commits it then? > Reid> + =A0 =A0 =A0/* Hack to work around the fact that BFD does not take= ownership of the > Reid> + =A0 =A0 =A0 =A0 memory for files allocated in memory. =A0*/ > Reid> + =A0 =A0 =A0if (objfile->obfd->flags & BFD_IN_MEMORY) > Reid> + =A0 =A0 =A0 =A0bim =3D (struct bfd_in_memory *) objfile->obfd->io= stream; > > What is the status of the BFD patch to fix this? Doug has permission to remove the leak from BFD, so I think I'll remove this hack from my patch to reduce churn. Thanks, Reid