From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id wygjIuzaMWlSbhkAWB0awg (envelope-from ) for ; Thu, 04 Dec 2025 14:03:08 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YvMN7zEE; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7BE861E08D; Thu, 04 Dec 2025 14:03:08 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 126BA1E08D for ; Thu, 04 Dec 2025 14:03:08 -0500 (EST) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7D31F4B1A36E for ; Thu, 4 Dec 2025 19:03:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7D31F4B1A36E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YvMN7zEE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 160F34BC89A6 for ; Thu, 4 Dec 2025 19:02:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 160F34BC89A6 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 160F34BC89A6 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764874961; cv=none; b=vzt2BeaBkeahjdPq6adzK2BnNZxYUDZDoQXSfRIbnvZ6o76zgvAOHmbEjm262yQT0VB6rAwBGFAMp5iuHOdTIUf1cL54JnN2lkOD4K3hQOnEhstvwBkRAjlNu03DtJqm2zbYYGsXcoycrhpQ6yXoHUFyFUrBL/Dx5aPbLEr/yGA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764874961; c=relaxed/simple; bh=aEPAG5UjidJqFclLz6tnlrZR9oxbyq7w3k5LV1pstFk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=qMJEIe6JAKACng/Vcv9YsSTUcyZwSJg5LbRj6mn2oAahMoudzmS30TsNX2odJvjq4RTUONdERsTJaV4p0Mm7AvWLDisVoqz44U0NDYoQNyF8nCO9f+rHx5WNnqzsllOwcdPVrX+fCPOoYAAGmvdcI5V3MinbmbcImV60X5pPqKM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 160F34BC89A6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764874960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p20W1B8vx7W43ORy0zQTRzPOQJ95+6nOBKheiQ4Rk/Y=; b=YvMN7zEEq/gglhanMh2J9Bl9fKAg9THzNJybRp5C3D8Rri3q3F5h8b4kXBRMKOQAWug4k3 AI+2eKyQxRbBe0M1wop2ritI3YSxUKXTd1QFiEmOxGkmiKjdBltxH+jri7UMWiQdExtJct 2F+0Smf9o52CfGeEXBGAK4N33id57LQ= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-656-jSMeSpAoOza-gcpfi5aUNw-1; Thu, 04 Dec 2025 14:02:38 -0500 X-MC-Unique: jSMeSpAoOza-gcpfi5aUNw-1 X-Mimecast-MFC-AGG-ID: jSMeSpAoOza-gcpfi5aUNw_1764874958 Received: by mail-ua1-f69.google.com with SMTP id a1e0cc1a2514c-9372401215fso1894796241.3 for ; Thu, 04 Dec 2025 11:02:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764874957; x=1765479757; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=p20W1B8vx7W43ORy0zQTRzPOQJ95+6nOBKheiQ4Rk/Y=; b=wW6LudBllC5gpabNBMJuL7/aSv6DZ7hDjRkAtK/RjvQPfoUNc4p2rrfbAt2l91FBuu D2q0IImTwsiUx8Uffdl+GDoWiunWQ2wlnjKEZqhmwxdBX0HI/mtuzfa828jAfRU19wua YzsMcUxFMCr9Ie6VdQRRKE7wL2pApaODYOffoSREdg0D35sa1NP+mK5zEJCL43ozf0JC wGyOx/6Ii2KVri8OJuhxB9GGvOFm5FtsT3jliJU4kHPbAHwJo4aX1X953KUi/lQYBozQ 4ZIU8n1GYBXM3KnEBJHa+AG/FU888RxUZajTjbOediG03ZNXHlIFdowzNQi2LsQ+ZGS0 m79Q== X-Forwarded-Encrypted: i=1; AJvYcCWQcRtuguiBS0CrXGC5/ttkQzbU3GUXtNzVWDIF0hbRMTYAlfLpu4qNkO5e3afjgc58ZU5o2rNOIuLhZA==@sourceware.org X-Gm-Message-State: AOJu0YzxTnsPB4OU3u/CAapO8MUq1bXfBGw0pudCH0zRZUjraIFf23r0 YIQ+Cy+rBtLTj1Abgi/HRV9d0zmlHHGcYl91cRf3O5APKpb79iYdl7bWd9hKmXfMr5qDONRWgIW Xi8GwD2Ixu/Z5SjKGs2j7vwKswrYE3W/naY45XGZFZV0S12FfhJ3Jl/EBdvYKsVla4bz6Y74= X-Gm-Gg: ASbGncuRhFDjybso7BAwNg6jJ67ZiE4KHTpLaPEiIkXdQ5D9YpmG9DLVRk66Nig3j/Z u8yXTsWS2Tw/3icRCgSWyEx5MD4S0sexlsxp/IhKjr9E4M+IiV8qQWN4eNcEH1WpJy7+5ig3PV5 aWXxOimkozmYJSnkYrv9KuPr2uqr9/GTRbcNfjQK7HFSBQNYnEYIjmb6WZ9ihGRc9FJyscZaaFo 3p2F05pIpGDWxnZ0R4OVKVEK9yk5NuAL7Xm50glFkklRUGCEBPWHGgrl60/pGStSt/VyrjQ8mdv UdeCfe5z2/Ls2H6Km+1liFyUoeDoyOQBK8kDDO3v1yCfFRBpX6oxrIDrkLWXDd/3Md09NkNbgEd nFiTG7yKZO33lku3dx5FAQg== X-Received: by 2002:a05:6102:4186:b0:5db:fddb:3155 with SMTP id ada2fe7eead31-5e48e24c680mr3009346137.17.1764874957508; Thu, 04 Dec 2025 11:02:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IGc7q2lIBsXu3sEye+0URLTrLGC+CArlPPjVf/buWiS43mYIyP0VsBPHKiEllJdG0QU4z41Ew== X-Received: by 2002:a05:6102:4186:b0:5db:fddb:3155 with SMTP id ada2fe7eead31-5e48e24c680mr3009319137.17.1764874957118; Thu, 04 Dec 2025 11:02:37 -0800 (PST) Received: from ?IPV6:2804:14d:8084:9a69::1001? ([2804:14d:8084:9a69::1001]) by smtp.gmail.com with ESMTPSA id a1e0cc1a2514c-93eed696edfsm955968241.1.2025.12.04.11.02.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Dec 2025 11:02:35 -0800 (PST) Message-ID: <25c4729b-16af-45a0-a281-f64cc6b4f5a4@redhat.com> Date: Thu, 4 Dec 2025 16:02:33 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/4] Fixes and tests related to new boxed hint startup text To: Andrew Burgess , gdb-patches@sourceware.org References: From: Guinevere Larsen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: SFafD7aluKxPsEDPfTSXddb72ZHObyUVlrA-2lq-9OE_1764874958 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 12/4/25 1:38 PM, Andrew Burgess wrote: > Started out with a minor fix for the new boxed hint start up text. > Then I wrote some tests. Which exposed some bugs. Which required > some additional fixes. > > First 2 patches are clean up. > > Final 2 are actual fixes. > > Thanks, > Andrew Hi Andrew! I took a look over the patches, and everything looks right. Thanks for the quick fixes! Reviewed-By: Guinevere Larsen -- Cheers, Guinevere Larsen It/she > > --- > > Andrew Burgess (4): > gdb: remove some unnecessary code from print_gdb_hints > gdb: small white space fix in print_gdb_hints > gdb: make get_chars_per_line return an unsigned value > gdb: fix crashes and weird output from new boxed hint text > > gdb/cli-out.c | 4 +- > gdb/main.c | 5 +- > gdb/testsuite/gdb.base/startup-hints.exp | 144 +++++++++++++++++++++++ > gdb/top.c | 28 +++-- > gdb/utils.c | 3 +- > gdb/utils.h | 5 +- > 6 files changed, 170 insertions(+), 19 deletions(-) > create mode 100644 gdb/testsuite/gdb.base/startup-hints.exp > > > base-commit: a9304819899e9164c9550c601ed81d807df2c794