From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39654 invoked by alias); 14 Jun 2018 13:49:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39446 invoked by uid 89); 14 Jun 2018 13:49:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=yeah, office X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Jun 2018 13:49:42 +0000 Received: from relay2.suse.de (charybdis-ext-too.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 0A0AFAE08; Thu, 14 Jun 2018 13:49:39 +0000 (UTC) Subject: Re: [PATCH, testsuite] Allow function arguments in bp print match in selftest_setup To: Pedro Alves Cc: gdb-patches@sourceware.org References: <20180612151500.xgw27odexd5fgyww@localhost.localdomain> <8f1dae31-ac6c-74e2-1851-ca885193aa89@redhat.com> <20180614102107.cgh6iixu324pmpvi@localhost.localdomain> <51e2fa52-222b-6ec0-16d3-8c99fcc9a310@redhat.com> From: Tom de Vries Message-ID: <25b1dca5-becc-cef5-1583-6750032064af@suse.de> Date: Thu, 14 Jun 2018 13:49:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <51e2fa52-222b-6ec0-16d3-8c99fcc9a310@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00360.txt.bz2 On 06/14/2018 12:45 PM, Pedro Alves wrote: > On 06/14/2018 11:21 AM, Tom de Vries wrote: > >>> [1] Funny, it passes for me (with the fix for stopping at captured_main), >>> because the pattern below the one you're touching matches: >>> >>> -re "Starting program.*Breakpoint \[0-9\]+,.* at .*main.c:.*$function.*$gdb_prompt $" { >>> # $function may be inlined, so the program stops at the line >>> # calling $function. >>> pass "$description" >>> } >>> >>> and it only happens to match because captured_main calls >>> captured_main_1 first thing, which coincidentally >>> matches "$function.*": >>> >>> Breakpoint 1, captured_main (data=) at gdb/binutils-gdb/src/gdb/main.c:1147 >>> 1147 captured_main_1 (context); >>> >>> That would probably be better "$function .*", with a space, >> Right, I observed that as well, and was thinking of this type of fix. > Please don't be shy about stating those things upfront, makes > review easier. :-) > Ack, yeah, sorry about that. I'm currently visiting the Nuremberg office, so I'm a bit more distracted than usual. Thanks, - Tom