Re: Subtle problems with "info sharedlibrary" on MS-Windows

Eli Zaretskii via Gdb-patches
2021-04-11T07:11:09Z

> Cc: gdb-patches@sourceware.org
> From: Simon Marchi <simon.marchi@polymtl.ca>
> Date: Sat, 10 Apr 2021 18:56:05 -0400
>
> > --- gdbserver/win32-low.cc~ 2021-03-25 03:47:10.000000000 +0200
> > +++ gdbserver/win32-low.cc 2021-04-10 21:05:48.677425000 +0300
> > @@ -1165,11 +1165,13 @@ load_psapi (void)
> >
> > #ifndef _WIN32_WCE
>
> I see that this patch deals with _WIN32_WCE. We removed support for
> WinCE in 84b300de3666 ("gdbserver: remove support for ARM/WinCE"). It
> looks like I failed to remove the WinCE-related core from win32-low.cc
> (I guess I didn't know about the _WIN32_WCE macro then). Would you mind
> if we first removed that unncecessary code first? That would make your
> patch simpler.

I'd actually prefer it the other way around, for 2 reasons: (a) the
patch for windows-nat.c is already in, so it would make sense to fix
gdbserver ASAP; (b) I built with the patch a recent snapshot of master
where these conditions are still present, and I would like to avoid
the need to build yet another snapshot just for this small change.