From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id 49F2F3842415
 for <gdb-patches@sourceware.org>; Thu,  9 Jul 2020 17:28:40 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 49F2F3842415
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 941D91E792;
 Thu,  9 Jul 2020 13:28:39 -0400 (EDT)
Subject: Re: [PATCH 2/3] Fix crash if connection drops in
 scoped_restore_current_thread's ctor, part 2
To: Pedro Alves <pedro@palves.net>, gdb-patches@sourceware.org
References: <20200708233125.1030-1-pedro@palves.net>
 <20200708233125.1030-3-pedro@palves.net>
 <ce2ca83b-c7ed-88f1-d29d-f17da07ddd85@simark.ca>
 <1809ad79-7542-776d-cb1f-8a1ce0ed6825@palves.net>
 <482b9730-707c-adf4-2fd0-c430fb101402@simark.ca>
 <e5c7d7a1-e562-7e1e-77e2-6ce35fd35035@palves.net>
From: Simon Marchi <simark@simark.ca>
Message-ID: <255150fb-802b-8746-ff09-cb855f25c420@simark.ca>
Date: Thu, 9 Jul 2020 13:28:38 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <e5c7d7a1-e562-7e1e-77e2-6ce35fd35035@palves.net>
Content-Type: text/plain; charset=utf-8
Content-Language: fr
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 KAM_NUMSUBJECT, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Jul 2020 17:28:41 -0000

On 2020-07-09 1:23 p.m., Pedro Alves wrote:
> Unfortunately, we can't define inferior_ref in inferior.h and then use
> it in scoped_restore_current_thread, because
> scoped_restore_current_thread is defined before inferior is
> (inferior.h includes gdbthread.h).  To break that dependency, we would
> have to move scoped_restore_current_thread to its own header.  I'm not
> doing that here.

Cool, that's fine with me.

Simon