From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id l8sxHTft0WMzsiEAWB0awg (envelope-from ) for ; Wed, 25 Jan 2023 22:02:15 -0500 Received: by simark.ca (Postfix, from userid 112) id 647B31E128; Wed, 25 Jan 2023 22:02:15 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=J1MqiODS; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 10A9D1E112 for ; Wed, 25 Jan 2023 22:02:15 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A0F5E3858414 for ; Thu, 26 Jan 2023 03:02:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A0F5E3858414 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1674702133; bh=Tzss+/f1apCbPSVXYFw1qunQrZyrhpV2GGWCcs9COhw=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=J1MqiODSRpzZOf2V1jdmHGFxgqqsqU3Q0aiqZILFUeH99mpn4qmopnFWizTWThjTM zW7/ARpdPGmi7Y1FymHdfJGuZBQUDYFF6WjVhfQdt3FS5TJAtJqJ3qxOJ6oEMBRc0p efIZEgWxYvmnQjb+y5ysz/t2rx3QmUR1G9e7wZLA= Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 7E08C3858D28 for ; Thu, 26 Jan 2023 03:01:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7E08C3858D28 Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 4E6DC1E112; Wed, 25 Jan 2023 22:01:53 -0500 (EST) Message-ID: <2542ebe8-bd2d-a0b1-74ce-faca47530c63@simark.ca> Date: Wed, 25 Jan 2023 22:01:52 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 3/9] gdb/testsuite/dap: write requests to gdb.log Content-Language: en-US To: Tom Tromey , Simon Marchi via Gdb-patches Cc: Simon Marchi References: <20230106185729.42372-1-simon.marchi@efficios.com> <20230106185729.42372-4-simon.marchi@efficios.com> <87edritgss.fsf@tromey.com> In-Reply-To: <87edritgss.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 1/25/23 17:01, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> This helps following what happens when reading gdb.log. The downside is > Simon> that it becomes harder to tell what text is from GDB and what text is > Simon> going to GDB, but I think that seeing responses without seeing requests > Simon> is even more confusing. At least, the lines are prefix with >>>, so > Simon> when you see this, you know that until the end of the line, it's > Simon> something that was sent to GDB, and not GDB output. > > I meant to mention -- the full DAP I/O is in the test subdir. > E.g. look at gdb/testsuite/outputs/gdb.dap/basic-dap/dap.log.1 in the > build tree. Yeah, I saw that. But to debug the actual test, I found that having the full communication in gdb.log was a bit easier, to correlate with passes and fails. Simon