From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2B0hEcF9gGBXQQAAWB0awg (envelope-from ) for ; Wed, 21 Apr 2021 15:32:17 -0400 Received: by simark.ca (Postfix, from userid 112) id 43E2C1F104; Wed, 21 Apr 2021 15:32:17 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 38FBD1E783 for ; Wed, 21 Apr 2021 15:32:14 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DEBC4386EC43; Wed, 21 Apr 2021 19:32:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DEBC4386EC43 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619033533; bh=vZVsSup2J6QG5ePS7ttOUS4YHacOrtweQIEmKu4bZLk=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=X6fs6B79XXNmdDUogwrj7dMrUKpr/rtC3BrdSK2MN7oS/hGeeESDiPU9g1oH4aJhO FXXpaL8h4WisMgOanuIyZXedmSZGX6SP8Xns9JcCgkCmGvn+BM5zPUfPPjthNuTEy9 eKEbmoE7rgEkUyhp/6KUMmCoatmt0PmVF5crMlIk= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 6A075386EC43 for ; Wed, 21 Apr 2021 19:32:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6A075386EC43 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 13LJW55J016596 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 21 Apr 2021 15:32:10 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 13LJW55J016596 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id D46ED1E783; Wed, 21 Apr 2021 15:32:05 -0400 (EDT) Subject: Re: [PATCH 1/6] gdb/infcmd: remove the unused parameter 'args' in 'attach_post_wait' To: Tom Tromey , Tankut Baris Aktemur via Gdb-patches References: <0013ebfdeb103a5142264bf02fc7abc4628a572a.1619009681.git.tankut.baris.aktemur@intel.com> <87czunbfuc.fsf@tromey.com> Message-ID: <251cc136-94ee-5c07-e461-a3ca527cc270@polymtl.ca> Date: Wed, 21 Apr 2021 15:32:05 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <87czunbfuc.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 21 Apr 2021 19:32:05 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-04-21 3:24 p.m., Tom Tromey wrote: >>>>>> ">" == Tankut Baris Aktemur via Gdb-patches writes: > >>> gdb/ChangeLog: >>> 2021-04-21 Tankut Baris Aktemur > >>> * infcmd.c (attach_post_wait): Remove the unused parameter 'args'. >>> Update the references below. >>> (struct attach_command_continuation_args) >>> (attach_command_continuation) >>> (attach_command_continuation_free_args) >>> (attach_command) >>> (notice_new_inferior): Update to remove the reference to 'args'. > > Normally it's good to have some text in the body that explains the > commit. I agree with you in general, but when I do patches like this one (remove unused parameter / variable), I also find it hard to find anything else to say than just repeating the subject. Simon