From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34827 invoked by alias); 28 Apr 2017 16:52:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34712 invoked by uid 89); 28 Apr 2017 16:52:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-23.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=ham version=3.3.2 spammy=Thursday, thursday X-HELO: mail.baldwin.cx Received: from bigwig.baldwin.cx (HELO mail.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 28 Apr 2017 16:52:03 +0000 Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id 360E410A82E; Fri, 28 Apr 2017 12:52:03 -0400 (EDT) From: John Baldwin To: Pedro Alves Cc: Luis Machado , gdb-patches@sourceware.org Subject: Re: [PATCH 3/4] Consistently use fprintf_filtered when displaying MIPS registers. Date: Fri, 28 Apr 2017 16:52:00 -0000 Message-ID: <2510728.B6TCG0NYLU@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.0-STABLE; KDE/4.14.10; amd64; ; ) In-Reply-To: <51dd8603-3681-c0fb-618d-29757e7c4b74@redhat.com> References: <20170412183727.22483-1-jhb@FreeBSD.org> <8eadfc97-f4ec-8c89-f193-f96a2fa8839c@codesourcery.com> <51dd8603-3681-c0fb-618d-29757e7c4b74@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00807.txt.bz2 On Thursday, April 27, 2017 05:05:33 PM Pedro Alves wrote: > On 04/13/2017 05:29 PM, Luis Machado wrote: > > On 04/12/2017 01:37 PM, John Baldwin wrote: > >> One line was using printf_filtered instead of fprintf_filtered > >> to the requested file. > >> > >> gdb/ChangeLog: > >> > >> * mips-tdep.c (print_gp_register_row): Replace printf_filtered > >> with fprintf_filtered. > >> --- > >> gdb/ChangeLog | 5 +++++ > >> gdb/mips-tdep.c | 2 +- > >> 2 files changed, 6 insertions(+), 1 deletion(-) > >> > >> diff --git a/gdb/ChangeLog b/gdb/ChangeLog > >> index 73d24d2c9d..f1ac925fec 100644 > >> --- a/gdb/ChangeLog > >> +++ b/gdb/ChangeLog > >> @@ -1,5 +1,10 @@ > >> 2017-04-11 John Baldwin > >> > >> + * mips-tdep.c (print_gp_register_row): Replace printf_filtered > >> + with fprintf_filtered. > >> + > >> +2017-04-11 John Baldwin > >> + > >> * mips-fbsd-tdep.c (MIPS_PC_REGNUM): Remove. > >> (MIPS_FP0_REGNUM): Remove. > >> (MIPS_FSR_REGNUM): Remove. > >> diff --git a/gdb/mips-tdep.c b/gdb/mips-tdep.c > >> index 41cb9d82c6..674b5098b0 100644 > >> --- a/gdb/mips-tdep.c > >> +++ b/gdb/mips-tdep.c > >> @@ -6539,7 +6539,7 @@ print_gp_register_row (struct ui_file *file, > >> struct frame_info *frame, > >> for (byte = 0; > >> byte < (mips_abi_regsize (gdbarch) > >> - register_size (gdbarch, regnum)); byte++) > >> - printf_filtered (" "); > >> + fprintf_filtered (file, " "); > >> /* Now print the register value in hex, endian order. */ > >> if (gdbarch_byte_order (gdbarch) == BFD_ENDIAN_BIG) > >> for (byte = > >> > > > > This one seems trivial enough. I have no comments. > > Agreed. This one's obviously correct. Please push it in. Pushed. I know we are still discussing patch 4, but are patches 1 and 2 in the V2 series ok to go in? I believe I addressed Luis' earlier feedback on those two patches. -- John Baldwin