From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102406 invoked by alias); 2 Nov 2017 13:20:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 101157 invoked by uid 89); 2 Nov 2017 13:20:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=sk:delete, shorten X-HELO: sessmg22.ericsson.net Received: from sessmg22.ericsson.net (HELO sessmg22.ericsson.net) (193.180.251.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 02 Nov 2017 13:20:32 +0000 Received: from ESESSHC003.ericsson.se (Unknown_Domain [153.88.183.27]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id 8C.BF.26775.D9B1BF95; Thu, 2 Nov 2017 14:20:29 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.27) with Microsoft SMTP Server (TLS) id 14.3.352.0; Thu, 2 Nov 2017 14:20:28 +0100 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; Received: from [142.133.48.133] (192.75.88.130) by AMSPR07MB312.eurprd07.prod.outlook.com (2a01:111:e400:802f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.197.4; Thu, 2 Nov 2017 13:20:26 +0000 Subject: Re: [PATCH 03/10] Make target_desc::features an std::vector To: Yao Qi CC: , Simon Marchi References: <1509414120-14659-1-git-send-email-simon.marchi@ericsson.com> <1509414120-14659-4-git-send-email-simon.marchi@ericsson.com> <868tfpxc3l.fsf@gmail.com> From: Simon Marchi Message-ID: <249cbd02-0ec3-63e0-1c3e-8946e261af82@ericsson.com> Date: Thu, 02 Nov 2017 13:20:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <868tfpxc3l.fsf@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: CY4PR18CA0054.namprd18.prod.outlook.com (2603:10b6:903:13f::16) To AMSPR07MB312.eurprd07.prod.outlook.com (2a01:111:e400:802f::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 06c8167e-4156-4aa0-8f83-08d521f47bbd X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603199);SRVR:AMSPR07MB312; X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB312;3:3EEObJvOQp1t0MwvJSNjq8pkgcGsQaUjgtkzwtnLzSwqcwyQxZHCPLMvk56DCoRDHaeO2BtdxZoVbCffWATwx/sqtd+UL6VfvtKBS7yWJG7mSVLHd7+/wPUUhGZhukwVfHELWgajHp0NCToASNq5LV3+zgm2NjBUecis4uv5HKNutSm+/0Oxx6EHOE7+RC+dxESamTBMfy2fi3QvVOVMlHLRo9dqxCmp7YYo1gyAJZfmL6USzUd+Jy98bfmrt5mZ;25:qaDq7d06avcaxII/cS8LKWMMmmd8/79U6JKzv9+BUe3OKGoQZ+hozkvzOfV80fsyXun8tqpnFfYw2iaLepRXgl4Ysxgd/1/xj3aXdepJQ3ZM0BAmTnLZQDzIOSkVkY8QoLOcx4lUtAQZw4yHbiyLdPE8G1l+Z7/Ff3evrbXlKizMXuwAtz23UbnGPEdjDCvcRymYU0YWXzEoNC0SeLkHrHS8I/QlLyfQDMmqHZfan1S/RgOt2fEVvt0tdV4v+6et5FbCT30q0tx2uFBTLnHmL1HTmGbVHIf/mlJFFTp1n1kcRhxCkVCuXFKGv8N2uDclQOk8LzWPbxroafcjiMEA7g==;31:CauoG3Lle2e2Zen2MOLDN2O98E3OiBMliDpIKOGB6aGoAKgwf5/0xjEWqHIYk51x90XAho6BKhY9W/jFhyQ5QsbxlUJ0Fz3wa0jLytaUH2IxDJ61lWm/SkYnwgS539yJTOFEcdy0JCsaCVMNokyFviKDX2GIcVAEw1IgpstcGXtN2ey0BeKpA1t2QLV2GLVbDqBZV1OcXcuTiz9dOIYVnRVQ+ezHTneNF5s1beaMIOo= X-MS-TrafficTypeDiagnostic: AMSPR07MB312: X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB312;20:o0DsTaPFd23Gqh8rN2MqT6tH2+g4hc/3Ff3pIa3vpmzxhJ3wMFsJ5Qj5opLnALDaWi507VjrNODMwGNYu51mkW90t91UZiRXqxIrzc58ygwDf7LHHrjHGh3xLHzM+0Ba2JRpNmuZgdMy4rPEoLrSHj9qmu466ueFg3ocB7fdXgrRjFyD7iNubpEWWVDz96dDfZnDkL+qV7YRml+zc06BNzn2ByuKmzdiFK6hkdA6j5EEJ4yJpaW7MJhMWofsLbyOAKDblz79g3E9MKcHQvumfviNQFCunU/9CRuyxMPHmiaXBL3TFkqxAkHVgoN2hP6RiMaODMoXYGpw4GtWelmejukayPW2ySfpWNCgD3DEKkPGAq92eFNF7jFwnsWoYwJDc7iuqFblQIGuWq7Wtq4o7ePf86dzFyPCWdRevs4HrExBQNFrM361cXffE+KZKhTcxo/WHcjq1CAGi0rO1u0JZqYilwBlGIJ+FIon9yC4GsaihJTyF9TuVI43OG/e7ws9;4:5PIrovOfFMpudQue1807+UF0bHAHOJJR7HwXvLz1NNJxYjSUjxGQ2s+Fr6tboHs3h2IIQSVOxxojuJYNmr0eiS4hd6CALcUBsDXyqCS1OfxKFi/JHkjjbUAHuWDD+fRWZ5Jt0luwQ96QJuGnlE/EBGX7GTvfDw9QGEP9Wh5kp8YS7C/UA0SEvFf7NSJcPQDDjc6HugX1vjpZ1+qK32bcMj9yssdlcVu2W7uXBxEMcolM17cf5B8FEV6gGWaC6kWh4XIj53cTVqKZyHP/xzCSLBHwjLDUFuvWHoMxBqoke7C8aUr+yKQE0StBky26Mgye X-Exchange-Antispam-Report-Test: UriScan:(37575265505322); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231020)(3002001)(100000703101)(100105400095)(10201501046)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(20161123560025)(20161123558100)(20161123562025)(20161123555025)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AMSPR07MB312;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AMSPR07MB312; X-Forefront-PRVS: 047999FF16 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(376002)(346002)(39860400002)(377424004)(189002)(199003)(24454002)(83506002)(50466002)(6246003)(64126003)(6116002)(3846002)(53936002)(8936002)(65826007)(97736004)(81166006)(36756003)(81156014)(8676002)(47776003)(86362001)(58126008)(53546010)(1411001)(65806001)(31696002)(65956001)(23676003)(49976008)(66066001)(25786009)(478600001)(305945005)(16576012)(7736002)(2870700001)(76176999)(39060400002)(5660300001)(54356999)(68736007)(316002)(50986999)(229853002)(6486002)(33646002)(31686004)(189998001)(2906002)(105586002)(106356001)(4326008)(2950100002)(6666003)(6916009)(16526018)(101416001)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:AMSPR07MB312;H:[142.133.48.133];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTVNQUjA3TUIzMTI7MjM6aW5lUVBBbGdmRzhFQTJJMTZHY1JuMFlJM0lI?= =?utf-8?B?dVh2N0hLTldOZ2p5enZXUStycWtEeG9YUmRDTGlWalEzNUI5b1hJdGNtUVVn?= =?utf-8?B?M04zaVM2VVN1WXhHQmU3bFVvWTNpN1FlRXh2RTA3MGx4UkdqSk1ydkc2R1VI?= =?utf-8?B?Mm9WemFtbCtEakJiT0JrbjdoVTZKVVdnWlJ4RFhpVHhiTUp2dFRyS3RQcnc2?= =?utf-8?B?YlZFUUhpaDRObjVvZ0FLcktHUTdWSGtwbnNLOGxDOSt4WkZONEtXNWs4UlRw?= =?utf-8?B?RGRBYzM0RC85QkMwYzZkV0JYbmNjVXkxaUVmMGJ0SEIwR2pWcGZUWEdxTCtU?= =?utf-8?B?eXJFQXpBaTBXTnAzRmZhTkVwU2Q5ZWh1YkxHanNZa2NndnhBb1ltelR0VVZy?= =?utf-8?B?WHJhbzM3cWtvS3dkRkNUMUY3WDRIZUJDa1NTYzdPeGhneE9ZWEtRcWVMZkNq?= =?utf-8?B?R2ZBWGZBeVVRSjF2TUdDSVhoS0ZNaTVXdlhxTkhrRzlBRVJsSTFvd0ZxMUpL?= =?utf-8?B?RVJDWXZJVDFXUGI4eGoxdStHZWJERzRPSE9hZWt2Q0lFTGY3Nk9Ua0NhNnQ3?= =?utf-8?B?b0JmZnVWOFZVUjVseCttQ2Z6UWtDM0ErZCtRSWhyUEpIb1V6UW5tNUtFTUlD?= =?utf-8?B?eHgvY1d2UXlvcXEwTEE0RitZTVdySjBoc0VEUVhxamNrY2Y3TnkyNUV2enV1?= =?utf-8?B?ZjZZQUZiNnlWTVh3Q1h1YVl5RkU0VEZHNklGV0Vud2ZqWDVsd2dyQ29lZ0dV?= =?utf-8?B?M0VLN0txbEF6anVGRmRkRlVSTHJFNDFEbVVlaHN5UjBNblhDSmQyRHdBb0xj?= =?utf-8?B?d2sxMXlkUGZMeVpJZS9YYWgvZTIvNnArYS9pc0tlSGFoeitVWHNZYWlneG92?= =?utf-8?B?bzdXOTVZdFlwbjBzbXQzWTkzRUdSYzVmRVM4aEhOV1FDb2h6VlEyc2NMQnZE?= =?utf-8?B?WFhVNm1mbndES09CUmVvZ1AxSmpTZ2x2YjM5UnhXS0E1RWI5YzZXc1FUMERF?= =?utf-8?B?bm16R3h3dnFXYWxoUThpS01xVWRjSkJMMW9SUGlJNzVvdDRSazJrVS9pS0hz?= =?utf-8?B?cUZZYmNBYjI3a0VZTlVuYzIyT2szNUt0S0VkWlp3dysxNjV0VlE2bjE2aDBB?= =?utf-8?B?cXI4ZDBUbDJOMFpWekZuWHZlVkp4ZEJVdDl5a1VEbVFXZ3F5WHdJbUZadGpF?= =?utf-8?B?RWJwRGpXRFZMK2JVVnJqRjJXWXhoMEJxL0ZCS2h5ZEJmRjVzS3d5QWRhaEsw?= =?utf-8?B?akk0TS9scmhzeHZqb0NJZFB4L0lQSTdyS2V1QXBiV2gwVzdTcmFTaVRGNDhz?= =?utf-8?B?RmR2Zy94TGxPUjJ1L21YODZSVUtRaG9ic3RHelp5ci9oQ2wzWGo1REtUMTJ0?= =?utf-8?B?b3ZiL1pFY08remhiRk8rU1pjWXRZMmNLT0d5dGhkYXBlRWNJcjZQUkFONk5F?= =?utf-8?B?OHdmclc0cy9kcTNjYUtrdm15cUNHYzV1RXFDSGFVNG93TU5mODhtS1JSNEJs?= =?utf-8?B?V3BlVHI3MnNWd09aak1yU1V3d2pleVd3Qy9iTkxvdDhpSU56ZHpUR3k4NWcv?= =?utf-8?B?VXBlbW5nVDdVaVFsTlV0NE9vOXJ4N2ZYdnZHWVVxU2JocXFwS0JXU2ZXcWN2?= =?utf-8?B?Y0M1RGdETTZMODZ1VEVUcjJJZ2dhdllrakdKNDUrK3lnYWxmOGVIbjl3TGpS?= =?utf-8?B?QW1FclUxVlg2Sy9MOWlpZ09IZlZoMEYzN3JHZkt5UUpDdFFkeFdVc2MwWEt2?= =?utf-8?B?cXdheUtkVlh2d2grNDd1WVRBRlV1YXZxT2xVWVh2SHp2ZEpEQlNWSjlNWi8x?= =?utf-8?B?K3UzbXlteW5qVUdCdDhEU1ZRQ3lINjI2NVJ6SldJZGZsUU84b0htK0JvNk9p?= =?utf-8?B?ODRFZ1lSd0dpQkhWZmp2K1V0SGYxb2gxYmMvMGg1di90SWJOcmM4RXdyT0Nv?= =?utf-8?Q?hl0Zai6gEYcSLxepFa3pxrvRQiU34=3D?= X-Microsoft-Exchange-Diagnostics: 1;AMSPR07MB312;6:HURv9RcJbMkh2L9JoRqDv3uUdw4L9pK7ENzYkinMsZANqAu7Lmkr3VWx1hW08T9jJ1T9qLJu06a0h8ikhrJQiVFWAAWMovd7FxW3FdG/N9Z7XXAjHDIkjXyHTU+GAIgjTPgZX86OFU1X7GtAjok+fYk0anQ5TVu7WTfHp2yFAs7LmmKV2rnELGWHCIXnZ/tR606i3ul301h5OW1+T5/cuT+7yrIJkgausNonbDk7SOsExvD3ZKrzNaxM17UaMMgt370/ps+WGVYwvESyTOq7404CVgdMdEnFsubdTUdht/qnhM4GZ4mqM2nyUydsRXxvXiDUNdYXI8lS7ROyYxx1e+XG1HXIFkxtT/8mfjoJXMY=;5:roh9TwuHjpv1CnN8am16CyWHqK1ailVbAHgO0TPYOGe5IHQpNVIAcrvhmnFM6NjOlFioqo+aj2RxQEo2s8KNoTYMS+Gqxgkice9inNEUde69m6dhNHts7Uc0Q4CHJ30H6Qav2Pc9g/Du8Xl1WurkZ05sgETx3Bd+kWCCvyqBIAU=;24:Xz7Ya2ZtcIzfl0pU+YRlbaO2um9q+UYbRYY5rEgod4o02Y2Zg1vNdvFiX8oO5VtAfNM4gr3wIkfaceaDKqwgVZEtYdQcdEawk6e44dm8uZo=;7:gNVtjBNOdro6bAMlEVX1ql5azpNV420KmZX4DTTIMK3fX+k7t7A4BJSAsLE3rqB2/z/mVwPYT3LtUxEwIRwBoHlE52idXI7Hcw2nZnnAI0m25m3bj3Wi6kh1mCG3sEAyLwxrTNX7PjiWHeCN9KKsZRvSR6DpSt0bsjmDQfatKKrS4rI1u6Q6JLE2quVdKsfJ6Zhak8JKba0ZnOhwBxxwlsFfQ8oYrsJWfyiZ9ylOQK92wYTTvHEYbyZBntBMKblz SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2017 13:20:26.4863 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 06c8167e-4156-4aa0-8f83-08d521f47bbd X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMSPR07MB312 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00026.txt.bz2 On 2017-11-02 05:29 AM, Yao Qi wrote: > Simon Marchi writes: > > Patch is good to me, two comments below, > >> +typedef std::unique_ptr tdesc_feature_up; >> >> /* A target description. */ >> >> @@ -393,17 +394,7 @@ struct target_desc : tdesc_element >> target_desc () >> {} >> >> - virtual ~target_desc () >> - { >> - struct tdesc_feature *feature; >> - int ix; >> - >> - for (ix = 0; >> - VEC_iterate (tdesc_feature_p, features, ix, feature); >> - ix++) >> - delete feature; >> - VEC_free (tdesc_feature_p, features); >> - } >> + virtual ~target_desc () = default; >> > > Can't we remove this line and use default (compiler generated) > dtor? If I do, I get the following error: /home/emaisin/src/binutils-gdb/gdb/target-descriptions.c: In function ‘void free_target_description(void*)’: /home/emaisin/src/binutils-gdb/gdb/target-descriptions.c:1714:10: error: deleting object of polymorphic class type ‘target_desc’ which has non-virtual destructor might cause undefined behaviour [-Werror=delete-non-virtual-dtor] Makefile:1929: recipe for target 'target-descriptions.o' failed delete target_desc; ^ >> target_desc (const target_desc &) = delete; >> void operator= (const target_desc &) = delete; >> @@ -422,17 +413,13 @@ struct target_desc : tdesc_element >> std::vector properties; >> >> /* The features associated with this target. */ >> - VEC(tdesc_feature_p) *features = NULL; >> + std::vector> features; >> > > std::vector features; > > shorten the code. Yes, I added the typedef later and forgot that instance. Thanks, I fixed that one locally. Simon