From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OyeRAJNF0GnBPgYAWB0awg (envelope-from ) for ; Fri, 03 Apr 2026 18:56:19 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=monnerat.net header.i=@monnerat.net header.a=rsa-sha256 header.s=mnet header.b=TyY1UyAq; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E414C1E08C; Fri, 03 Apr 2026 18:56:18 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HTML_MESSAGE,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 316B31E08C for ; Fri, 03 Apr 2026 18:56:18 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 302BE4BA9013 for ; Fri, 3 Apr 2026 22:56:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 302BE4BA9013 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=monnerat.net header.i=@monnerat.net header.a=rsa-sha256 header.s=mnet header.b=TyY1UyAq Received: from jupiter.monnerat.net (jupiter.monnerat.net [46.226.111.226]) by sourceware.org (Postfix) with ESMTPS id 3384A4BA23E6 for ; Fri, 3 Apr 2026 22:55:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3384A4BA23E6 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=monnerat.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=monnerat.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3384A4BA23E6 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=46.226.111.226 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775256953; cv=none; b=vI4c8Ebtf0Mk8nXVW5fPzV6GHbHks09dD773yVDcYz+vUU+IWEE2uP+3juwX2zRRAyfZLbGNN5Pl45HA85C7jrplycrYkjDiuWshKzww7XSnAlv4+ebEfjMhKyvrmVEhx5Oz/isVf+sWzARcVu7NcTw5GTka7Q1y4CKAGMLHEYo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775256953; c=relaxed/simple; bh=ODIRNu829woaAmnkQrI3cOcb03HgehU/Rbh8U6wqp2o=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=gwRvPhWlRIvEDYpbyy866HCdKqO3s8iKVk2UqcQzPjBDTCvOQCFKbJ/I+/D98cfKqJAateG7mTPXerVrDWnRyvvi6vb7LRxdaDIS6YSDa3F7dCbm55fexiIcTL2oVC4qt+u9mT9yGpPAsGYwJ/JiT6ZIqQ19Y1mk2+XDV84Snsg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3384A4BA23E6 Received: from [192.168.0.128] ([192.168.0.128]) by jupiter.monnerat.net (8.14.8/8.14.8) with ESMTP id 633Mtktc023198 (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256 verify=OK); Sat, 4 Apr 2026 00:55:51 +0200 DKIM-Filter: OpenDKIM Filter v2.10.3 jupiter.monnerat.net 633Mtktc023198 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=monnerat.net; s=mnet; t=1775256952; bh=ODIRNu829woaAmnkQrI3cOcb03HgehU/Rbh8U6wqp2o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=TyY1UyAqRUacO36L4pwkIkjCDai3a4qiT0bVUJrw2xg8hUr9deCpdGo9ZWQE9zeRP yvcblKyODDhStPrCnTO9q20yb+M2Fo8CIaOe7yYgs2A49qR2isuiFSqOpR4l0qGhHr h69eVIKolBG+odfkRF15I7vhObelaisY4/lYKT2k= Content-Type: multipart/alternative; boundary="------------5UfKYc0nhEmTSCjVlV6Sqz95" Message-ID: <24920a9e-7221-43f6-9a88-e768da712979@monnerat.net> Date: Sat, 4 Apr 2026 00:55:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: implement Tcl platform detection and improve private headers scan To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260402175844.74804-1-patrick@monnerat.net> <878qb34z8n.fsf@tromey.com> Content-Language: en-US From: Patrick Monnerat In-Reply-To: <878qb34z8n.fsf@tromey.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This is a multi-part message in MIME format. --------------5UfKYc0nhEmTSCjVlV6Sqz95 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/3/26 9:31 PM, Tom Tromey wrote: > Patrick> This is needed for recent TEA support. > Patrick> Autoconf macro CY_AC_TCL_PRIVATE_HEADERS checks more file locations and > Patrick> determines TCL_PLATFORM according to the private header files found. > Patrick> A C macro TCL_PLATFORM_DEFINE is computed accordingly and defined from > Patrick> command line. > > Patrick> The same applies to Tk. > > Patrick> As in-tree Tcl/Tk sources have been removed, this case is left out. > > Patrick> This change primarily targets Insight. > > Seeing as Insight is the only user of any of this, Yes, I think so too. I wonder if we can update configure.ac & Makefile.def to remove in-tree Tcl/Tk/Itcl/Itk/Iwidgets handling, as they are no more present and not supported by Insight since 2015. I have a patch for it: https://sourceware.org/git/?p=insight.git;a=blob;f=patches/binutils-gdb/001-itcltk4.patch;h=ce2ada59b48a08d251a6de9d713afd88390a7a05;hb=HEAD > I think it's fine and > up to you. > Approved-By: Tom Tromey > Thanks for approval, Tom. Will commit soon. Patrick --------------5UfKYc0nhEmTSCjVlV6Sqz95 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit


On 4/3/26 9:31 PM, Tom Tromey wrote: 
Patrick> This is needed for recent TEA support.
Patrick> Autoconf macro CY_AC_TCL_PRIVATE_HEADERS checks more file locations and
Patrick> determines TCL_PLATFORM according to the private header files found.
Patrick> A C macro TCL_PLATFORM_DEFINE is computed accordingly and defined from
Patrick> command line.

Patrick> The same applies to Tk.

Patrick> As in-tree Tcl/Tk sources have been removed, this case is left out.

Patrick> This change primarily targets Insight.

Seeing as Insight is the only user of any of this,

Yes, I think so too.

I wonder if we can update configure.ac & Makefile.def to remove in-tree Tcl/Tk/Itcl/Itk/Iwidgets handling, as they are no more present and not supported by Insight since 2015. I have a patch for it: https://sourceware.org/git/?p=insight.git;a=blob;f=patches/binutils-gdb/001-itcltk4.patch;h=ce2ada59b48a08d251a6de9d713afd88390a7a05;hb=HEAD

I think it's fine and
up to you.
Approved-By: Tom Tromey <tom@tromey.com>

Thanks for approval, Tom. Will commit soon.

Patrick

--------------5UfKYc0nhEmTSCjVlV6Sqz95--