Patrick> This is needed for recent TEA support. Patrick> Autoconf macro CY_AC_TCL_PRIVATE_HEADERS checks more file locations and Patrick> determines TCL_PLATFORM according to the private header files found. Patrick> A C macro TCL_PLATFORM_DEFINE is computed accordingly and defined from Patrick> command line. Patrick> The same applies to Tk. Patrick> As in-tree Tcl/Tk sources have been removed, this case is left out. Patrick> This change primarily targets Insight. Seeing as Insight is the only user of any of this,
Yes, I think so too.
I wonder if we can update configure.ac & Makefile.def to remove in-tree Tcl/Tk/Itcl/Itk/Iwidgets handling, as they are no more present and not supported by Insight since 2015. I have a patch for it: https://sourceware.org/git/?p=insight.git;a=blob;f=patches/binutils-gdb/001-itcltk4.patch;h=ce2ada59b48a08d251a6de9d713afd88390a7a05;hb=HEAD
I think it's fine and up to you. Approved-By: Tom Tromey <tom@tromey.com>
Thanks for approval, Tom. Will commit soon.
Patrick