From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44246 invoked by alias); 1 Mar 2019 14:10:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44237 invoked by uid 89); 1 Mar 2019 14:10:05 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=super X-HELO: mail-wm1-f68.google.com Received: from mail-wm1-f68.google.com (HELO mail-wm1-f68.google.com) (209.85.128.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 01 Mar 2019 14:10:04 +0000 Received: by mail-wm1-f68.google.com with SMTP id z84so12366461wmg.4 for ; Fri, 01 Mar 2019 06:10:03 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:4c97:6d52:2cea:997b? ([2001:8a0:f913:f700:4c97:6d52:2cea:997b]) by smtp.gmail.com with ESMTPSA id n6sm18237032wrt.23.2019.03.01.06.10.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Mar 2019 06:10:01 -0800 (PST) Subject: Re: [PATCH 00/16] Add styling to the gdb CLI and TUI To: Eli Zaretskii References: <20181128001435.12703-1-tom@tromey.com> <83k1kxfzwo.fsf@gnu.org> <8736rja4i8.fsf@tromey.com> <83r2f3caje.fsf@gnu.org> <87o9a61qvz.fsf@tromey.com> <7975162f-0b68-4826-6d6c-839d7953937d@redhat.com> <838sxyitq5.fsf@gnu.org> Cc: tom@tromey.com, gdb-patches@sourceware.org From: Pedro Alves Message-ID: <24893c9e-f1a1-f740-8e70-f3b134c298ed@redhat.com> Date: Fri, 01 Mar 2019 14:10:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <838sxyitq5.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-03/txt/msg00007.txt.bz2 On 03/01/2019 01:56 PM, Eli Zaretskii wrote: >> Cc: gdb-patches@sourceware.org >> From: Pedro Alves >> Basically, GDB needs to call SetConsoleMode with >> ENABLE_VIRTUAL_TERMINAL_PROCESSING at early startup to enable the feature. >> There's an example at the bottom of page [1] above. >> >> I have no idea whether that interacts badly with readline or curses, but >> it seems like the ideal solution going forward. > > We don't want to require Windows 10 for the styling support, do we? > Older versions of Windows still have quite a few years before they are > unsupported even by Microsoft, let alone GDB. I'm saying that there's an easy way out that likely gets you styling without much work. Over time, older versions of Windows will fade away. I'm comparing to the current state, where there's no styling at all. > Or are you saying that you will be unwilling to accept patches that > enable styling on all versions of Windows (by converting SGR sequences > to corresponding Windows API calls)? Of course not. If someone's willing to implement that, it's super fine with me. It's not unlike what Tom did for TUI / curses. Thanks, Pedro Alves