From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id C3eDAAruWmFdbgAAWB0awg (envelope-from ) for ; Mon, 04 Oct 2021 08:05:30 -0400 Received: by simark.ca (Postfix, from userid 112) id D2FCD1EE1A; Mon, 4 Oct 2021 08:05:29 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A816A1E813 for ; Mon, 4 Oct 2021 08:05:28 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EB745385840B for ; Mon, 4 Oct 2021 12:05:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EB745385840B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1633349128; bh=3aGwzDCgFPR3BUIwwqSG9zj6onKILYvAji0l/qcNCd4=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=r/TwFeWgp/V8x/YqWe1t/PZwmhfADG/+J8HGumcM97xOPi5GcCyWqrqgrP5JRzgMp Pnp1jaXJDeGU3QE5XdIeUz8omdJJZ4bNH7gaNgtndQD+8MBXFhdiCgPPRFchKf/yll S5//kIjNP6y5X29jern8QBRRITY6f2HT4zL6Qtl4= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id DC0063858408 for ; Mon, 4 Oct 2021 12:05:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DC0063858408 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 194C53Lq031324 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 4 Oct 2021 08:05:08 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 194C53Lq031324 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9E4D11E813; Mon, 4 Oct 2021 08:05:02 -0400 (EDT) Message-ID: <24809991-4982-9951-a7f7-514a2d01cd10@polymtl.ca> Date: Mon, 4 Oct 2021 08:05:01 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.1 Subject: Re: [PATCH 1/4] [gdb/symtab] Fix htab_find_slot call in read_call_site_scope Content-Language: en-US To: Tom de Vries , gdb-patches@sourceware.org References: <20211001123328.22314-1-tdevries@suse.de> <113a7cab-f06b-32ad-caa1-b0c87e67335b@polymtl.ca> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 4 Oct 2021 12:05:03 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >> Ah, I had not seen this comment. So it was on purpose. Still, I think >> that it makes it more confusing than anything. The patch LGTM. > > And, this follow-up commit reverts everything except the comment. > > Any comments? > > Thanks, > - Tom > Is there a problem with having the lookups done with just the pc? If we were to replace this with some C++ hash table, say std::unordered_map, it would be std::unordered_map. So doing the lookups using just the pc in the htab makes sense to me. Simon