From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118592 invoked by alias); 4 Jun 2018 12:19:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 118185 invoked by uid 89); 4 Jun 2018 12:19:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_20,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=sk:wstring, sk:Wstring, sk:DIAGNOS, H*f:sk:cde62c2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Jun 2018 12:19:37 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 274BF406E966; Mon, 4 Jun 2018 12:19:36 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 323B82166BB2; Mon, 4 Jun 2018 12:19:35 +0000 (UTC) Subject: Re: [PATCH 2/3] Add DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION To: Nick Clifton , "H.J. Lu" , Alan Modra References: <20180521121557.16535-1-hjl.tools@gmail.com> <20180521121557.16535-2-hjl.tools@gmail.com> <20180601101949.GA7660@bubble.grove.modra.org> <0d2578f3-f6c0-d19f-d036-fd07d1ff03d0@redhat.com> Cc: Binutils , GDB From: Pedro Alves Message-ID: <2478bdec-0e72-ac94-aa97-8004999feb6e@redhat.com> Date: Mon, 04 Jun 2018 12:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <0d2578f3-f6c0-d19f-d036-fd07d1ff03d0@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-06/txt/msg00054.txt.bz2 On 06/04/2018 01:13 PM, Nick Clifton wrote: > Hi H.J. > >> +# if __GNUC__ == 8 && __GNUC_MINOR__ < 2 >> +# define DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION \ >> + DIAGNOSTIC_IGNORE ("-Wstringop-truncation") >> +# endif >> >> OK for master? > > Approved - please apply. Please don't. This is again going against the intention of the header. The GCC version checks should be put in the places where the warning needs to be suppressed. The current patch makes all current and future uses of DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION only apply to GCC 8.1. That is incorrect. Consider what you will have to do to suppress some -Wstrinop-truncation warning with DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION on GCC 8.2 or GCC 9 or whatever. Also, you can use GCC_VERSION to make the version check a little simpler. Thanks, Pedro Alves