From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114069 invoked by alias); 27 Oct 2016 14:09:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 114039 invoked by uid 89); 27 Oct 2016 14:09:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=pr11022exp, UD:pr11022.exp, pr11022.exp, UD:break.exp X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Oct 2016 14:09:23 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B45B8C04B95A; Thu, 27 Oct 2016 14:09:21 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u9RE9Jn7009412; Thu, 27 Oct 2016 10:09:20 -0400 Subject: Re: [PATCH v5 2/2] PR 20569, segv in follow_exec To: Luis Machado , gdb-patches@sourceware.org References: <1477438784-16583-2-git-send-email-palves@redhat.com> <5de934fd-8ce5-9d97-75c2-61d7769b339d@codesourcery.com> Cc: Sandra Loosemore From: Pedro Alves Message-ID: <2477b680-67df-6de0-8dfe-8d0158295a29@redhat.com> Date: Thu, 27 Oct 2016 14:09:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-10/txt/msg00753.txt.bz2 On 10/26/2016 05:04 PM, Luis Machado wrote: > On 10/26/2016 09:28 AM, Luis Machado wrote: >> On 10/25/2016 06:39 PM, Pedro Alves wrote: >>> +# This test exercises PR20569. GDB would crash when attempting to >>> follow >>> +# an exec call when it could not resolve the path to the symbol file. >>> +# This was the case when an invalid sysroot is provided. >>> + >>> +standard_testfile foll-exec.c >>> + >>> +global binfile >>> +set binfile [standard_output_file "foll-exec"] > [FYI, I pushed this in already yesterday.] > On further inspection, i think this violates the testcase cookbook's > rules? It is reusing the foll-exec.c sources, but it should compile to a > unique executable name. > > On the other hand, foll-exec.c relies on its own name to do the trick. > It replaces foll-exec with execd-prog. > > Is this still a problem now that we have unique directories for each > testcase? Yeah, I think it's probably not such a big deal nowadays as it used to be. The case where it'd maybe still help a little bit is the remote host/target case. In that case, we'll still download the files to a single remote directory. We can't do parallel testing in that case, so the downside in general is that the overwriting may make it a bit harder to debug failing testcases after the fact. Maybe not that much of a problem, since we have the separate copies on the host side. We already have this overwriting on the target side in case we have tests with the same name in different gdb.foo/ subdirectories, I think: $ ls testsuite/gdb.*/*.exp | sed 's,testsuite/gdb.[a-z]*/,,g' | sort | uniq -c | sort -nr | head -n 30 3 types.exp 3 print.exp 3 gcore.exp 3 exprs.exp 2 vla-datatypes.exp 2 start.exp 2 solib-symbol.exp 2 solib.exp 2 sizeof.exp 2 range-stepping.exp 2 ptype.exp 2 pr11022.exp 2 pending.exp 2 methods.exp 2 maint.exp 2 logical.exp 2 integers.exp 2 hello.exp 2 exception.exp 2 demangle.exp 2 debug-expr.exp 2 data.exp 2 complex.exp 2 charset.exp 2 callfuncs.exp 2 break.exp 2 backtrace.exp 2 arrayidx.exp 2 annota3.exp 1 xfullpath.exp Thanks, Pedro Alves