From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 3BjFH7XHuGrlqQsAWB0awg (envelope-from ) for ; Sun, 27 Sep 2026 03:37:25 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=NESYApM/; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=gidjSpfl; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=x3Hdx23a; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=M/ujV6o+; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 583481E06B; Sun, 27 Sep 2026 03:37:25 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 70BBB1E033 for ; Sun, 27 Sep 2026 03:37:21 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 32AD14BA900B for ; Sun, 27 Sep 2026 07:37:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 32AD14BA900B Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=NESYApM/; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=gidjSpfl; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=x3Hdx23a; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=M/ujV6o+ Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 673794BA79BB for ; Sun, 27 Sep 2026 07:36:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 673794BA79BB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 673794BA79BB Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790494615; cv=none; b=aLhx6ZjIzbb/odvr9fVpFD+wk/lsdpjxOxpJ/VFd9GOSc4QmLzjxN+8u8TittyMrhro10waWWDBX77S+H1iFU3fb5Igh1TUi4smdd9imdSj/af0weIMoUIEi7JguRvel8JO79x4ERVSKIA7Quz3exJqqE8W9G7VpP8t8rYp8vDo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790494615; c=relaxed/simple; bh=x69aJe2uTCs7eH6zisnznuJc6MCo+kdO3ZY3FSIDC8A=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=u9p3Rkwy370a52xFrYF63PDGx5f7dKCl7zCS0IUMDBTVWZtp/sXHQWgVyRztAWqGGus2VpVIvcOsJ7q7sK6/k/hibI5YlDR9yjHVbbjRNZBTknDlihQY6tnMvq1tGEexx+6qUV0DYRxQKqEookcrUE6ZJ/dS6nHA5JkV8zr0C/w= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=NESYApM/; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=gidjSpfl; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=x3Hdx23a; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=M/ujV6o+ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 673794BA79BB Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 048611FB47 for ; Sun, 27 Sep 2026 07:36:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1790494610; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DDOLWfiuiP5oWwHdw8C1kZWFhQJVDDYpZ0swEfkBf8Q=; b=NESYApM/awsOL593Ie2qG6Hom5lcEp1ue3L6nedskPTeh2CLL4Y1/0TK5Kri1GfMpKb3fs LMxe0x0/i8z0zLjFG22Kml3xrLhHMlMMsEdKJwFOavCYr/cpkt1RisusrIMkxULvWlShMn 0zmeoBYkpygeMytCNOPYHmxBBXXa11Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1790494610; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DDOLWfiuiP5oWwHdw8C1kZWFhQJVDDYpZ0swEfkBf8Q=; b=gidjSpflxA8ohLhN5r2WNCjGi23G8t+MeUJAreF5+F490zLR7sc6kBCYjrdJiOJPZxrcqr JoJOR/3XDG5hOXBA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=x3Hdx23a; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="M/ujV6o+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1790494606; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DDOLWfiuiP5oWwHdw8C1kZWFhQJVDDYpZ0swEfkBf8Q=; b=x3Hdx23aic6BmXK/VEg54H2DHOsQ4BXEcaJs4tlGzEiKSGmJ2Kyh9i0ZyV2PVlIh3F+4i7 W+uzWRLEEcfNWMdboHNRApqVOfpFpja94MFOgN5T2Azw4Nmo16x2qUVSp5gWoeGzwcVtId /RdNRSpwKBjEkHgX9sZ6LU8VmyODpHU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1790494606; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DDOLWfiuiP5oWwHdw8C1kZWFhQJVDDYpZ0swEfkBf8Q=; b=M/ujV6o+j8pwuViKCoSPoTlBB+sxPtY4SkVg9V0hVrvnIElBCTYem/C8scf2fvMFWjyxgI 7G9ZiT9SacoWAfCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A371D13274 for ; Sun, 27 Sep 2026 07:36:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 1QGvF43HuGoNGgAAD6G6ig (envelope-from ) for ; Sun, 27 Sep 2026 07:36:45 +0000 Message-ID: <245f4247-4f34-4a04-b6d7-f7d1d6223838@suse.de> Date: Sun, 27 Sep 2026 09:36:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 3/5] [gdb/testsuite] Update regexp in string_to_regexp From: Tom de Vries To: gdb-patches@sourceware.org References: <20260904093858.359604-1-tdevries@suse.de> <20260904093858.359604-3-tdevries@suse.de> Content-Language: en-US In-Reply-To: <20260904093858.359604-3-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: 048611FB47 X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/4/26 11:38 AM, Tom de Vries wrote: > There are two similar regexps, in string_to_regexp and with_gdb_prompt: > ... > regsub -all {[]?*+.|(){}^$\[\\]} $str {\\&} result > regsub -all {[]*+.|()^$\[\\]} $prompt {\\&} prompt > ... > > In both cases, emacs tcl-mode has problems with it: auto indent doesn't > continue at column 4, but is reset to column 0. > > The first regexp is basically one big bracket expression containing the chars: > ... > ] ? * + . | ( ) { } ^ $ \[ \\ > ... > > There are a couple of ways that a ']' can be enclosed in a bracket > expression [1]: > - make it the first char > - escape using backslash > - make it a collating element > > The first solution was chosen, but confuses tcl-mode. > > Fix this by adding a backslash. > I've pushed this. Thanks, - Tom > [1] https://www.tcl-lang.org/man/tcl8.6/TclCmd/re_syntax.htm#M30 > --- > gdb/testsuite/lib/gdb-utils.exp | 4 +++- > gdb/testsuite/lib/gdb.exp | 4 +++- > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/gdb/testsuite/lib/gdb-utils.exp b/gdb/testsuite/lib/gdb-utils.exp > index cabeb7aa1ed..874de79e6d8 100644 > --- a/gdb/testsuite/lib/gdb-utils.exp > +++ b/gdb/testsuite/lib/gdb-utils.exp > @@ -36,7 +36,9 @@ proc gdb_init_commands {} { > > proc string_to_regexp {str} { > set result $str > - regsub -all {[]?*+.|(){}^$\[\\]} $str {\\&} result > + # We use a backslash to escape the closing square bracket, even if it's > + # the first character, to unconfuse emacs tcl-mode. > + regsub -all {[\]?*+.|(){}^$\[\\]} $str {\\&} result > return $result > } > > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index d4a471ff7c4..b0a4cc1b39f 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -3650,7 +3650,9 @@ proc with_gdb_prompt { prompt body } { > # we start recording both forms separately instead of just $gdb_prompt. > # The testsuite is pretty-much hardwired to interpret $gdb_prompt as the > # regexp form. > - regsub -all {[]*+.|()^$\[\\]} $prompt {\\&} prompt > + # We use a backslash to escape the closing square bracket, even if it's > + # the first character, to unconfuse emacs tcl-mode. > + regsub -all {[\]*+.|()^$\[\\]} $prompt {\\&} prompt > > set saved $gdb_prompt >