From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47809 invoked by alias); 11 Jan 2019 21:07:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47796 invoked by uid 89); 11 Jan 2019 21:07:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,MIME_BASE64_BLANKS autolearn=ham version=3.3.2 spammy=cry X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 11 Jan 2019 21:07:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/relaxed; q=dns/txt; i=@ericsson.com; t=1547240846; x=1549832846; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=w+kEu6g6AdVgIzWrbK7vSFwbN1XudTbzEVs3j0+g24o=; b=BPIVAcKeDfwXLNFJDiiJmjKLYGYfO+q6rcjqUCgaxBBHG3NmPzf3BRv8mK9zes4c l8PQETy/+xjySbDxRCvDZKwl3wdL7dNKlwZvjBOmVZq4SLPEQa1IFLuocVUXv1QT aFhJ67Zmr6l9nZSLaKPF9JUH+x7QRVDG7FcYImsOCps=; Received: from ESESSMB501.ericsson.se (Unknown_Domain [153.88.183.119]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id 74.42.13660.E85093C5; Fri, 11 Jan 2019 22:07:26 +0100 (CET) Received: from ESESBMB505.ericsson.se (153.88.183.172) by ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Fri, 11 Jan 2019 22:07:26 +0100 Received: from NAM01-BY2-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB505.ericsson.se (153.88.183.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Fri, 11 Jan 2019 22:07:25 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w+kEu6g6AdVgIzWrbK7vSFwbN1XudTbzEVs3j0+g24o=; b=EMPp/ODMfaFZ3gO8/SZ/ZWL5IaebB9HCwq0Tu5dLuInn9YjqdwzdGY/rodgZ6Z8lPhn35t3Hk34gXLLwaadijOEIRhA099uiQWeRb3JieczKmwLOFSp+Mj0GrUvn2Vqptr+z7z5jI7jZSeXcviMnqVOhJwTlKqXwEpZWH+JB9u4= Received: from BYAPR15MB2390.namprd15.prod.outlook.com (52.135.198.30) by BYAPR15MB2872.namprd15.prod.outlook.com (20.178.206.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1516.14; Fri, 11 Jan 2019 21:07:14 +0000 Received: from BYAPR15MB2390.namprd15.prod.outlook.com ([fe80::a4b4:ea6a:6321:191e]) by BYAPR15MB2390.namprd15.prod.outlook.com ([fe80::a4b4:ea6a:6321:191e%4]) with mapi id 15.20.1516.016; Fri, 11 Jan 2019 21:07:14 +0000 From: Simon Marchi To: Andrew Burgess CC: "gdb-patches@sourceware.org" , "palves@redhat.com" Subject: Re: [PATCH] Fix MI output for multi-location breakpoints Date: Fri, 11 Jan 2019 21:07:00 -0000 Message-ID: <23d3560d-3989-e742-9bf9-d39db045d622@ericsson.com> References: <20190111001516.4761-1-simon.marchi@ericsson.com> <20190111123420.GI3456@embecosm.com> In-Reply-To: <20190111123420.GI3456@embecosm.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) Content-Type: text/plain; charset="utf-8" Content-ID: <4350396057DDC74C99887D1505774A05@namprd15.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Return-Path: simon.marchi@ericsson.com X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00256.txt.bz2 T24gMjAxOS0wMS0xMSA3OjM0IGEubS4sIEFuZHJldyBCdXJnZXNzIHdyb3Rl Og0KPiAqIFNpbW9uIE1hcmNoaSA8c2ltb24ubWFyY2hpQGVyaWNzc29uLmNv bT4gWzIwMTktMDEtMTEgMDA6MTU6MzQgKzAwMDBdOg0KPiANCj4+IFtDQ2lu ZyBQZWRybyBiZWNhdXNlIHdlIGhhZCBzb21lIGRpc2N1c3Npb25zIGVhcmxp ZXIgYWJvdXQgdGhhdCBvZmZsaW5lXQ0KPj4NCj4+IFZhcmlvdXMgTUkgY29t bWFuZHMgb3IgZXZlbnRzIHJlbGF0ZWQgdG8gYnJlYWtwb2ludHMgb3V0cHV0 IGludmFsaWQgTUkNCj4+IHJlY29yZHMgd2hlbiBwcmludGluZyBpbmZvcm1h dGlvbiBhYm91dCBhIG11bHRpLWxvY2F0aW9uIGJyZWFrcG9pbnQuDQo+PiBG b3IgZXhhbXBsZToNCj4+DQo+PiAgICAgLWJyZWFrLWluc2VydCBhbGxvDQo+ PiAgICAgXmRvbmUsYmtwdD17Li4uLGFkZHI9IjxNVUxUSVBMRT4iLC4uLn0s e251bWJlcj0iMS4xIiwuLi59LHtudW1iZXI9IjEuMiIsLi4ufQ0KPj4NCj4+ IFRoZSBwcm9ibGVtIGlzIHRoYXQgYWNjb3JkaW5nIHRvIHRoZSBzeW50YXgg WzFdLCB0aGUgdG9wLWxldmVsIGVsZW1lbnRzDQo+PiBhcmUgb2YgdHlwZSAi cmVzdWx0IiBhbmQgc2hvdWxkIGJlIG9mIHRoZSBmb3JtICJ2YXJpYWJsZT12 YWx1ZSIuDQo+Pg0KPj4gVGhpcyBwYXRjaCBjaGFuZ2VzIHRoZSBvdXRwdXQg dG8gd3JhcCB0aGUgbG9jYXRpb25zIGluIGEgbGlzdDoNCj4+DQo+PiAgICAg XmRvbmUsYmtwdD17Li4uLGFkZHI9IjxNVUxUSVBMRT4iLC4uLn0sbG9jYXRp b25zPVt7bnVtYmVyPSIxLjEiLC4uLn0se251bWJlcj0iMS4yIiwuLi59XQ0K Pj4NCj4+IFRoZSBldmVudHMgPWJyZWFrcG9pbnQtY3JlYXRlZCwgPWJyZWFr cG9pbnQtbW9kaWZpZWQsIGFzIHdlbGwgYXMgdGhlDQo+PiAtYnJlYWstaW5m byBjb21tYW5kIGFsc28gc3VmZmVyIGZyb20gdGhpcyAoYW5kIG1heWJlIG90 aGVycyBJIGRpZG4ndA0KPj4gZmluZCkuDQo+Pg0KPj4gU2luY2UgdGhpcyBp cyBhIGJyZWFraW5nIGNoYW5nZSBmb3IgTUksIHdlIGhhdmUgdG8gZGVhbCBz b21laG93IHdpdGgNCj4+IGJhY2t3YXJkcyBjb21wYXRpYmlsaXR5LiAgVGhl IGFwcHJvYWNoIHRha2VuIGJ5IHRoaXMgcGF0Y2ggaXMgdG8gYnVtcA0KPj4g dGhlIE1JIHZlcnNpb24sIHVzZSB0aGUgbmV3IHN5bnRheCBpbiBNSTMgd2hp bGUgcmV0YWluaW5nIHRoZSBvbGQgc3ludGF4DQo+PiBpbiBNSTIuICBGcm9u dGVuZHMgYXJlIGV4cGVjdGVkIHRvIHVzZSBhIHByZWNpc2UgTUkgdmVyc2lv biAoLWk9bWkyKSwgc28NCj4+IGlmIHRoZXkgZG8gdGhhdCB0aGV5IHNob3Vs ZCBiZSB1bmFmZmVjdGVkLg0KPj4NCj4+IE15IHByZXZpb3VzIGF0dGVtcHRz IG9mIHRoaXMgcGF0Y2ggKG5vdCBwdWJsaXNoZWQpIGludHJvZHVjZWQgbmV3 DQo+PiBjb21tYW5kcyAoLWJyZWFrLWluc2VydDIsIC1icmVhay1pbmZvMikg b3IgYSBmbGFnIHRvIHRoZSBvcmlnaW5hbA0KPj4gY29tbWFuZHMgdG8gbWFr ZSB0aGVtIG91dHB1dCB0aGUgZml4ZWQgc3ludGF4LiAgVGhhdCBkb2Vzbid0 IHJlYWxseSB3b3JrDQo+PiBiZWNhdXNlIGFzeW5jIGV2ZW50cyBuZWVkIHRv IGJlIGZpeGVkIHRvby4NCj4+DQo+PiBBbm90aGVyIHNvbHV0aW9uIHdvdWxk IGJlIHRvIGhhdmUgYSBzZXR0aW5nIG9yIGNvbW1hbmQNCj4+ICgtdXNlLWZp eGVkLWJyZWFrcG9pbnQtb3V0cHV0KSB0byBlbmFibGUgdGhlIGZpeGVkIG91 dHB1dCwga2VlcGluZyB0aGUNCj4+IGJyb2tlbiBvbmUgYnkgZGVmYXVsdC4g IFRoZSBvbmx5IHRoaW5nIEkgZG9uJ3QgbGlrZSBhYm91dCB0aGF0IGlzIHRo YXQNCj4+IHdlIHdpbGwga2VlcCB0aGUgYnJva2VuIGJlaGF2aW9yIGJ5IGRl ZmF1bHQsIHdoaWNoIG1lYW5zIHRoYXQgc29tZWJvZHkNCj4+IHdyaXRpbmcg YSBmcm9udGVuZCB3aG8gaXMgbm90IGF3YXJlIG9mIHRoYXQgZ290Y2hhIHdp bGwgZ28gdGhyb3VnaCB0aGUNCj4+IHRyb3VibGUgb2Ygc3R1bWJsaW5nIG9u IGJyb2tlbiBNSSBvdXRwdXQsIGFuZCB0aGVuIGhvcGVmdWxseSBkaXNjb3Zl cg0KPj4gdGhhdCB0aGVyZSBpcyBhIGNvbW1hbmQgdG8gdW4tYnJlYWsgaXQu ICBJIGFsc28gZG9uJ3Qgc2VlIGFuIGVhc3kgd2F5IHRvDQo+PiBkZXByZWNh dGUgYW5kIHJlbW92ZSB0aGUgb2xkIG91dHB1dCBvdmVyIHRpbWUgdXNpbmcg dGhpcyBzdHJhdGVneS4gIFdpdGgNCj4+IGEgbmV3IE1JIHZlcnNpb24sIHNv bWVib2R5IHN0YXJ0aW5nIGZyb20gc2NyYXRjaCB3aWxsIHVzZSB0aGUgbGF0 ZXN0IE1JDQo+PiB2ZXJzaW9uIGF2YWlsYWJsZSwgYW5kIHRoZXJlZm9yZSB0 aGUgZml4ZWQgdmVyc2lvbi4gIEFsc28sIHdlIGNhbg0KPj4gZGVwcmVjYXRl IGFuZCB0aGVuIHJlbW92ZSBvbGQgTUkgdmVyc2lvbnMgYWZ0ZXIsIGxldCdz IHNheSwgNSB5ZWFycyBvZiBhDQo+PiBuZXdlciB2ZXJzaW9uIGJlaW5nIGF2 YWlsYWJsZS4NCj4gDQo+IEkgdGhpbmsgZml4aW5nIGlzc3VlcyBsaWtlIHRo aXMgaXMgYSBnb29kIHRoaW5nLCBidXQgSSB3b25kZXIgaWYgd2UNCj4gc2hv dWxkIG1vdmUgYSBsaXR0bGUgc2xvd2VyLg0KPiANCj4gV2l0aCB0aGUgbmV4 dCByZWxlYXNlIG9ubHkgZGF5cyBhd2F5LCBjb3VsZCB3ZSBub3QgaW5jbHVk ZSB0aGlzIGZpeA0KPiBmb3IgdGhlIHJlbGVhc2UsIGJ1dCBsZWF2ZSBNSTIg YXMgdGhlIGRlZmF1bHQuDQo+IA0KPiBNSTMgd291bGQgc3RpbGwgZXhpc3Qs IGFuZCBpbmNsdWRlIHRoZSBmaXgsIGJ1dCB3b3VsZCBiZSBkb2N1bWVudGVk IGFzDQo+IHVuc3RhYmxlLCBvciB1bmRlci1kZXZlbG9wbWVudCwgd2l0aCB0 aGUgY2F2ZWF0IHRoYXQgdGhpbmdzIGNvdWxkDQo+IGNoYW5nZSBpbiB0aGUg TUkzIG91dHB1dC4NCj4gDQo+IFRoZW4gYmV0d2VlbiB0aGUgbmV4dCByZWxl YXNlIChmZXcgZGF5cykgYW5kIHRoZSByZWxlYXNlIGFmdGVyICh+Ng0KPiBt b250aHM/KSB3ZSBjYW4gZ28gY3JhenkgbG9va2luZyBmb3IgTUkgZml4ZXMu ICBUaGVuIGJlZm9yZSB0aGUgbmV4dA0KPiByZWxlYXNlIHdlIGJ1bXAgdGhl IGRlZmF1bHQgdmVyc2lvbiB0byBNSTMuDQoNClRoYXQncyB3aGF0IEkgaW50 ZW5kZWQgKEkgc2hvdWxkIGhhdmUgbm90ZWQgaXQgaW4gbXkgb3JpZ2luYWwg bWVzc2FnZSksIHRvDQpoYXZlIHRoaXMgbWVyZ2UgcG9zdC04LjMuICBJdCxz IGJlZW4gYnJva2VuIGZvciAxMiB5ZWFycywgbm9ib2R5IHdpbGwgY3J5DQpp ZiA4LjMgc3RpbGwgaGFzIHRoaXMgYnVnLg0KDQo+IA0KPiBVSSBkZXZlbG9w ZXJzIGNhbiBzdGlsbCB1c2UgTUkyIHVudGlsIHRoZXkgc3dpdGNoIHRvIE1J MywgYnV0LCB3aGVuDQo+IHRoZXkgZG8gc3dpdGNoIHRvIE1JMyB0aGV5IGdl dCBtb3JlIGZpeGVzIHRoYW4ganVzdCBvbmUgaXRlbS4NCj4gDQo+IEZ1cnRo ZXIsIEkgdGhpbmsgd2Ugc2hvdWxkIG1ha2UgdGhlIGxpdmVzIG9mIFVJIGRl dmVsb3BlcnMgZWFzaWVyLCBidXQNCj4gaGF2aW5nIGFuIGV4cGxpY2l0IGxp c3QgaW4gdGhlIGRvY3VtZW50YXRpb24gb2Ygd2hhdCBjaGFuZ2VkIGJldHdl ZW4NCj4gTUkgdmVyc2lvbnMgKHN0YXJ0aW5nIGZyb20gTUkyIC0+IE1JMykg aW5jbHVkaW5nIGV4YW1wbGVzLiAgWWVzIHdlDQo+IGhhdmUgdGhlIE5FV1Mg ZmlsZSwgYnV0IChteSBwZXJzb25hbCBvcGluaW9uKSB0aGUgZG9jcyBzaG91 bGQgc3RhbmQgb24NCj4gdGhlaXIgb3duIGZvciB0aGVzZSBzb3J0IG9mIGNo YW5nZXMuDQoNCkFncmVlZCwgaXQncyBkb2N1bWVudGF0aW9uIHRoYXQgc2hv dWxkIGJlIGtlcHQgYWNyb3NzIHJlbGVhc2VzIChzbywgaW4gdGhlDQpkb2Mp LCBiZWNhdXNlIGZyb250ZW5kIGRldmVsb3BlcnMgbWF5IHVwZ3JhZGUgZnJv bSBtaTIgdG8gbWkzIGEgZmV3IHZlcnNpb25zDQppbiB0aGUgZnV0dXJlLCBh bmQgd2Ugd2FudCB0aGUgaW5mbyBhYm91dCB0aGUgYmFja3dhcmRzLWluY29t cGF0aWJsZSBjaGFuZ2VzDQphbGwgaW4gb25lIHBsYWNlLg0KDQo+IFRoZSBh Ym92ZSBvbmx5IHJlYWxseSBtYWtlcyBzZW5zZSBpZiB3ZSB0aGluayB0aGVy ZSBtaWdodCBiZSBvdGhlcg0KPiBpc3N1ZXMgdGhhdCBjb3VsZCBiZW5lZml0 IGZyb20gYmVpbmcgZml4ZWQgaW4gdGhlIE1JLiAgSWYgd2UgcmVhbGx5DQo+ IGZlZWwgdGhpcyBpcyB0aGUgb25seSBidWcgb3V0IHRoZXJlLCB0aGVuIG1h eWJlIHdlIHNob3VsZCBqdXN0IHB1c2gNCj4gYWhlYWQgd2l0aCB0aGlzIHBh dGNoIGFzIGlzLi4uDQoNCkFzIGFuIGV4YW1wbGUsIEkgd291bGQgYmUgY29u c2lkZXJpbmcgZ2V0dGluZyByaWQgb2YgQnJlYWtwb2ludFRhYmxlIGluIHRo ZQ0KLWJyZWFrLWxpc3Qgb3V0cHV0Lg0KDQo+IEluIHN1bW1hcnksIEkgdGhp bmsgd2Ugc2hvdWxkOg0KPiANCj4gICAxLiBNZXJnZSB0aGlzIHBhdGNoLCBi dXQgbGVhdmUgTUkyIHRoZSBkZWZhdWx0LCBhZGQgYSBuZXcgc2VjdGlvbiB0 bw0KPiAgIHRoZSBkb2NzIGxpc3RpbmcgIkNoYW5nZXMgQmV0d2VlbiBNSTIg YW5kIE1JMyIuDQo+IA0KPiAgIDIuIENoYW5nZSBHREIgc28gdGhhdCB3aGVu IGEgdXNlciBzdGFydHMgd2l0aCAtaT1taTMgdGhleSBnZXQgYQ0KPiAgIHdh cm5pbmcgdGhhdCB0aGlzIHZlcnNpb24gb2YgdGhlIE1JIGlzIHVuZGVyIGRl dmVsb3BtZW50LCBhbmQgbGlhYmxlDQo+ICAgdG8gY2hhbmdlLCB0aGlzIHNo b3VsZCBiZSBkb2N1bWVudGVkIHRvby4NCj4gDQo+ICAgMy4gQmV0d2VlbiBu b3cgYW5kIHRoZSBuZXh0ICsgMSByZWxlYXNlIHdlIHNob3VsZCBmaW5kIGFu ZCBmaXggYXMNCj4gICBtYW55IE1JIGJ1Z3MgYXMgcG9zc2libGUsIGRvY3Vt ZW50aW5nIGVhY2guDQo+IA0KPiAgIDQuIEp1c3QgYmVmb3JlIHRoZSBuZXh0 ICsgMSByZWxlYXNlIHdlIHNob3VsZCBtYWtlIE1JMyB0aGUgZGVmYXVsdCwN Cj4gICBjcmVhdGUgTUk0LCBhbmQgbWFyayBNSTQgYXMgInVuc3RhYmxlIi4N Cj4gDQo+ICAgNS4gKE9wdGlvbmFsKSBNYXliZSwgb2ZmaWNpYWxseSBtYXJr IE1JMSBhcyBkZXByZWNhdGVkLCBhbmQgbm90ZQ0KPiAgIHRoYXQgaXQgd2ls bCBiZSByZW1vdmVkIGF0IHNvbWUgcG9pbnQuDQoNClllcyB0aGF0IG1ha2Vz IHNlbnNlLiAgRXhjZXB0IHRoYXQgSSB3b3VsZCBtZXJnZSB0aGlzIHBhdGNo IGFmdGVyIHRoZSA4LjMNCmJyYW5jaCBjcmVhdGlvbiAodW50aWwgdGhlcmUn cyBhIGNvbXBlbGxpbmcgcmVhc29uIHRvIGhhdmUgaXQgaW4gOC4zKS4NCg0K U2ltb24NCg== >From gdb-patches-return-153367-listarch-gdb-patches=sources.redhat.com@sourceware.org Fri Jan 11 21:17:16 2019 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 21332 invoked by alias); 11 Jan 2019 21:17:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 21320 invoked by uid 89); 11 Jan 2019 21:17:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=BAYES_00,GIT_PATCH_1,SPF_PASS autolearn=ham version=3.3.2 spammy=xy, disagree, cater X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 11 Jan 2019 21:17:13 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gi4Aw-0007xJ-Ph; Fri, 11 Jan 2019 16:17:10 -0500 Received: from [176.228.60.248] (port=4481 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gi4Aw-0001JM-DI; Fri, 11 Jan 2019 16:17:10 -0500 Date: Fri, 11 Jan 2019 21:17:00 -0000 Message-Id: <83y37qgail.fsf@gnu.org> From: Eli Zaretskii To: Simon Marchi CC: gdb-patches@sourceware.org, palves@redhat.com In-reply-to: <7cf31d37-3931-bbac-07f2-c61f57be142c@ericsson.com> (message from Simon Marchi on Fri, 11 Jan 2019 20:21:22 +0000) Subject: Re: [PATCH] Fix MI output for multi-location breakpoints References: <20190111001516.4761-1-simon.marchi@ericsson.com> <83lg3rhb6r.fsf@gnu.org> <7cf31d37-3931-bbac-07f2-c61f57be142c@ericsson.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00257.txt.bz2 Content-length: 5490 > From: Simon Marchi > CC: "gdb-patches@sourceware.org" , > "palves@redhat.com" > Date: Fri, 11 Jan 2019 20:21:22 +0000 > > >> gdb/doc/ChangeLog: > >> > >> * gdb.texinfo (Choosing Modes): Mention mi3. > >> (Command Interpreters): Likewise. > > > > You seem to be using the chapter/section names in the parentheses. > > You should be using node names instead (or use Emacs, which will do > > that for you ;-). > > Oh, that's what I have always done! Is this better? > > * gdb.texinfo (Mode Options): Mention mi3. > (Interpreters): Likewise. Yes, of course. > >> -@samp{--interpreter=mi} (or @samp{--interpreter=mi2}) causes > >> +@samp{--interpreter=mi} (or @samp{--interpreter=mi3}) causes > >> @value{GDBN} to use the @dfn{@sc{gdb/mi} interface} (@pxref{GDB/MI, , > >> -The @sc{gdb/mi} Interface}) included since @value{GDBN} version 6.0. The > >> -previous @sc{gdb/mi} interface, included in @value{GDBN} version 5.3 and > >> -selected with @samp{--interpreter=mi1}, is deprecated. Earlier > >> -@sc{gdb/mi} interfaces are no longer supported. > >> +The @sc{gdb/mi} Interface}). The @sc{gdb/mi} interfaces 1 and 2 are > >> +available, but deprecated. Earlier @sc{gdb/mi} interfaces are no > >> +longer available. > > > > Please don't remove the version information from this text. At the > > very least, we should tell what GDB version introduced the latest mi3 > > syntax. We should tell this here, and not only in the "Interpreters" > > node, because this section is a concise list of invocation options, > > and should include the important information without sending the > > reader to read the more detailed parts. > > The reason I thought this was not really appropriate here is that this manual > applies to a particular version of GDB (e.g. it's the manual shipped with > GDB 9.1). So if you are using that version of GDB, it doesn't really matter > which version of GDB introduced mi3, all that matters is that it exists now. People read newer manuals even if they have older versions of GDB available. E.g., I have on my development system all the versions of GDB since v6.3, but only one version of the manual, the latest one. Since Texinfo doesn't provide a way of installing several versions of the same manual side by side, we should assume that my situation is quite typical. So let's not assume that when one reads a manual for GDB X.Y they are interested only in that GDB version. > As you said, this section is a concise list of invocation options. But I don't > consider this very important information to have at the fingertips. I respectfully disagree. A manual is more often than not read as a reference, where the reader wants to quickly find the information they are after, and stop reading right after that. We should cater to such usage of the manual, since it's IME the most important use. > As Andrew suggested, I think we should have a list or table of all mi versions, > when they were introduced, and what the breaking changes are. This would help > people writing or upgrading their MI frontend. But I don't think that the > casual user looking for the possible command line flags will need to know the > history of MI. I'm okay with adding a detailed table elsewhere, but I don't think it's a good idea to remove the above information from the description of the -mi command-line switch. > Finally, the goal is to reduce the duplication of information, so there is less > things to update when releasing a new MI version (therefore less chance of having > outdated information). That is not the main goal, though. The main goal is to produce a useful manual that allows finding the information one needs quickly and efficiently. > >> +@item mi3 > >> +@cindex mi3 interpreter > >> +The @sc{gdb/mi} interface introduced in @value{GDBN} 9. It is the latest > > ^^^^^^^^^^^^^^ > > GDB 9.1, presumably? > > Right. Then let's say that. > >> @item mi1 > >> @cindex mi1 interpreter > >> -The @sc{gdb/mi} interface included in @value{GDBN} 5.1, 5.2, and 5.3. > >> +The @sc{gdb/mi} interface introduced in @value{GDBN} 5.1. > > > > I think the old text is better. > > The problem I see with the current wording is that it implies that mi1 is included > in version 5.1, 5.2 and 5.3 only. That's not my interpretation of "included in". > In reality, it's included in all versions from 5.1 and up. So it > seems odd to list 5.2 and 5.3 specifically. Do you have a > suggestion to address this? Say "used by" instead of "included in"? > > P.S. I wonder how did we let this problem slip through the cracks when > > multiple-location breakpoints were introduced? Maybe we should do > > something to avoid such mistakes in the future. We really shouldn't > > be changing the MI syntax in incompatible ways so late into GDB > > development cycle. > > Well it's been known for a long time, as shows this bug from 2008 (AFAIU, > multiple location breakpoints were introduced around 2007?): > > https://sourceware.org/bugzilla/show_bug.cgi?id=9659 > > I've been meaning to fix this for a few years, but always put it aside (until now) > because of the headache introducing backwards-incompatible MI changes represents. That's not what bothered me. What bothered me was that we released a GDB with this MI syntax without fixing it first. I'm wondering how to prevent such mistakes in the future.