From: Simon Marchi <simark@simark.ca>
To: Alan Hayward <alan.hayward@arm.com>, gdb-patches@sourceware.org
Cc: nd@arm.com
Subject: Re: [PATCH v5 4/8] Add tdesc osabi and architecture functions
Date: Wed, 18 Apr 2018 02:10:00 -0000 [thread overview]
Message-ID: <238ddcb5-af90-5c38-fc01-bb407c4b31aa@simark.ca> (raw)
In-Reply-To: <20180410143337.71768-5-alan.hayward@arm.com>
Hi Alan,
Just a nit:
On 2018-04-10 10:33 AM, Alan Hayward wrote:
> diff --git a/gdb/common/tdesc.h b/gdb/common/tdesc.h
> index 7f4222b653..311341da0d 100644
> --- a/gdb/common/tdesc.h
> +++ b/gdb/common/tdesc.h
> @@ -297,9 +297,18 @@ target_desc *allocate_target_description (void);
> void set_tdesc_architecture (target_desc *target_desc,
> const char *name);
>
> +/* Return the architecture associated with this target description as a string,
> + or NULL if no architecture was specified. */
> +const char *tdesc_architecture_name (const struct target_desc *target_desc);
> +
> /* Set TARGET_DESC's osabi by NAME. */
> void set_tdesc_osabi (target_desc *target_desc, const char *name);
>
> +/* Return the osabi associated with this target description as a string,
> + or NULL if no osabi was specified. */
> +const char *
> +tdesc_osabi_name (const struct target_desc *target_desc);
Remove the \n before the function name.
Simon
next prev parent reply other threads:[~2018-04-18 2:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 14:34 [PATCH v5 0/8] Remove gdbserver dependency on xml files Alan Hayward
2018-04-10 14:34 ` [PATCH v5 7/8] Remove xml file references from target descriptions Alan Hayward
2018-04-10 14:34 ` [PATCH v5 2/8] Commonise tdesc_feature Alan Hayward
2018-04-10 14:34 ` [PATCH v5 8/8] Remove xml files from gdbserver Alan Hayward
2018-04-10 14:34 ` [PATCH v5 6/8] Create xml from target descriptions Alan Hayward
2018-04-18 2:43 ` Simon Marchi
2018-04-18 21:26 ` Alan Hayward
2018-04-10 14:34 ` [PATCH v5 5/8] Add feature reference in .dat files Alan Hayward
2018-04-10 14:34 ` [PATCH v5 1/8] Commonise tdesc_reg Alan Hayward
2018-04-18 1:57 ` Simon Marchi
2018-04-18 9:03 ` Alan Hayward
2018-04-18 13:54 ` Simon Marchi
2018-04-10 14:34 ` [PATCH v5 3/8] Commonise tdesc types Alan Hayward
2018-04-10 14:34 ` [PATCH v5 4/8] Add tdesc osabi and architecture functions Alan Hayward
2018-04-18 2:10 ` Simon Marchi [this message]
2018-04-18 2:49 ` [PATCH v5 0/8] Remove gdbserver dependency on xml files Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=238ddcb5-af90-5c38-fc01-bb407c4b31aa@simark.ca \
--to=simark@simark.ca \
--cc=alan.hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox