From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sa-prd-fep-040.btinternet.com (mailomta10-sa.btinternet.com [213.120.69.16]) by sourceware.org (Postfix) with ESMTPS id E60B0387605F for ; Mon, 16 Mar 2020 19:04:41 +0000 (GMT) Received: from sa-prd-rgout-004.btmx-prd.synchronoss.net ([10.2.38.7]) by sa-prd-fep-040.btinternet.com with ESMTP id <20200316190440.MCSZ30239.sa-prd-fep-040.btinternet.com@sa-prd-rgout-004.btmx-prd.synchronoss.net>; Mon, 16 Mar 2020 19:04:40 +0000 Authentication-Results: btinternet.com; auth=pass (PLAIN) smtp.auth=jonturney@btinternet.com X-Originating-IP: [31.51.205.86] X-OWM-Source-IP: 31.51.205.86 (GB) X-OWM-Env-Sender: jonturney@btinternet.com X-VadeSecure-score: verdict=clean score=0/300, class=clean X-RazorGate-Vade: gggruggvucftvghtrhhoucdtuddrgedugedrudeffedguddulecutefuodetggdotefrodftvfcurfhrohhfihhlvgemuceutffkvffkuffjvffgnffgvefqofdpqfgfvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepuffvfhfhkffffgggjggtgfesthejredttdefjeenucfhrhhomheplfhonhcuvfhurhhnvgihuceojhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukheqnecuffhomhgrihhnpehsohhurhgtvgifrghrvgdrohhrghenucfkphepfedurdehuddrvddthedrkeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehhvghloheplgduledvrdduieekrddurdduudejngdpihhnvghtpeefuddrhedurddvtdehrdekiedpmhgrihhlfhhrohhmpeeojhhonhdrthhurhhnvgihsegurhhonhgvtghouggvrdhorhhgrdhukhequceuqfffjgepkeeukffvoffkoffgpdhrtghpthhtohepoehguggsqdhprghttghhvghssehsohhurhgtvgifrghrvgdrohhrgheqpdhrtghpthhtohepoehsihhmohhnrdhmrghrtghhihesphholhihmhhtlhdrtggrqe X-RazorGate-Vade-Verdict: clean 0 X-RazorGate-Vade-Classification: clean Received: from [192.168.1.117] (31.51.205.86) by sa-prd-rgout-004.btmx-prd.synchronoss.net (5.8.340) (authenticated as jonturney@btinternet.com) id 5E3A27DB06398711; Mon, 16 Mar 2020 19:04:40 +0000 Subject: Re: [PATCH 0/7] Add "Windows" OS ABI To: gdb-patches@sourceware.org References: <20200316170845.184386-1-simon.marchi@polymtl.ca> <83blowb3bl.fsf@gnu.org> <729be9e0-77bd-2837-48b1-5bc999ae6ceb@polymtl.ca> From: Jon Turney Message-ID: <23882e40-acaa-0bd5-fc1c-c89b94ae1fe9@dronecode.org.uk> Date: Mon, 16 Mar 2020 19:04:40 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <729be9e0-77bd-2837-48b1-5bc999ae6ceb@polymtl.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=1.5 required=5.0 tests=FORGED_SPF_HELO, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW, SPF_HELO_PASS, SPF_NONE autolearn=no autolearn_force=no version=3.4.2 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Mar 2020 19:04:43 -0000 On 16/03/2020 17:48, Simon Marchi wrote: > On 2020-03-16 1:46 p.m., Eli Zaretskii wrote: >>> From: Simon Marchi >>> Cc: Eli Zaretskii , >>> Jon Turney , >>> Simon Marchi >>> Date: Mon, 16 Mar 2020 13:08:38 -0400 >>> >>> This patchset started out as a single patch to have the OS ABI Cygwin >>> applied to Windows x86-64 binaries, here: >>> >>> https://sourceware.org/legacy-ml/gdb-patches/2020-03/msg00195.html >>> >>> with the follow-up here: >>> >>> https://sourceware.org/pipermail/gdb-patches/2020-March/000022.html >>> >>> Eli pointed out that it doesn't make sense for binaries compilied with >>> MinGW to have the Cygwin OS ABI, that there should be separate OS ABIs >>> for Cygwin and non-Cygwin Windows binaries. This already came up in the >>> following bug report: >>> >>> https://sourceware.org/bugzilla/show_bug.cgi?id=21500#add_comment >>> >>> This patchset does a bit of refactor in that area. Most importantly, it: >>> >>> - adds a "Windows" OS ABI >>> - makes GDB recognize the proper OS ABI (Cygwin or Windows) when >>> loading executables >>> - makes the builtin long type on Cygwin be 64 bits long >> >> Thanks for working on this, the changes LGTM. >> > > Thanks for taking a look, I'll give a bit more time for others (Jon might be > interested) to take a look if and comment. Patches look good, and appear work correctly in some brief testing.