From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8xF+H95Ju2aPqAUAWB0awg (envelope-from ) for ; Tue, 13 Aug 2024 07:56:14 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RxDHLkfB; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 77D901E0D0; Tue, 13 Aug 2024 07:56:14 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 31A881E08C for ; Tue, 13 Aug 2024 07:56:12 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E4BE93858D34 for ; Tue, 13 Aug 2024 11:56:11 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id DFCBC3858D20 for ; Tue, 13 Aug 2024 11:55:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DFCBC3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DFCBC3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1723550149; cv=none; b=bKBgKaaoRk2adjWZbRvG0LUJ6oBhLuxcuPHzSYEKhjfOD0lQmRz0FZiEKGXJZS0vzSNm7qIgapEKoPD+ZUsv6dDwKIQymU82IyniXVDoBDexI8ADpj4gSJ6DelfYCUmMunC7KUtof4DtHgvov9qjacASmcCbt2Q0nZ2XF/m2eIs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1723550149; c=relaxed/simple; bh=w6bRyZSbvuZAjxSFv4OcW4FmY0vXuBmWkhtrzdbS7m0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=aLBIc17K9mwJztyynKmF2GaxsQICVvwMynhYPwyS9w4FKcmmrwFU+z+hRnBcq8Q09vZFCCBgSP4bhR9IJf/JcW6T08YEVV7qdT4z39URDS+cLOkprw/gd3wsTWSPTASu8biCbbVjAR8ATxfA6uQRxK5d4kEVtdtqiif4jOVKF8U= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723550147; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NYf/lzV2BUYTbftGTzLuR6OLdyMzw4bLYFUQz21D2zU=; b=RxDHLkfB5oGTixZcnIS8hkRK/bbJALuMzXL4n7OjPLRUc1uI4antqP3Wn1I5MYIiw432ZU NIpyuU3L4TU66HbRSZy8VHiFjy25uyp+l5L52wT1otHQ30wYyMBvuXV7ukfzbX2XAFtrtn VDl1H9ZyBEvu860VyTI1s1Rdwl33LSg= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-185-xLsbXOK1MkiOKeC0G5b3wA-1; Tue, 13 Aug 2024 07:55:46 -0400 X-MC-Unique: xLsbXOK1MkiOKeC0G5b3wA-1 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-1fd72932d74so50952895ad.1 for ; Tue, 13 Aug 2024 04:55:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723550145; x=1724154945; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NYf/lzV2BUYTbftGTzLuR6OLdyMzw4bLYFUQz21D2zU=; b=N/OD+aQfQ72tBoKvivogjpZxMLwdRrfzHUSZNR/i/Ww44GipMgE+lZ5IoncxfkhJ5f iI4YR7Ho6USLebaTCUbm9lALe3ledTRrrf94Iy++LDHiV9RyZZM4zFiLvwu20OB6nPPW 90TvK/hqP1HzvnP2FAUS+8gBMmuCPMajfZYaMkjFZ5NViapHw4byl+0NgPuJ4A0dF3cZ eRybsyoM8eea5pL1m2ggIMFxXRdWbqhk2DiIei1AeBUCB6oa5/tL5lFqSNalhAxnSP5Q pQUZGM7zM3AihwfboA8R/lOBqX7suWtowQ7aixHm653k9FzpuHCOaTP5EZNqGdTZIvs1 ftRw== X-Gm-Message-State: AOJu0YxOgCyTkChl0BazPH0/2XUh4DCe/iQIjMXUoFYjWXiXoy3qc78e NF2mGIybE4p4jwPKavr14sj2cpbjLWMIk2fLYwwbVr3bc1g0Fz/CggZfGt4BOgc76RJMLhWtD8A hQANF+v3KClFub5kxsQcpc+py8zHVJJy0Xxz+HB+aGhWRlC4n0KprXYo+ET1rHxJW5d4= X-Received: by 2002:a17:902:c408:b0:1fb:cf82:11b4 with SMTP id d9443c01a7336-201ca12a866mr39416785ad.6.1723550145011; Tue, 13 Aug 2024 04:55:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFbwDDJXgX1vxyI/g0q2awOVCHTppWvOW76yx76Rf/9n+DaTcZsAMGI2EdMTLuK8zTlGq9sZw== X-Received: by 2002:a17:902:c408:b0:1fb:cf82:11b4 with SMTP id d9443c01a7336-201ca12a866mr39416575ad.6.1723550144545; Tue, 13 Aug 2024 04:55:44 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:92c5::1002? ([2804:14d:8084:92c5::1002]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-201cd14ab01sm12022935ad.82.2024.08.13.04.55.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Aug 2024 04:55:44 -0700 (PDT) Message-ID: <23584087-2048-4904-825a-48b0f9d60ebb@redhat.com> Date: Tue, 13 Aug 2024 08:55:40 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6] Change message when reaching end of reverse history. To: "Metzger, Markus T" , Alex Chronopoulos Cc: "gdb-patches@sourceware.org" References: <20240802164306.252264-1-achronop@gmail.com> <9388437d-557d-45df-8513-d0a91a8e97a7@redhat.com> From: Guinevere Larsen In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/13/24 5:52 AM, Metzger, Markus T wrote: > Hello Alex, > >>> In a record session, when we move backward, GDB switches from normal >>> execution to simulation. Moving forward again, the emulation continues >>> until the end of the reverse history. When the end is reached, the >>> execution stops, and a warning message is shown. This message has been >>> modified to indicate that the forward emulation has reached the end, but >>> the execution can continue as normal, and the recording will also continue. >>> >>> Before this patch, the warning message shown in that case was the same as >>> in the reverse case. This meant that when the end of history was reached in >>> either backward or forward emulation, the same message was displayed: >>> >>> "No more reverse-execution history." >>> >>> This message has changed for these two cases. Backward emulation: >>> >>> "Reached end of recorded history; stopping. >>> Backward execution from here not possible." >>> >>> Forward emulation: >>> >>> "Reached end of recorded history; stopping. >>> Following forward execution will be added to history." >>> >>> The reason for this change is that the initial message was deceiving, for >>> the forward case, making the user believe that forward debugging could not >>> continue. >>> >>> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31224 >>> --- >> Hi! I think this is good to go in, but I would like Markus to chime in >> before pushing, since he mantains the other record subsystem, so for now >> >> Reviewed-By: Guinevere Larsen > OK for btrace. Awesome! Alex, feel free to change my tag to: Approved-By: Guinevere Larsen Do you already have write after approval rights for the repo? If not, do you plan to send more patches, so it makes sense to go after it? If not, I can push this for you :) -- Cheers, Guinevere Larsen She/Her/Hers > > Markus. > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928