From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50879 invoked by alias); 2 Jun 2017 18:34:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 50825 invoked by uid 89); 2 Jun 2017 18:34:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=years, year's X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 Jun 2017 18:34:51 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A461FC0587C3; Fri, 2 Jun 2017 18:34:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A461FC0587C3 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A461FC0587C3 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 05F535C8A3; Fri, 2 Jun 2017 18:34:53 +0000 (UTC) Subject: Re: [RFA 13/23] Replace tui_restore_gdbout with scoped_restore To: Tom Tromey , gdb-patches@sourceware.org References: <20170503224626.2818-1-tom@tromey.com> <20170503224626.2818-14-tom@tromey.com> From: Pedro Alves Message-ID: <23500f67-c151-4d85-e65b-7ead0a7f12fa@redhat.com> Date: Fri, 02 Jun 2017 18:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170503224626.2818-14-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00064.txt.bz2 On 05/03/2017 11:46 PM, Tom Tromey wrote: > This patch replaces tui_restore_gdbout (a cleaup function) with a use > of scoped_restore. This one is broken out into its own patch because > it might slightly change the behavior of gdb: it saves and restores > pagination_enabled, whereas the tui_restore_gdbout unconditionally set > pagination_enabled to 1; and I think this warrants closer review. > > 2017-05-02 Tom Tromey > > * tui/tui-regs.c (tui_restore_gdbout): Remove. > (tui_register_format): Use scoped_restore. I think I ran into this in last year's console work (in an earlier prototype.). It just looks bogus to me to unconditionally enable pagination. Patch is OK. Thanks, Pedro Alves