From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47331 invoked by alias); 29 Jan 2020 14:04:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47315 invoked by uid 89); 29 Jan 2020 14:04:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=boards X-HELO: mail-qk1-f193.google.com Received: from mail-qk1-f193.google.com (HELO mail-qk1-f193.google.com) (209.85.222.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Jan 2020 14:04:25 +0000 Received: by mail-qk1-f193.google.com with SMTP id v195so17032298qkb.11 for ; Wed, 29 Jan 2020 06:04:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XxmXV3KdgUxrnfhHaPgztDehWmwN1fi5S34qCwQwvd8=; b=PqcRsNoqrkx9Gu7467EeHQLjeDm9xxXPSqWpKWqpDYxF6kLbCW+iY7lt70HUWuYuYw ryJKihqpY+4eiuVsrZbtf3Rlc/P5TlPCQbU7etFqxeiriU2XQFARLvArGGoLUvm2nlfx w2U8H+rThWeFLN9hRCvSaP8vCUO81ozFjQ3du1P6Ble3FNdFZuhpXejY8hlmZlgA7XDS SEqDbh3bL4BYKGe7i1gSkbLCElbQvHiW2VTtuDZ6A9IARGfUOcjDSr4bYgfTV/rllgM2 H0bm0bSayUbFnihOMXFdboB5nH1OPQuOApsU4byDKP16/THXjUqEh5sc2B7djCkIe4il 9pSg== Return-Path: Received: from [192.168.0.185] ([191.251.164.76]) by smtp.gmail.com with ESMTPSA id y26sm1134419qtc.94.2020.01.29.06.04.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jan 2020 06:04:18 -0800 (PST) Subject: Re: [PATCH 2/2,v3] [AArch64] Test handling of additional brk instruction patterns To: Simon Marchi , gdb-patches@sourceware.org Cc: tankut.baris.aktemur@intel.com, alan.hayward@arm.com References: <20200115115137.17771-1-luis.machado@linaro.org> <20200115115137.17771-3-luis.machado@linaro.org> <99a220e1-36b2-0e31-ceb7-3880bf42263c@linaro.org> From: Luis Machado Message-ID: <23182c46-7e3c-f7e8-a91c-c8cc1049bdcd@linaro.org> Date: Wed, 29 Jan 2020 14:07:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2020-01/txt/msg00928.txt.bz2 On 1/29/20 11:01 AM, Simon Marchi wrote: > On 2020-01-29 6:30 a.m., Luis Machado wrote: >>>> +# Number of expected SIGTRAP's to get. This needs to be kept in sync >>>> +# with the source file. >>>> +set expected_traps 3 >>>> +set keep_going 1 >>>> +set count 0 >>>> +set old_timeout $timeout >>>> +set timeout 10 >>> >>> Any reason you are changing the timeout? There is nothing in the test that >>> looks like it would take time. >>> >> >> If GDB doesn't support one of these instructions, it will be caught in >> an infinite loop. The reduced timeout will prevent a long wait time >> until we bail out. > > Ok. The worry I have with it is that if the target board has raised the timeout > on purpose, because it's testing with a slow target/link/emulator, then this will > cancel it. In this case I'd just leave the timeout as it is. Normally, GDB won't > be broken for this test case, so it won't matter. > > Moreover, the timeout here on my x86 machine is 10 seconds by default. I just checked > on an AArch64 box on the compile farm, it's 10 there too. So in which case was it > useful to set it to 10? > Interesting. In my mind the default was from 30 to 60. Maybe that has changed over the years. If the boards are free to set it, then that is more desirable. I'll let it be then.